Feature: serve multiple domains on a single instance #447

This Pull Request addresses #94.
We start by adding custom_domain to the blogs table.

Blogs with custom domains have special routes with higher priority, but administrative routes will remain on the instance host.

Domain administration is left to the user (and/or admin)
(but we might be able to provide a check on whether it's already correctly configured)

This Pull Request addresses #94. We start by adding `custom_domain` to the `blogs` table. Blogs with custom domains have special routes with higher priority, but administrative routes will remain on the instance host. Domain administration is left to the user (and/or admin) (but we might be able to provide a check on whether it's already correctly configured)

Codecov Report

Merging #447 into master will decrease coverage by 2.04%.
The diff coverage is 2.32%.

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   26.89%   24.84%   -2.05%     
==========================================
  Files          65       64       -1     
  Lines        8966     6375    -2591     
==========================================
- Hits         2411     1584     -827     
+ Misses       6555     4791    -1764

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/447?src=pr&el=h1) Report > Merging [#447](https://codecov.io/gh/Plume-org/Plume/pull/447?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/bdfad844d7939e757929d1643132a9346f82dd66?src=pr&el=desc) will **decrease** coverage by `2.04%`. > The diff coverage is `2.32%`. ```diff @@ Coverage Diff @@ ## master #447 +/- ## ========================================== - Coverage 26.89% 24.84% -2.05% ========================================== Files 65 64 -1 Lines 8966 6375 -2591 ========================================== - Hits 2411 1584 -827 + Misses 6555 4791 -1764 ```

after taking a break to work on refactoring with Clippy (#462) , a lot has happened since:

Blogs can now be edited, and have banners and icons (#460), quite useful, if your front-page is the blog page!
We have a central Config struct (#494)
Blogs & Users now have an Fqn field which doesn't need to be recalculated (#457)

Meanwhile, a community member has reported, that Plume works via Tor, without any modifications.

Now, adding the custom domain feature, would possibly require modification.
Regardless, we need to rethink our approach to routing…
…and, i could use some help with that.

Here's some of my own thoughts:

The route ranking (alone) feels limiting in that regard.
we have two route functions which do the same thing, only slightly different, so this needs some abstraction
we have two types of routes: known domain, or default domain (this could would also be taken for unknown domains)
to properly map onion domains, the Host would need to become an array

A closing summary: it would be nice if route functions with custom_domains: Host(s) were automatically ranked higher, otherwise, we'd need to split the mounting of routes into: known-domains / unknown or default domain.

after taking a break to work on refactoring with Clippy (#462) , a lot has happened since: - Blogs can now be edited, and have banners and icons (#460), quite useful, if your front-page is the blog page! - We have a central Config struct (#494) - Blogs & Users now have an Fqn field which doesn't need to be recalculated (#457) Meanwhile, a community member has reported, that Plume works via Tor, without any modifications. Now, adding the custom domain feature, would possibly require modification. Regardless, we need to rethink our approach to routing… …and, i could use some help with that. Here's some of my own thoughts: - The route ranking (alone) feels limiting in that regard. - we have two route functions which do the same thing, only slightly different, so this needs some abstraction - we have two types of routes: known domain, or default domain (this could would also be taken for unknown domains) - to properly map onion domains, the `Host` would need to become an array A closing summary: it would be nice if route functions with `custom_domains: Host(s)` were automatically ranked higher, otherwise, we'd need to split the mounting of routes into: known-domains / unknown or default domain.

some thoughts, after a long hiatus

 @ -20,2 +20,4 @@
 use template_utils::Ructe;
 #[get("/?<page>", rank = 2)]
 pub fn custom_details(

標籤 里程碑

Feature: serve multiple domains on a single instance #447

Codecov Report

第一步：

第二步：

 @ -0,0 +1,2 @@
 -- Adding custom domain to Blog as an optional field
 ALTER TABLE blogs ADD COLUMN custom_domain VARCHAR DEFAULT NULL UNIQUE;

標籤 里程碑

Feature: serve multiple domains on a single instance #447

Codecov Report

第一步：

第二步：

標籤里程碑