Plume
/
Plume
8
16
Atdalīts 22
Kods Problēmas 174 Izmaiņu pieprasījumi 8 Laidieni 8 Vikivietne Aktivitāte

Etiķetes Atskaites punkti

Password reset #448

Sapludināts
elegaanz sapludināja 10 revīzijas no password-reset uz master pirms 5 gadiem
Saruna 5 Revīzijas 10 Izmainītie faili 21
elegaanz " komentēja pirms 5 gadiem" (Migrēts no github.com)

There is now a link on the login page if you forgot your password. It redirects you to a page asking your email address. An email containing a password reset link will be sent to this address if someone registered with this address. The link is only valid for 15 minutes.

I used the lettre crate for mail finally since I didn't find a way to set a subject with mailstrom (which is very weird). It also allowed me to implement a debug mail sender, that can be enabled with --feature debug-mailer and that will log mails instead of actually sending them.

I should also document the new configuration options for the mail server. Done (but I can still modify it again if you don't like the current approach)

Fixes #298

There is now a link on the login page if you forgot your password. It redirects you to a page asking your email address. An email containing a password reset link will be sent to this address if someone registered with this address. The link is only valid for 15 minutes. I used the `lettre` crate for mail finally since I didn't find a way to set a subject with `mailstrom` (which is very weird). It also allowed me to implement a debug mail sender, that can be enabled with `--feature debug-mailer` and that will log mails instead of actually sending them. ~~I should also document the new configuration options for the mail server.~~ Done (but I can still modify it again if you don't like the current approach) Fixes #298
codecov[bot] " komentēja pirms 5 gadiem" (Migrēts no github.com)

Codecov Report

Merging #448 into master will decrease coverage by 0.49%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #448     +/-   ##
=========================================
- Coverage   25.45%   24.96%   -0.5%     
=========================================
  Files          63       64      +1     
  Lines        6285     6409    +124     
=========================================
  Hits         1600     1600             
- Misses       4685     4809    +124
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/448?src=pr&el=h1) Report > Merging [#448](https://codecov.io/gh/Plume-org/Plume/pull/448?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/7bac70a4830eb660506b9cd9603fe013225a74a0?src=pr&el=desc) will **decrease** coverage by `0.49%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #448 +/- ## ========================================= - Coverage 25.45% 24.96% -0.5% ========================================= Files 63 64 +1 Lines 6285 6409 +124 ========================================= Hits 1600 1600 - Misses 4685 4809 +124 ```
codecov[bot] " komentēja pirms 5 gadiem" (Migrēts no github.com)

Codecov Report

Merging #448 into master will increase coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   25.45%   25.49%   +0.03%     
==========================================
  Files          63       64       +1     
  Lines        6285     6480     +195     
==========================================
+ Hits         1600     1652      +52     
- Misses       4685     4828     +143
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/448?src=pr&el=h1) Report > Merging [#448](https://codecov.io/gh/Plume-org/Plume/pull/448?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/7bac70a4830eb660506b9cd9603fe013225a74a0?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #448 +/- ## ========================================== + Coverage 25.45% 25.49% +0.03% ========================================== Files 63 64 +1 Lines 6285 6480 +195 ========================================== + Hits 1600 1652 +52 - Misses 4685 4828 +143 ```
trinity-1686a recenzēja pirms 5 gadiem
trinity-1686a atstāja komentāru
Īpašnieks

I haven't tested it yet, just made some observations on the code. Most comments are code-style, so this is mostly good

I haven't tested it yet, just made some observations on the code. Most comments are code-style, so this is mostly good
src/mail.rs
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

you should reorder imports so all feature=debug and all not(feature=debug) are segregated, it'll make thinks easier to read and maintain
The ideal may be to have 2 private mods, one debug and one release (or whatever), and re-export only the one enabled

you should reorder imports so all `feature=debug` and all `not(feature=debug)` are segregated, it'll make thinks easier to read and maintain The ideal may be to have 2 private mods, one `debug` and one `release` (or whatever), and re-export only the one enabled
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

Maybe this would be more at it's place in plume-model than in plume itself?

Maybe this would be more at it's place in plume-model than in plume itself?
src/routes/session.rs
@ -101,3 +105,140 @@ pub fn delete(mut cookies: Cookies) -> Redirect {
}
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

I think this statement could be made into a single function in src/mails.rs (or wherever it move), which take in parameter subject and content, so it can be easily reused later if we send other kinds of mails (moderation warnings or whatever when it will get implemented)

I think this statement could be made into a single function in `src/mails.rs` (or wherever it move), which take in parameter subject and content, so it can be easily reused later if we send other kinds of mails (moderation warnings or whatever when it will get implemented)
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

15 minutes seems shorts, I'd advise something like 1 or 2 hours instead, mails can be long to transmit

15 minutes seems shorts, I'd advise something like 1 or 2 hours instead, mails can be long to transmit
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

to prevent the State<...> from growing up in memory (basically be a memory leak), you should filter and eliminate old entries either with the internal scheduler, or somewhere like here

to prevent the `State<...>` from growing up in memory (basically be a memory leak), you should filter and eliminate old entries either with the internal scheduler, or somewhere like here
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

you should check if there haven't already be a link sent recently, otherwise one might use it to spam a user by sending them many reset links

you should check if there haven't already be a link sent recently, otherwise one might use it to spam a user by sending them many reset links
trinity-1686a recenzēja pirms 5 gadiem
trinity-1686a atstāja komentāru
Īpašnieks

Apparently letter won't compile on Archlinux, it requires an old version of openssl that Arch don't provide. I'll spin up a debian vm this afternoon to actually test the code, and try to fix this with upstream

Apparently letter won't compile on Archlinux, it requires an old version of openssl that Arch don't provide. I'll spin up a debian vm this afternoon to actually test the code, and try to fix this with upstream
src/routes/session.rs
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

that's 24 minutes, not 24 hours

that's 24 minutes, not 24 hours
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

that's 2 minutes, not 2 hours

that's 2 minutes, not 2 hours
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

You should maintain the lock instead of locking and unlocking many times

You should maintain the lock instead of locking and unlocking many times
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

I think using ! .any(|x|...) would be easier to read

I think using ! .any(|x|...) would be easier to read
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

you should remove before checking if there is already an entry, otherwise one asking for a second reset link after, says, 12 hours, won't get it's mail. Also this mean the vec is cleaned only when a valid request is made, so if nobody else request a password reset, one wont ever get unlocked

you should remove before checking if there is already an entry, otherwise one asking for a second reset link after, says, 12 hours, won't get it's mail. Also this mean the vec is cleaned only when a valid request is made, so if nobody else request a password reset, one wont ever get unlocked
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

Instead of building a Vec, then "substracting" if from the one stored, building directly the right one and mem::replace-ing it seems easier to read, and don't require to enable another feature
snippet :

let a = Mutex::new(vec![1,2,3]);
std::mem::replace(&mut *a.lock().unwrap(), vec![4,5,6]);
Instead of building a Vec, then "substracting" if from the one stored, building directly the right one and mem::replace-ing it seems easier to read, and don't require to enable another feature snippet : ```rust let a = Mutex::new(vec![1,2,3]); std::mem::replace(&mut *a.lock().unwrap(), vec![4,5,6]); ```
elegaanz (Migrēts no github.com) recenzēja pirms 5 gadiem
src/routes/session.rs
elegaanz (Migrēts no github.com) " komentēja pirms 5 gadiem"

Oops looks like I don't know how time is working 😬

Oops looks like I don't know how time is working :grimacing:
elegaanz (Migrēts no github.com) recenzēja pirms 5 gadiem
src/routes/session.rs
elegaanz (Migrēts no github.com) " komentēja pirms 5 gadiem"

I can't because I need to borrow it both mutably and immutably and Rust won't let me do that. But maybe there is a solution to do it I didn't find?

I can't because I need to borrow it both mutably and immutably and Rust won't let me do that. But maybe there is a solution to do it I didn't find?
trinity-1686a recenzēja pirms 5 gadiem
src/routes/session.rs
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

I've removed a lot of code, but here is a poc of how I would do it (and some other things, trashing old things sooner and don't use the feature) https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=2c32af184c99ff62ee99f94aa2e4fa13
Sadly I can't compile this branch so I can't give you a clean commit, but it should put you on the right track

I've removed a lot of code, but here is a poc of how I would do it (and some other things, trashing old things sooner and don't use the feature) https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=2c32af184c99ff62ee99f94aa2e4fa13 Sadly I can't compile this branch so I can't give you a clean commit, but it should put you on the right track
trinity-1686a recenzēja pirms 5 gadiem
src/routes/session.rs
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

(I found a better way to do it, see the link to the playground)

(I found a better way to do it, see the link to the playground)
trinity-1686a recenzēja pirms 5 gadiem
src/routes/session.rs
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

and again, that's 2.4 hours

and again, that's 2.4 hours
igalic (Migrēts no github.com) recenzēja pirms 5 gadiem
src/routes/session.rs
igalic (Migrēts no github.com) " komentēja pirms 5 gadiem"

why is math so hard? why are there no as_minutes() and as_hours() functions?!??

why is math so hard? why are there no `as_minutes()` and `as_hours()` functions?!??
trinity-1686a recenzēja pirms 5 gadiem
trinity-1686a atstāja komentāru
Īpašnieks

👍

:+1:
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

It doesn't seems to compile with debug-mailer on

It doesn't seems to compile with debug-mailer on
trinity-1686a apstiprināja izmaiņas pirms 5 gadiem
trinity-1686a atstāja komentāru
Īpašnieks

Something should also be added in the documentation regarding new environment variables

Something should also be added in the documentation regarding new environment variables
elegaanz " komentēja pirms 5 gadiem" (Migrēts no github.com)

Already done 😁, see https://docs.joinplu.me/environment/ and https://docs.joinplu.me/installation/config/

Already done :grin:, see https://docs.joinplu.me/environment/ and https://docs.joinplu.me/installation/config/
👍 1
trinity-1686a " komentēja pirms 5 gadiem"
Īpašnieks

Mb, I did not check it before. I think however Docker documentation should be updated, as it says only 2 vars need changes, whereas MAIL_* do too

Mb, I did not check it before. I think however Docker documentation should be updated, as it says only 2 vars need changes, whereas MAIL_* do too
👍 1

Recenzenti

trinity-1686a apstiprināja izmaiņas pirms 5 gadiem
Izmaiņu pieprasījums tika sapludināts ar revīziju a2b9d7ec44.
Varat aplūkot arī komandrindas instrukcijas.

Solis 1:

Projekta repozitorijā izveidojiet jaunu jaunu atzaru un pārbaudiet savas izmaiņas.
git checkout -b password-reset master
git pull origin password-reset

Solis 2:

Sapludināt izmaiņas un atjaunot tās Forgejo.
git checkout master
git merge --no-ff password-reset
git push origin master
Pierakstieties, lai pievienotos šai sarunai.
Recenzenti
Pieprasīt recenziju
Nav recenzentu
trinity-1686a
Etiķetes
Apstiprināt etiķetes
Noņemt etiķetes   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Nav etiķešu
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Atskaites punkts
Uzstādīt atskaites punktu
Notīrīt atskaites punktus
Nav neviena ieraksta
Nav atskaites punktu
Atbildīgie
Piešķirt lietotājus
Noņemt atbildīgo
Nav atbildīgo
2 dalībnieki
Paziņojumi
Izpildes termiņš
Datums līdz nav korekts. Izmantojiet formātu 'gggg-mm-dd'.

Izpildes termiņš nav uzstādīts.

Atkarības

Nav atkarību.

Atsaucas uz: Plume/Plume#448
Rakstīt Priekšskatītījums
Notiek ielāde…
Atcelt
Saglabāt
Vēl nav satura.
Dzēst atzaru 'password-reset'

Atzara dzēšana ir neatgriezeniska, kā arī tā ir NEATGRIEZENISKA. Vai turpināt?

Nē
Jā