Немає рецензентів
Без мітки
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Етап відсутній
Немає виконавця
2 учасників
Сповіщення
Дата завершення
Термін виконання не встановлений.
Залежності
No dependencies set.
Reference: Plume/Plume#448
Завантаження…
Посилання в новій задачі
Тут ще немає жодного змісту.
Видалити гілку 'password-reset'
Видалення гілки НЕЗВОРОТНЕ. Дію не можна скасувати. Продовжити?
There is now a link on the login page if you forgot your password. It redirects you to a page asking your email address. An email containing a password reset link will be sent to this address if someone registered with this address. The link is only valid for 15 minutes.
I used the
lettrecrate for mail finally since I didn't find a way to set a subject withmailstrom(which is very weird). It also allowed me to implement a debug mail sender, that can be enabled with--feature debug-mailerand that will log mails instead of actually sending them.I should also document the new configuration options for the mail server.Done (but I can still modify it again if you don't like the current approach)Fixes #298
Codecov Report
Codecov Report
I haven't tested it yet, just made some observations on the code. Most comments are code-style, so this is mostly good
you should reorder imports so all
feature=debugand allnot(feature=debug)are segregated, it'll make thinks easier to read and maintainThe ideal may be to have 2 private mods, one
debugand onerelease(or whatever), and re-export only the one enabledMaybe this would be more at it's place in plume-model than in plume itself?
@ -101,3 +105,140 @@ pub fn delete(mut cookies: Cookies) -> Redirect {}I think this statement could be made into a single function in
src/mails.rs(or wherever it move), which take in parameter subject and content, so it can be easily reused later if we send other kinds of mails (moderation warnings or whatever when it will get implemented)15 minutes seems shorts, I'd advise something like 1 or 2 hours instead, mails can be long to transmit
to prevent the
State<...>from growing up in memory (basically be a memory leak), you should filter and eliminate old entries either with the internal scheduler, or somewhere like hereyou should check if there haven't already be a link sent recently, otherwise one might use it to spam a user by sending them many reset links
Apparently letter won't compile on Archlinux, it requires an old version of openssl that Arch don't provide. I'll spin up a debian vm this afternoon to actually test the code, and try to fix this with upstream
that's 24 minutes, not 24 hours
that's 2 minutes, not 2 hours
You should maintain the lock instead of locking and unlocking many times
I think using ! .any(|x|...) would be easier to read
you should remove before checking if there is already an entry, otherwise one asking for a second reset link after, says, 12 hours, won't get it's mail. Also this mean the vec is cleaned only when a valid request is made, so if nobody else request a password reset, one wont ever get unlocked
Instead of building a Vec, then "substracting" if from the one stored, building directly the right one and mem::replace-ing it seems easier to read, and don't require to enable another feature
snippet :
Oops looks like I don't know how time is working 😬
I can't because I need to borrow it both mutably and immutably and Rust won't let me do that. But maybe there is a solution to do it I didn't find?
I've removed a lot of code, but here is a poc of how I would do it (and some other things, trashing old things sooner and don't use the feature) https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=2c32af184c99ff62ee99f94aa2e4fa13
Sadly I can't compile this branch so I can't give you a clean commit, but it should put you on the right track
(I found a better way to do it, see the link to the playground)
and again, that's 2.4 hours
why is math so hard? why are there no
as_minutes()andas_hours()functions?!??👍
It doesn't seems to compile with debug-mailer on
Something should also be added in the documentation regarding new environment variables
Already done 😁, see https://docs.joinplu.me/environment/ and https://docs.joinplu.me/installation/config/
Mb, I did not check it before. I think however Docker documentation should be updated, as it says only 2 vars need changes, whereas MAIL_* do too
Рецензенти
a2b9d7ec44.Крок 1:
У репозиторії вашого проєкту перевірте нову гілку і протестуйте зміни.Крок 2:
Об'єднати зміни і оновити на Forgejo.