Plume
/
Plume
8
16
Разклонения 22
Код Задачи 174 Заявки за сливане 8 Версии 8 Уики Activity

Етикети Етапи

Slightly improve the media experience #452

Обединени
elegaanz обедини 5 ревизии от better-media във master преди 5 години
Разговор 1 Ревизии 5 Променени файлове 27
elegaanz коментира преди 5 години (Migrated from github.com)
  • Use a grid to display the list of media
  • Add icons for non-image media preview
  • Paginate the gallery
  • Add links to the gallery in the editor and in the profile settings to make it more discoverable when you need it

Here are some screenshots:

screenshot_2019-02-26 vos medias plume
screenshot_2019-02-26 nouvel article plume
screenshot_2019-02-26 modifier votre compte plume

Fixes #432

- Use a grid to display the list of media - Add icons for non-image media preview - Paginate the gallery - Add links to the gallery in the editor and in the profile settings to make it more discoverable when you need it Here are some screenshots: ![screenshot_2019-02-26 vos medias plume](https://user-images.githubusercontent.com/16254623/53444828-70a08800-3a0f-11e9-97ee-a7a265287623.png) ![screenshot_2019-02-26 nouvel article plume](https://user-images.githubusercontent.com/16254623/53444832-74cca580-3a0f-11e9-9f9a-29460480ec24.png) ![screenshot_2019-02-26 modifier votre compte plume](https://user-images.githubusercontent.com/16254623/53444842-7bf3b380-3a0f-11e9-82d9-fbfd06b3f753.png) Fixes #432
🎉 1
codecov[bot] коментира преди 5 години (Migrated from github.com)

Codecov Report

Merging #452 into master will increase coverage by 1%.
The diff coverage is 19.64%.

@@            Coverage Diff            @@
##           master     #452     +/-   ##
=========================================
+ Coverage   25.73%   26.74%     +1%     
=========================================
  Files          63       64      +1     
  Lines        6150     7223   +1073     
=========================================
+ Hits         1583     1932    +349     
- Misses       4567     5291    +724
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/452?src=pr&el=h1) Report > Merging [#452](https://codecov.io/gh/Plume-org/Plume/pull/452?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/e28371bbe4bda5d338ae453a1fbe198f3dc74071?src=pr&el=desc) will **increase** coverage by `1%`. > The diff coverage is `19.64%`. ```diff @@ Coverage Diff @@ ## master #452 +/- ## ========================================= + Coverage 25.73% 26.74% +1% ========================================= Files 63 64 +1 Lines 6150 7223 +1073 ========================================= + Hits 1583 1932 +349 - Misses 4567 5291 +724 ```
trinity-1686a reviewed преди 5 години
trinity-1686a left a comment
Притежател

It feel a bit odd there are nice pictures for non image files on /media, but not on /media/<id> , otherwise this is all good

It feel a bit odd there are nice pictures for non image files on `/media`, but not on `/media/<id>` , otherwise this is all good
trinity-1686a reviewed преди 5 години
plume-models/src/safe_string.rs
trinity-1686a коментира преди 5 години
Притежател

I'm not a big fan off allowing custom class, peoples could inject div/a with the right classes to mess up the interface. I'd prefer maybe an "unsafe" (not necessary in the sens of rust's unsafe) builder for SafeString, with the contract that things put in it must already be trusted

I'm not a big fan off allowing custom class, peoples could inject div/a with the right classes to mess up the interface. I'd prefer maybe an "unsafe" (not necessary in the sens of rust's unsafe) builder for SafeString, with the contract that things put in it must already be trusted
trinity-1686a reviewed преди 5 години
plume-models/src/medias.rs
trinity-1686a коментира преди 5 години
Притежател

the alt and title can't be trusted (and trusted is unnecessary here) they are actually escaped, but url might be partially untrusted

~~the alt and title can't be trusted (and trusted is unnecessary here)~~ they are actually escaped, but url might be partially untrusted
plume-models/src/medias.rs
trinity-1686a коментира преди 5 години
Притежател

title can't be trusted. I don't know how to handle this one. Maybe have some way of concatenating SafeString, and do concat(trusted("<div></div>"),new("<audio/>"))
title is actually escaped, but url might be partially untrusted atm

~~title can't be trusted. I don't know how to handle this one. Maybe have some way of concatenating SafeString, and do `concat(trusted("<div></div>"),new("<audio/>"))`~~ title is actually escaped, but url might be partially untrusted atm
plume-models/src/medias.rs
trinity-1686a коментира преди 5 години
Притежател

title can't be trusted (and would be unnecessary here if we keep video/audio allowed)
title is actually escaped, but url might be partially untrusted atm

~~title can't be trusted (and would be unnecessary here if we keep video/audio allowed)~~ title is actually escaped, but url might be partially untrusted atm
plume-models/src/safe_string.rs
@ -22,3 +22,3 @@
.add_tags(iter::once("iframe"))
.add_tags(&[ "iframe", "video", "audio" ])
.id_prefix(Some("postcontent-"))
.url_relative(UrlRelative::Custom(Box::new(url_add_prefix)))
trinity-1686a коментира преди 5 години
Притежател

I think we should keep video and audio tags, So that people can insert media content in their posts

I think we should keep video and audio tags, So that people can insert media content in their posts
trinity-1686a approved these changes преди 5 години
trinity-1686a left a comment
Притежател

👍

:+1:

Reviewers

trinity-1686a approved these changes преди 5 години
Тази заявка за сливане е била обединена като eff2698664.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b better-media master
git pull origin better-media

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff better-media
git push origin master
Впишете се за да се присъедините към разговора.
Reviewers
Request review
No reviewers
trinity-1686a
Етикети
Apply labels
Изчисти етикети   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Няма етикет
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Етап
Set milestone
Изчисти етап
No items
Няма етап
Изпълнители
Assign users
Изчисти изпълнители
Няма изпълнители
2 участника
Известия
Due Date
Крайният срок е невалиден или извън обхват. Моля използвайте форматът 'гггг-мм-дд'.

No due date set.

Зависимости

No dependencies set.

Reference: Plume/Plume#452
Пиши Преглед
Зареждане…
Отказ
Запис
Все още няма съдържание.
Delete Branch 'better-media'

Deleting a branch is permanent. It CANNOT be undone. Continue?

Не
Да