Slightly improve the media experience
#452
Fusionnée
elegaanz
a fusionné 5 révision(s) à partir de better-media
vers master
il y a 5 ans
Relecteurs
Demander une revue
Aucune évaluation
Étiquettes
Effacer les étiquettes
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Appliquer une étiquette
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
Pas d'étiquette
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Jalon
Affecter un jalon
Effacer le jalon
Pas d'élément
Aucun jalon
Affecté à
Assigner des utilisateurs
Supprimer les affectations
Pas d'assignataires
2 participants
Notifications
Échéance
La date d’échéance est invalide ou hors plage. Veuillez utiliser le format 'aaaa-mm-dd'.
Aucune échéance n'a été définie.
Dépendances
No dependencies set.
Reference: Plume/Plume#452
Référencer dans un nouveau ticket
Il n'existe pas encore de contenu.
Supprimer la branche 'better-media'
Supprimer une branche est permanent. Cela NE PEUVENT être annulées. Continuer ?
Non
Oui
Here are some screenshots:
Fixes #432
Codecov Report
It feel a bit odd there are nice pictures for non image files on
/media
, but not on/media/<id>
, otherwise this is all goodI'm not a big fan off allowing custom class, peoples could inject div/a with the right classes to mess up the interface. I'd prefer maybe an "unsafe" (not necessary in the sens of rust's unsafe) builder for SafeString, with the contract that things put in it must already be trusted
the alt and title can't be trusted (and trusted is unnecessary here)they are actually escaped, but url might be partially untrustedtitle can't be trusted. I don't know how to handle this one. Maybe have some way of concatenating SafeString, and doconcat(trusted("<div></div>"),new("<audio/>"))
title is actually escaped, but url might be partially untrusted atm
title can't be trusted (and would be unnecessary here if we keep video/audio allowed)title is actually escaped, but url might be partially untrusted atm
@ -22,3 +22,3 @@
.add_tags(iter::once("iframe"))
.add_tags(&[ "iframe", "video", "audio" ])
.id_prefix(Some("postcontent-"))
.url_relative(UrlRelative::Custom(Box::new(url_add_prefix)))
I think we should keep video and audio tags, So that people can insert media content in their posts
👍
Relecteurs
eff2698664
.Étape 1:
Depuis le dépôt de votre projet, sélectionnez une nouvelle branche et testez les modifications.Étape 2:
Fusionner les modifications et mettre à jour sur Forgejo.