Fix follow IDs #455

Sloučený
elegaanz sloučil 4 commity z větve fix-follow-id do větve master před před 5 roky
elegaanz okomentoval před 5 roky (Migrováno z github.com)

I changed the syntax of the insert! macro, allowing to modify an object just after it was saved to the database. You can now optional pass it a "closure" (actually it just looks like a closure) that will be run just after the insertion.

I updated all the models, including Follow, to use it to generate AP ID and URL. The advantages are that the ID/URL are now correct (fixes #449) and that we don't have methods like update_boxes or update_ap_url to call manually and that were easy to forget.

I changed the syntax of the `insert!` macro, allowing to modify an object just after it was saved to the database. You can now optional pass it a "closure" (actually it just looks like a closure) that will be run just after the insertion. I updated all the models, including Follow, to use it to generate AP ID and URL. The advantages are that the ID/URL are now correct (fixes #449) and that we don't have methods like `update_boxes` or `update_ap_url` to call manually and that were easy to forget.
elegaanz (Migrováno z github.com) posoudil před 5 roky
@ -228,4 +228,3 @@
post.cover_id = form.cover;
post.update(&*conn, &searcher).expect("post::update: update error");;
let post = post.update_ap_url(&*conn).expect("post::update: update ap url error");
elegaanz (Migrováno z github.com) okomentoval před 5 roky

Just a note: I removed that without replacing it with something else, since it is incorrect (the AP IDs should change), and was not working anyway (since we were checking if ap_url was empty before updating it, which was only the case on newly created articles).

Just a note: I removed that without replacing it with something else, since it is incorrect (the AP IDs should change), and was not working anyway (since we were checking if `ap_url` was empty before updating it, which was only the case on newly created articles).
codecov[bot] okomentoval před 5 roky (Migrováno z github.com)

Codecov Report

Merging #455 into master will increase coverage by 1.41%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
+ Coverage   25.06%   26.48%   +1.41%     
==========================================
  Files          64       64              
  Lines        6316     7111     +795     
==========================================
+ Hits         1583     1883     +300     
- Misses       4733     5228     +495
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/455?src=pr&el=h1) Report > Merging [#455](https://codecov.io/gh/Plume-org/Plume/pull/455?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a2b9d7ec44daf91d5b0dde00715d7185b5342c94?src=pr&el=desc) will **increase** coverage by `1.41%`. > The diff coverage is `79.31%`. ```diff @@ Coverage Diff @@ ## master #455 +/- ## ========================================== + Coverage 25.06% 26.48% +1.41% ========================================== Files 64 64 Lines 6316 7111 +795 ========================================== + Hits 1583 1883 +300 - Misses 4733 5228 +495 ```
trinity-1686a schválil tyto změny před 5 roky
trinity-1686a zanechal komentář
Vlastník

LGTM

LGTM
Vlastník

I've never used this syntax, but it looks super nice

I've never used this syntax, but it looks super nice
Vlastník

this route should really get implemented one day

this route should really get implemented one day
elegaanz (Migrováno z github.com) posoudil před 5 roky
elegaanz (Migrováno z github.com) okomentoval před 5 roky

Yes, I think we already have an issue for it…

Yes, I think we already have an issue for it…
igalic (Migrováno z github.com) posoudil před 5 roky
igalic (Migrováno z github.com) okomentoval před 5 roky

what does it do?

what does it do?
elegaanz (Migrováno z github.com) posoudil před 5 roky
elegaanz (Migrováno z github.com) okomentoval před 5 roky

For all the fields that were not provided, it takes their value from the given struct (here NewBlog::default()).

For all the fields that were not provided, it takes their value from the given struct (here `NewBlog::default()`).

Posuzovatelé

trinity-1686a schválil tyto změny před 5 roky
Požadavek na natažení byl sloučen jako 2a188abfa1.
Můžete také zobrazit instrukce příkazové řádky.

Krok 1:

Z vašeho repositáře projektu se podívejte na novou větev a vyzkoušejte změny.
git checkout -b fix-follow-id master
git pull origin fix-follow-id

Krok 2:

Slučte změny a aktualizujte je na Forgejo.
git checkout master
git merge --no-ff fix-follow-id
git push origin master
Přihlaste se pro zapojení do konverzace.
Žádní posuzovatelé
Bez milníku
Bez zpracovatelů
2 účastníků
Oznámení
Termín dokončení
Termín dokončení není platný nebo je mimo rozsah. Použijte prosím formát „rrrr-mm-dd“.

Žádný termín dokončení.

Závislosti

Nejsou nastaveny žádné závislosti.

Reference: Plume/Plume#455
Načítá se…
Není zde žádný obsah.