Fix follow IDs #455

trinity-1686a · 2019-02-27T17:55:14Z

elegaanz hat

2019-02-27 17:55:14 +00:00

kommentiert (Migriert von github.com)

I changed the syntax of the insert! macro, allowing to modify an object just after it was saved to the database. You can now optional pass it a "closure" (actually it just looks like a closure) that will be run just after the insertion.

I updated all the models, including Follow, to use it to generate AP ID and URL. The advantages are that the ID/URL are now correct (fixes #449) and that we don't have methods like update_boxes or update_ap_url to call manually and that were easy to forget.

I changed the syntax of the `insert!` macro, allowing to modify an object just after it was saved to the database. You can now optional pass it a "closure" (actually it just looks like a closure) that will be run just after the insertion. I updated all the models, including Follow, to use it to generate AP ID and URL. The advantages are that the ID/URL are now correct (fixes #449) and that we don't have methods like `update_boxes` or `update_ap_url` to call manually and that were easy to forget.

elegaanz (Migriert von github.com) hat 2019-02-27 17:57:09 +00:00 gereviewt

src/routes/posts.rs

					
				@ -228,4 +228,3 @@

				            post.cover_id = form.cover;

				            post.update(&*conn, &searcher).expect("post::update: update error");;

				            let post = post.update_ap_url(&*conn).expect("post::update: update ap url error");

elegaanz (Migriert von github.com) hat

2019-02-27 17:57:09 +00:00

kommentiert

Just a note: I removed that without replacing it with something else, since it is incorrect (the AP IDs should change), and was not working anyway (since we were checking if ap_url was empty before updating it, which was only the case on newly created articles).

Just a note: I removed that without replacing it with something else, since it is incorrect (the AP IDs should change), and was not working anyway (since we were checking if `ap_url` was empty before updating it, which was only the case on newly created articles).

codecov[bot] hat

2019-03-04 19:40:15 +00:00

kommentiert (Migriert von github.com)

Codecov Report

Merging #455 into master will increase coverage by 1.41%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
+ Coverage   25.06%   26.48%   +1.41%     
==========================================
  Files          64       64              
  Lines        6316     7111     +795     
==========================================
+ Hits         1583     1883     +300     
- Misses       4733     5228     +495

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/455?src=pr&el=h1) Report > Merging [#455](https://codecov.io/gh/Plume-org/Plume/pull/455?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a2b9d7ec44daf91d5b0dde00715d7185b5342c94?src=pr&el=desc) will **increase** coverage by `1.41%`. > The diff coverage is `79.31%`. ```diff @@ Coverage Diff @@ ## master #455 +/- ## ========================================== + Coverage 25.06% 26.48% +1.41% ========================================== Files 64 64 Lines 6316 7111 +795 ========================================== + Hits 1583 1883 +300 - Misses 4733 5228 +495 ```

trinity-1686a hat die Änderungen 2019-03-04 19:54:46 +00:00 genehmigt

trinity-1686a hat einen Kommentar hinterlassen

Besitzer

LGTM

plume-models/src/blogs.rs

trinity-1686a hat

2019-03-04 19:45:24 +00:00

kommentiert

Besitzer

I've never used this syntax, but it looks super nice

plume-models/src/follows.rs

trinity-1686a hat