Fix follow IDs #455

Scalone
elegaanz scala 4 commity/ów z fix-follow-id do master 2019-03-04 20:35:04 +00:00
elegaanz skomentował(-a) 2019-02-27 17:55:14 +00:00 (Zmigrowane z github.com)

I changed the syntax of the insert! macro, allowing to modify an object just after it was saved to the database. You can now optional pass it a "closure" (actually it just looks like a closure) that will be run just after the insertion.

I updated all the models, including Follow, to use it to generate AP ID and URL. The advantages are that the ID/URL are now correct (fixes #449) and that we don't have methods like update_boxes or update_ap_url to call manually and that were easy to forget.

I changed the syntax of the `insert!` macro, allowing to modify an object just after it was saved to the database. You can now optional pass it a "closure" (actually it just looks like a closure) that will be run just after the insertion. I updated all the models, including Follow, to use it to generate AP ID and URL. The advantages are that the ID/URL are now correct (fixes #449) and that we don't have methods like `update_boxes` or `update_ap_url` to call manually and that were easy to forget.
elegaanz (Zmigrowane z github.com) zrecenzowano 2019-02-27 17:57:09 +00:00
@ -228,4 +228,3 @@
post.cover_id = form.cover;
post.update(&*conn, &searcher).expect("post::update: update error");;
let post = post.update_ap_url(&*conn).expect("post::update: update ap url error");
elegaanz (Zmigrowane z github.com) skomentował(-a) 2019-02-27 17:57:09 +00:00

Just a note: I removed that without replacing it with something else, since it is incorrect (the AP IDs should change), and was not working anyway (since we were checking if ap_url was empty before updating it, which was only the case on newly created articles).

Just a note: I removed that without replacing it with something else, since it is incorrect (the AP IDs should change), and was not working anyway (since we were checking if `ap_url` was empty before updating it, which was only the case on newly created articles).
codecov[bot] skomentował(-a) 2019-03-04 19:40:15 +00:00 (Zmigrowane z github.com)

Codecov Report

Merging #455 into master will increase coverage by 1.41%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
+ Coverage   25.06%   26.48%   +1.41%     
==========================================
  Files          64       64              
  Lines        6316     7111     +795     
==========================================
+ Hits         1583     1883     +300     
- Misses       4733     5228     +495
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/455?src=pr&el=h1) Report > Merging [#455](https://codecov.io/gh/Plume-org/Plume/pull/455?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a2b9d7ec44daf91d5b0dde00715d7185b5342c94?src=pr&el=desc) will **increase** coverage by `1.41%`. > The diff coverage is `79.31%`. ```diff @@ Coverage Diff @@ ## master #455 +/- ## ========================================== + Coverage 25.06% 26.48% +1.41% ========================================== Files 64 64 Lines 6316 7111 +795 ========================================== + Hits 1583 1883 +300 - Misses 4733 5228 +495 ```
trinity-1686a zatwierdza te zmiany 2019-03-04 19:54:46 +00:00
trinity-1686a zostawił komentarz
Właściciel

LGTM

LGTM
Właściciel

I've never used this syntax, but it looks super nice

I've never used this syntax, but it looks super nice
Właściciel

this route should really get implemented one day

this route should really get implemented one day
elegaanz (Zmigrowane z github.com) zrecenzowano 2019-03-04 20:23:48 +00:00
elegaanz (Zmigrowane z github.com) skomentował(-a) 2019-03-04 20:23:48 +00:00

Yes, I think we already have an issue for it…

Yes, I think we already have an issue for it…
igalic (Zmigrowane z github.com) zrecenzowano 2019-03-05 07:12:24 +00:00
igalic (Zmigrowane z github.com) skomentował(-a) 2019-03-05 07:12:23 +00:00

what does it do?

what does it do?
elegaanz (Zmigrowane z github.com) zrecenzowano 2019-03-05 08:19:59 +00:00
elegaanz (Zmigrowane z github.com) skomentował(-a) 2019-03-05 08:19:59 +00:00

For all the fields that were not provided, it takes their value from the given struct (here NewBlog::default()).

For all the fields that were not provided, it takes their value from the given struct (here `NewBlog::default()`).
Zaloguj się, aby dołączyć do tej rozmowy.
Brak recenzentów
Brak kamienia milowego
Brak projektu
Brak przypisanych
Uczestnicy 2
Powiadomienia
Termin realizacji
Data realizacji jest niewłaściwa lub spoza zakresu. Użyj formatu 'yyyy-mm-dd'.

Brak ustawionego terminu realizacji.

Zależności

Brak ustawionych zależności.

Odniesienie: Plume/Plume#455
Opis zgłoszenia jest pusty.