Fix follow IDs #455
Brak recenzentów
Etykiety
Brak etykiet
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Brak kamienia milowego
Brak projektu
Brak przypisanych
Uczestnicy 2
Powiadomienia
Termin realizacji
Brak ustawionego terminu realizacji.
Zależności
Brak ustawionych zależności.
Odniesienie: Plume/Plume#455
Ładowanie…
Dodaj tabelę
Odniesienie w nowym zgłoszeniu
Opis zgłoszenia jest pusty.
Usuń gałąź "fix-follow-id"
Usunięcie gałęzi jest permanentne. Mimo, że usunięta gałąź może istnieć przez krótki czas zanim zostanie rzeczywiście usunięta, ta operacja NIE MOŻE zostać cofnięta w większości przypadków. Kontynuować?
I changed the syntax of the
insert!
macro, allowing to modify an object just after it was saved to the database. You can now optional pass it a "closure" (actually it just looks like a closure) that will be run just after the insertion.I updated all the models, including Follow, to use it to generate AP ID and URL. The advantages are that the ID/URL are now correct (fixes #449) and that we don't have methods like
update_boxes
orupdate_ap_url
to call manually and that were easy to forget.@ -228,4 +228,3 @@
post.cover_id = form.cover;
post.update(&*conn, &searcher).expect("post::update: update error");;
let post = post.update_ap_url(&*conn).expect("post::update: update ap url error");
Just a note: I removed that without replacing it with something else, since it is incorrect (the AP IDs should change), and was not working anyway (since we were checking if
ap_url
was empty before updating it, which was only the case on newly created articles).Codecov Report
LGTM
I've never used this syntax, but it looks super nice
this route should really get implemented one day
Yes, I think we already have an issue for it…
what does it do?
For all the fields that were not provided, it takes their value from the given struct (here
NewBlog::default()
).