8
16
Derivar 22

Fix follow IDs #455

Integrado
elegaanz integrou 4 cometimento(s) do ramo fix-follow-id no ramo master há 5 anos
elegaanz comentou há 5 anos (Migrado de github.com)

I changed the syntax of the insert! macro, allowing to modify an object just after it was saved to the database. You can now optional pass it a "closure" (actually it just looks like a closure) that will be run just after the insertion.

I updated all the models, including Follow, to use it to generate AP ID and URL. The advantages are that the ID/URL are now correct (fixes #449) and that we don't have methods like update_boxes or update_ap_url to call manually and that were easy to forget.

I changed the syntax of the `insert!` macro, allowing to modify an object just after it was saved to the database. You can now optional pass it a "closure" (actually it just looks like a closure) that will be run just after the insertion. I updated all the models, including Follow, to use it to generate AP ID and URL. The advantages are that the ID/URL are now correct (fixes #449) and that we don't have methods like `update_boxes` or `update_ap_url` to call manually and that were easy to forget.
elegaanz (Migrado de github.com) reviu há 5 anos
@ -228,4 +228,3 @@
post.cover_id = form.cover;
post.update(&*conn, &searcher).expect("post::update: update error");;
let post = post.update_ap_url(&*conn).expect("post::update: update ap url error");
elegaanz (Migrado de github.com) comentou há 5 anos

Just a note: I removed that without replacing it with something else, since it is incorrect (the AP IDs should change), and was not working anyway (since we were checking if ap_url was empty before updating it, which was only the case on newly created articles).

Just a note: I removed that without replacing it with something else, since it is incorrect (the AP IDs should change), and was not working anyway (since we were checking if `ap_url` was empty before updating it, which was only the case on newly created articles).
codecov[bot] comentou há 5 anos (Migrado de github.com)

Codecov Report

Merging #455 into master will increase coverage by 1.41%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
+ Coverage   25.06%   26.48%   +1.41%     
==========================================
  Files          64       64              
  Lines        6316     7111     +795     
==========================================
+ Hits         1583     1883     +300     
- Misses       4733     5228     +495
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/455?src=pr&el=h1) Report > Merging [#455](https://codecov.io/gh/Plume-org/Plume/pull/455?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a2b9d7ec44daf91d5b0dde00715d7185b5342c94?src=pr&el=desc) will **increase** coverage by `1.41%`. > The diff coverage is `79.31%`. ```diff @@ Coverage Diff @@ ## master #455 +/- ## ========================================== + Coverage 25.06% 26.48% +1.41% ========================================== Files 64 64 Lines 6316 7111 +795 ========================================== + Hits 1583 1883 +300 - Misses 4733 5228 +495 ```
trinity-1686a aprovou estas modificações há 5 anos
trinity-1686a deixou um comentário
Proprietário(a)

LGTM

LGTM
Proprietário(a)

I've never used this syntax, but it looks super nice

I've never used this syntax, but it looks super nice
Proprietário(a)

this route should really get implemented one day

this route should really get implemented one day
elegaanz (Migrado de github.com) reviu há 5 anos
elegaanz (Migrado de github.com) comentou há 5 anos

Yes, I think we already have an issue for it…

Yes, I think we already have an issue for it…
igalic (Migrado de github.com) reviu há 5 anos
igalic (Migrado de github.com) comentou há 5 anos

what does it do?

what does it do?
elegaanz (Migrado de github.com) reviu há 5 anos
elegaanz (Migrado de github.com) comentou há 5 anos

For all the fields that were not provided, it takes their value from the given struct (here NewBlog::default()).

For all the fields that were not provided, it takes their value from the given struct (here `NewBlog::default()`).

Revisores

trinity-1686a aprovou estas modificações há 5 anos
A integração foi executada no cometimento 2a188abfa1.

Passo 1:

No seu repositório, crie um novo ramo e teste as modificações.
git checkout -b fix-follow-id master
git pull origin fix-follow-id

Passo 2:

Integre as modificações e envie para o Forgejo.
git checkout master
git merge --no-ff fix-follow-id
git push origin master
Inicie a sessão para participar neste diálogo.
Sem revisores
Sem etapa
Sem encarregados
2 Participantes
Notificações
Data de vencimento
A data de vencimento é inválida ou está fora do intervalo permitido. Por favor, use o formato 'aaaa-mm-dd'.

Sem data de vencimento definida.

Dependências

Não estão definidas dependências.

Referência: Plume/Plume#455
Carregando…
Ainda não há conteúdo.