Igor Galić
3996efd5d7
review: better explanation for disablewd lint
2019-03-19 13:51:27 +01:00
Igor Galić
f7e73f4ded
review: allow PlumeRocket's from_request() to work even when user is not logged in
...
thanks, @fdb-hiroshima
2019-03-18 14:51:12 +01:00
Igor Galić
d75408fb6d
review: worker & searcher are always Options
...
remove the extra wrap. Thanks @fdb-hiroshima
2019-03-18 14:51:11 +01:00
Igor Galić
013c0dc814
fix clippy issues after rebase
2019-03-18 14:51:10 +01:00
Igor Galić
80f6dc6dca
allow clippy::op_ref
...
in that one case where it makes zero sense (to me)
2019-03-18 14:51:09 +01:00
Igor Galić
37af7ac407
now that we are done, *deny* all warnings
...
This makes them into errors we have to deal with!
2019-03-18 14:51:09 +01:00
Igor Galić
6b816cf441
disable some lints that we do not care about
2019-03-18 14:51:08 +01:00
Igor Galić
90e7b99e9d
partially clippy::too_many_arguments main's submodules
...
not sure if this can be said to be an issue in ructe:
https://github.com/kaj/ructe/issues/44
We could rework our templates to only allow that clippy lint there.
2019-03-18 14:51:07 +01:00
Igor Galić
a016f171e8
use template parameters by-value
2019-03-18 14:51:06 +01:00
Igor Galić
f396e68d13
pass occur by value
2019-03-18 14:51:05 +01:00
Igor Galić
a6eda407b8
fix .travis.yml so that we do not fall-thru and only build the CLI
...
also add whitespace so it's a tad more readable.
2019-03-18 14:51:05 +01:00
Igor Galić
c7e72a6be0
use PlumeRocket type to compact our routes
...
and use the occasional early return where sensible.
2019-03-18 14:51:04 +01:00
Igor Galić
92036d1047
simplify (remove;) timelines & use early return
2019-03-18 14:51:03 +01:00
Igor Galić
231e2b4d69
Extract parameters to rocket routes into a common type
...
we move the most common (5) parameters into a new type, `impl`
FromRequest for it, and start using it to reduce the amount of
parameters in our route functions.
Unusual for this patch: I use an early return, to move the main logic
out of giant indented `else` into the body of the function.
n.b.: even tho clippy did *not* complain about this particular route
function, we still use PlumeRockets for consistency.
2019-03-18 14:51:02 +01:00
Igor Galić
c54a2b6025
remove unnecessary closure around Outcome::Success
2019-03-18 14:51:02 +01:00
Igor Galić
2364c2464e
use the more contained type rocket::data::Outcome
...
it already contains Data, so our return type gets a bit simpler.
2019-03-18 14:51:01 +01:00
Igor Galić
bf55740f51
clippy, simplify routes#limits
2019-03-18 14:51:00 +01:00
Igor Galić
4e5b9b5d9a
implement FromStr for PlumeQuery
...
…to replace from_str()
and fix tests.
2019-03-18 14:50:59 +01:00
Igor Galić
590136488f
refactor plume-front#menu the same way we refactored search
2019-03-18 14:50:58 +01:00
Igor Galić
2852bf08a7
Clippy: follow advise and fix the "easy" things
2019-03-18 14:50:58 +01:00
Igor Galić
fc99767737
build with clippy - also, build the CLI
...
clippy is only issuing warnings, until we know what we're doing
2019-03-18 14:50:57 +01:00
