Plume/Plume
9
18
Fork 24
Code Issues 177 Pull-Requests 8 Releases 8 Wiki Aktivität

Caching #480

Zusammengeführt
Plume_migration_agent hat 3 Commits von cache nach master 2019-03-16 14:33:28 +00:00 zusammengeführt
Diskussion 1 Commits 3 Geänderte Dateien 6 +104 -17
trinity-1686a hat 2019-03-15 20:18:50 +00:00 kommentiert
Besitzer
Link kopieren

Try to cache static resources.
Static non media file's timestamps are hashed at compile tome so that modifying them invalidate old cache.
For some reason, plume-front.wasm isn't loaded from cache, even if it contains the right headers.
I changed nothing and now it is? I guess I'm ok with it
I'll look into adding Etag support too
All response made from templates and not containing a form are now Etag-cached

Try to cache static resources. Static non media file's timestamps are hashed at compile tome so that modifying them invalidate old cache. ~~For some reason, plume-front.wasm isn't loaded from cache, even if it contains the right headers.~~ I changed nothing and now it is? I guess I'm ok with it ~~I'll look into adding Etag support too~~ All response made from templates and not containing a form are now Etag-cached
👍 1 ❤️ 1
igalic (Migriert von github.com) hat 2019-03-15 21:37:29 +00:00 gereviewt
igalic (Migriert von github.com) hat einen Kommentar hinterlassen
Link kopieren

👀

👀
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (Migriert von github.com) hat 2019-03-15 21:28:40 +00:00 kommentiert
Link kopieren

i'd rather this wasn't random, but deterministic

such as the file's she256sum

i'd rather this wasn't random, but deterministic such as the file's she256sum
trinity-1686a hat 2019-03-15 22:46:35 +00:00 gereviewt
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
trinity-1686a hat 2019-03-15 22:46:35 +00:00 kommentiert
Autor
Besitzer
Link kopieren

What is your issue with it being random? It's fixed at compile time, so assuming a production server, which may restart but won't recompile often, the cache will be ok. My first through was using git commit sha, but this may be unnecessary information disclosure

What is your issue with it being random? It's fixed at compile time, so assuming a production server, which may restart but won't recompile often, the cache will be ok. My first through was using git commit sha, but this may be unnecessary information disclosure
igalic (Migriert von github.com) hat 2019-03-16 05:39:10 +00:00 gereviewt
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (Migriert von github.com) hat 2019-03-16 05:39:09 +00:00 kommentiert
Link kopieren

if nothing about the code changes, the cache_id shouldn't change either

if nothing about the code changes, the cache_id shouldn't change either
codecov[bot] hat 2019-03-16 08:45:11 +00:00 kommentiert (Migriert von github.com)
Link kopieren

Codecov Report

Merging #480 into master will decrease coverage by 0.31%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   27.13%   26.82%   -0.32%     
==========================================
  Files          64       64              
  Lines        7337     7423      +86     
==========================================
  Hits         1991     1991              
- Misses       5346     5432      +86
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/480?src=pr&el=h1) Report > Merging [#480](https://codecov.io/gh/Plume-org/Plume/pull/480?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/90baf9beb1884a886d4f2bf9df96f761c582d765?src=pr&el=desc) will **decrease** coverage by `0.31%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #480 +/- ## ========================================== - Coverage 27.13% 26.82% -0.32% ========================================== Files 64 64 Lines 7337 7423 +86 ========================================== Hits 1991 1991 - Misses 5346 5432 +86 ```
elegaanz (Migriert von github.com) hat 2019-03-16 08:48:43 +00:00 gereviewt
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
elegaanz (Migriert von github.com) hat 2019-03-16 08:48:43 +00:00 kommentiert
Link kopieren

The build won't be run again if the code didn't changed, so the ID will not change.

The build won't be run again if the code didn't changed, so the ID will not change.
elegaanz (Migriert von github.com) hat 2019-03-16 10:08:34 +00:00 gereviewt
build.rs
elegaanz (Migriert von github.com) hat 2019-03-16 10:08:34 +00:00 kommentiert
Link kopieren

You should probably remove it from Cargo.toml too.

You should probably remove it from `Cargo.toml` too.
trinity-1686a hat 2019-03-16 10:09:19 +00:00 gereviewt
build.rs
trinity-1686a hat 2019-03-16 10:09:19 +00:00 kommentiert
Autor
Besitzer
Link kopieren

I totally forgot about that

I totally forgot about that
igalic (Migriert von github.com) hat 2019-03-16 10:19:00 +00:00 gereviewt
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (Migriert von github.com) hat 2019-03-16 10:18:59 +00:00 kommentiert
Link kopieren

yes, in our development environment that is true, but not for anyone building packages or container images of our software. they always start from a clean slate

yes, in our development environment that is true, but not for anyone building packages or container images of our software. they always start from a clean slate
igalic (Migriert von github.com) hat 2019-03-16 11:24:59 +00:00 gereviewt
igalic (Migriert von github.com) hat einen Kommentar hinterlassen
Link kopieren

👍

👍
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (Migriert von github.com) hat 2019-03-16 11:24:09 +00:00 kommentiert
Link kopieren

btw, is there no way to do this in rust?

btw, is there no way to do this in rust?
trinity-1686a hat 2019-03-16 12:08:29 +00:00 gereviewt
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
trinity-1686a hat 2019-03-16 12:08:29 +00:00 kommentiert
Autor
Besitzer
Link kopieren

I think there are plenty, but I'm lazy and it's a build script. I prototyped using bash, so my rust code is basically bash translated (if you find it really bad, I can change that but I don't know if it's really useful)

I think there are plenty, but I'm lazy and it's a build script. I prototyped using bash, so my rust code is basically bash translated (if you find it really bad, I can change that but I don't know if it's really useful)
igalic (Migriert von github.com) hat 2019-03-16 12:13:25 +00:00 gereviewt
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (Migriert von github.com) hat 2019-03-16 12:13:25 +00:00 kommentiert
Link kopieren

nah, i was just curious

nah, i was just curious
elegaanz (Migriert von github.com) hat 2019-03-16 12:30:53 +00:00 gereviewt
src/template_utils.rs
@ -11,0 +37,4 @@
.merge(HtmlCt(self.0).respond_to(r)?)
.header(ETag(EntityTag::strong(etag)))
.ok()
}
elegaanz (Migriert von github.com) hat 2019-03-16 12:30:52 +00:00 kommentiert
Link kopieren

Probably obvious, but why do we disable caching on pages with a form?

Probably obvious, but why do we disable caching on pages with a form?
trinity-1686a hat 2019-03-16 12:37:12 +00:00 gereviewt
src/template_utils.rs
@ -11,0 +37,4 @@
.merge(HtmlCt(self.0).respond_to(r)?)
.header(ETag(EntityTag::strong(etag)))
.ok()
}
trinity-1686a hat 2019-03-16 12:37:12 +00:00 kommentiert
Autor
Besitzer
Link kopieren

If the page contain a form, the csrf token will be cached, and may no longer match user's cookies. As these tokens are added later by a fairing, there is no way to detect the page changed here. The other solution could be to allow caching of page and for rocket_csrf to remove ETag when appropriate

If the page contain a form, the csrf token will be cached, and may no longer match user's cookies. As these tokens are added later by a fairing, there is no way to detect the page changed here. The other solution could be to allow caching of page and for rocket_csrf to remove ETag when appropriate
elegaanz (Migriert von github.com) hat die Änderungen 2019-03-16 14:09:12 +00:00 genehmigt
elegaanz (Migriert von github.com) hat einen Kommentar hinterlassen
Link kopieren

👍 Thanks!

:+1: Thanks!
Anmelden, um an der Diskussion teilzunehmen.
Reviewer
Keine Reviewer
elegaanz
Labels
Labels entfernen   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Keine Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Meilenstein
Meilenstein entfernen
Keine Einträge
Kein Meilenstein
Projekte
Projekte löschen
Keine Einträge
Kein Projekt
Zuständige
Zuständige entfernen
Niemand zuständig
2 Beteiligte
Nachrichten
Fällig am
Das Fälligkeitsdatum ist ungültig oder außerhalb des zulässigen Bereichs. Bitte verwende das Format „jjjj-mm-tt“.

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Keine Abhängigkeiten gesetzt.

Referenz: Plume/Plume#480
Keine Beschreibung angegeben.
Branch „cache“ löschen

Das Löschen eines Branches ist permanent. Obwohl der Branch für eine kurze Zeit weiter existieren könnte, kann diese Aktion in den meisten Fällen NICHT rückgängig gemacht werden. Fortfahren?