Plume/Plume
9
18
Çatalla 24
Kod Konular 177 Değişiklik İstekleri 8 Sürüm 8 Wiki Aktivite

Caching #480

Birleştirildi
Plume_migration_agent 2019-03-16 14:33:28 +00:00 cache içindeki 3 işlemeyi master ile birleştirdi
Sohbet 1 İşleme 3 Değiştirilen Dosyalar 6 +104 -17
trinity-1686a 2019-03-15 20:18:50 +00:00 yorum yaptı
Sahibi
Bağlantıyı Kopyala

Try to cache static resources.
Static non media file's timestamps are hashed at compile tome so that modifying them invalidate old cache.
For some reason, plume-front.wasm isn't loaded from cache, even if it contains the right headers.
I changed nothing and now it is? I guess I'm ok with it
I'll look into adding Etag support too
All response made from templates and not containing a form are now Etag-cached

Try to cache static resources. Static non media file's timestamps are hashed at compile tome so that modifying them invalidate old cache. ~~For some reason, plume-front.wasm isn't loaded from cache, even if it contains the right headers.~~ I changed nothing and now it is? I guess I'm ok with it ~~I'll look into adding Etag support too~~ All response made from templates and not containing a form are now Etag-cached
👍 1 ❤️ 1
igalic (github.com konumundan göç edildi) 2019-03-15 21:37:29 +00:00 incelendi
igalic (github.com konumundan göç edildi) bir yorum yaptı
Bağlantıyı Kopyala

👀

👀
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (github.com konumundan göç edildi) 2019-03-15 21:28:40 +00:00 yorum yaptı
Bağlantıyı Kopyala

i'd rather this wasn't random, but deterministic

such as the file's she256sum

i'd rather this wasn't random, but deterministic such as the file's she256sum
trinity-1686a 2019-03-15 22:46:35 +00:00 incelendi
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
trinity-1686a 2019-03-15 22:46:35 +00:00 yorum yaptı
Yazar
Sahibi
Bağlantıyı Kopyala

What is your issue with it being random? It's fixed at compile time, so assuming a production server, which may restart but won't recompile often, the cache will be ok. My first through was using git commit sha, but this may be unnecessary information disclosure

What is your issue with it being random? It's fixed at compile time, so assuming a production server, which may restart but won't recompile often, the cache will be ok. My first through was using git commit sha, but this may be unnecessary information disclosure
igalic (github.com konumundan göç edildi) 2019-03-16 05:39:10 +00:00 incelendi
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (github.com konumundan göç edildi) 2019-03-16 05:39:09 +00:00 yorum yaptı
Bağlantıyı Kopyala

if nothing about the code changes, the cache_id shouldn't change either

if nothing about the code changes, the cache_id shouldn't change either
codecov[bot] 2019-03-16 08:45:11 +00:00 yorum yaptı (github.com konumundan göç edildi)
Bağlantıyı Kopyala

Codecov Report

Merging #480 into master will decrease coverage by 0.31%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   27.13%   26.82%   -0.32%     
==========================================
  Files          64       64              
  Lines        7337     7423      +86     
==========================================
  Hits         1991     1991              
- Misses       5346     5432      +86
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/480?src=pr&el=h1) Report > Merging [#480](https://codecov.io/gh/Plume-org/Plume/pull/480?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/90baf9beb1884a886d4f2bf9df96f761c582d765?src=pr&el=desc) will **decrease** coverage by `0.31%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #480 +/- ## ========================================== - Coverage 27.13% 26.82% -0.32% ========================================== Files 64 64 Lines 7337 7423 +86 ========================================== Hits 1991 1991 - Misses 5346 5432 +86 ```
elegaanz (github.com konumundan göç edildi) 2019-03-16 08:48:43 +00:00 incelendi
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
elegaanz (github.com konumundan göç edildi) 2019-03-16 08:48:43 +00:00 yorum yaptı
Bağlantıyı Kopyala

The build won't be run again if the code didn't changed, so the ID will not change.

The build won't be run again if the code didn't changed, so the ID will not change.
elegaanz (github.com konumundan göç edildi) 2019-03-16 10:08:34 +00:00 incelendi
build.rs
elegaanz (github.com konumundan göç edildi) 2019-03-16 10:08:34 +00:00 yorum yaptı
Bağlantıyı Kopyala

You should probably remove it from Cargo.toml too.

You should probably remove it from `Cargo.toml` too.
trinity-1686a 2019-03-16 10:09:19 +00:00 incelendi
build.rs
trinity-1686a 2019-03-16 10:09:19 +00:00 yorum yaptı
Yazar
Sahibi
Bağlantıyı Kopyala

I totally forgot about that

I totally forgot about that
igalic (github.com konumundan göç edildi) 2019-03-16 10:19:00 +00:00 incelendi
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (github.com konumundan göç edildi) 2019-03-16 10:18:59 +00:00 yorum yaptı
Bağlantıyı Kopyala

yes, in our development environment that is true, but not for anyone building packages or container images of our software. they always start from a clean slate

yes, in our development environment that is true, but not for anyone building packages or container images of our software. they always start from a clean slate
igalic (github.com konumundan göç edildi) 2019-03-16 11:24:59 +00:00 incelendi
igalic (github.com konumundan göç edildi) bir yorum yaptı
Bağlantıyı Kopyala

👍

👍
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (github.com konumundan göç edildi) 2019-03-16 11:24:09 +00:00 yorum yaptı
Bağlantıyı Kopyala

btw, is there no way to do this in rust?

btw, is there no way to do this in rust?
trinity-1686a 2019-03-16 12:08:29 +00:00 incelendi
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
trinity-1686a 2019-03-16 12:08:29 +00:00 yorum yaptı
Yazar
Sahibi
Bağlantıyı Kopyala

I think there are plenty, but I'm lazy and it's a build script. I prototyped using bash, so my rust code is basically bash translated (if you find it really bad, I can change that but I don't know if it's really useful)

I think there are plenty, but I'm lazy and it's a build script. I prototyped using bash, so my rust code is basically bash translated (if you find it really bad, I can change that but I don't know if it's really useful)
igalic (github.com konumundan göç edildi) 2019-03-16 12:13:25 +00:00 incelendi
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (github.com konumundan göç edildi) 2019-03-16 12:13:25 +00:00 yorum yaptı
Bağlantıyı Kopyala

nah, i was just curious

nah, i was just curious
elegaanz (github.com konumundan göç edildi) 2019-03-16 12:30:53 +00:00 incelendi
src/template_utils.rs
@ -11,0 +37,4 @@
.merge(HtmlCt(self.0).respond_to(r)?)
.header(ETag(EntityTag::strong(etag)))
.ok()
}
elegaanz (github.com konumundan göç edildi) 2019-03-16 12:30:52 +00:00 yorum yaptı
Bağlantıyı Kopyala

Probably obvious, but why do we disable caching on pages with a form?

Probably obvious, but why do we disable caching on pages with a form?
trinity-1686a 2019-03-16 12:37:12 +00:00 incelendi
src/template_utils.rs
@ -11,0 +37,4 @@
.merge(HtmlCt(self.0).respond_to(r)?)
.header(ETag(EntityTag::strong(etag)))
.ok()
}
trinity-1686a 2019-03-16 12:37:12 +00:00 yorum yaptı
Yazar
Sahibi
Bağlantıyı Kopyala

If the page contain a form, the csrf token will be cached, and may no longer match user's cookies. As these tokens are added later by a fairing, there is no way to detect the page changed here. The other solution could be to allow caching of page and for rocket_csrf to remove ETag when appropriate

If the page contain a form, the csrf token will be cached, and may no longer match user's cookies. As these tokens are added later by a fairing, there is no way to detect the page changed here. The other solution could be to allow caching of page and for rocket_csrf to remove ETag when appropriate
elegaanz (github.com konumundan göç edildi) 2019-03-16 14:09:12 +00:00 bu değişiklikleri onayladı
elegaanz (github.com konumundan göç edildi) bir yorum yaptı
Bağlantıyı Kopyala

👍 Thanks!

:+1: Thanks!
Bu konuşmaya katılmak için oturum aç.
Gözden Geçirenler
Değerlendirici yok
elegaanz
Etiketler
Etiketleri temizle   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Etiket Yok
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Kilometre Taşı
Kilometre Taşlarını Temizle
Öge yok
Kilometre Taşı Yok
Projeler
Projeleri temizle
Öge yok
Proje yok
Atananlar
Atamaları Temizle
Atanan Kişi Yok
2 Katılımcı
Bildirimler
Bitiş Tarihi
Bitiş tarihi geçersiz veya aralık dışında. Lütfen 'yyyy-aa-gg' biçimini kullanın.

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Referans: Plume/Plume#480
Herhangi bir açıklama sağlanmadı.
"cache" Dalını Sil

Bir dalı silmek kalıcıdır. Her ne kadar silinen dal tamamen kaldırılana kadar çok kısa bir süre yaşamını sürdürse de, çoğu durumda bu işlem GERİ ALINAMAZ. Devam edilsin mi?