Editor improvements #486

Unito

elegaanz ha unito 14 commit da editor-improvements a master

elegaanz ha commentato (Migrato da github.com)

Make it possible to insert new paragraphs in the article body
Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly)

TODO:

make it possible to escape draft mode
display errors from the server
button to go back to the "normal" editor
Avoid publishing placeholders

- Make it possible to insert new paragraphs in the article body - Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly) TODO: - [x] make it possible to escape draft mode - [x] display errors from the server - [x] button to go back to the "normal" editor - [x] Avoid publishing placeholders

🎉 1

trinity-1686a ha commentato

Proprietario

If I may add to the todo list: https://github.com/Plume-org/Plume/pull/458#issuecomment-473323102

codecov[bot] ha commentato (Migrato da github.com)

Codecov Report

Merging #486 into master will decrease coverage by 2.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   26.83%   24.56%   -2.27%     
==========================================
  Files          65       65              
  Lines        9000     7116    -1884     
==========================================
- Hits         2415     1748     -667     
+ Misses       6585     5368    -1217

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/486?src=pr&el=h1) Report > Merging [#486](https://codecov.io/gh/Plume-org/Plume/pull/486?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c7ee779f51729326567a4c4bdeb416d8882f4b0a?src=pr&el=desc) will **decrease** coverage by `2.26%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #486 +/- ## ========================================== - Coverage 26.83% 24.56% -2.27% ========================================== Files 65 65 Lines 9000 7116 -1884 ========================================== - Hits 2415 1748 -667 + Misses 6585 5368 -1217 ```

elegaanz ha commentato (Migrato da github.com)

@fdb-hiroshima Yes, the first one is already fixed, I'll see for the other. :)

trinity-1686a revisionato

plume-front/src/editor.rs

trinity-1686a ha commentato

Proprietario

I think basic-editor should be permanent, and there would then be a button to re-enable the "advanced" editor

elegaanz (Migrato da github.com) revisionato

plume-front/src/editor.rs

elegaanz (Migrato da github.com) ha commentato

I don't really know how to name it…

trinity-1686a revisionato

plume-front/src/editor.rs

trinity-1686a ha commentato

Proprietario

rich text editor?

trinity-1686a revisionato

trinity-1686a lascia un commento

Proprietario

It's a bit sad markdown does not work with the rich editor (cmark see some div so it assumes it's only html and does not attempt to parse markdown)

elegaanz ha commentato (Migrato da github.com)

@fdb-hiroshima This should definitely be fixed before merging this branch I think. I will see what I can do.

trinity-1686a ha commentato

Proprietario

The only fix I see is, given the following :

<div>some text</div><div>![desc](path/to/picture.png)</div>

Where we are given a single Html("<div>some text</div><div>![desc](path/to/picture.png)</div>"), we could cut it out as ["some text", "![desc](path/to/picture.png)"], call cmark on each of these, and put back the divs

The only fix I see is, given the following : ```html <div>some text</div><div>![desc](path/to/picture.png)</div> ``` Where we are given a single `Html("<div>some text</div><div>![desc](path/to/picture.png)</div>")`, we could cut it out as `["some text", "![desc](path/to/picture.png)"]`, call cmark on each of these, and put back the `div`s

👍 1

elegaanz ha commentato (Migrato da github.com)

I was more thinking of pre-processing the HTML with the DOM APIs in WASM, because your solution may break footnotes, or links that use this syntax:

my [link]

[link]: https://example.org

I was more thinking of pre-processing the HTML with the DOM APIs in WASM, because your solution may break footnotes, or links that use this syntax: ``` my [link] [link]: https://example.org ```

👍 1

igalic (Migrato da github.com) revisionato

igalic (Migrato da github.com) lascia un commento

please remove the callgrind output files from the PR

trinity-1686a hanno approvato queste modifiche

Revisori

trinity-1686a hanno approvato queste modifiche

La pull request è stata unita come 1f7ff62c19.

Puoi anche visualizzare le istruzioni da riga di comando.

Passo 1:

Dal repository del tuo progetto, fai il check out di un nuovo branch e verifica le modifiche.

git checkout -b editor-improvements master

git pull origin editor-improvements

Passo 2:

Fai il merge delle modifiche e aggiorna su Forgejo.

git checkout master

git merge --no-ff editor-improvements

git push origin master

Effettua l'accesso per partecipare alla conversazione.

Nessun revisore

Nessuna milestone

Nessuna assegnatario

2 Partecipanti

Notifiche

Data di scadenza

La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Caricamento…

Non ci sono ancora contenuti.

Etichette Traguardi

Editor improvements #486

Codecov Report

Revisori

Passo 1:

Passo 2: