Editor improvements #486

Sapludināts

elegaanz sapludināja 14 revīzijas no editor-improvements uz master

elegaanz " komentēja " (Migrēts no github.com)

Make it possible to insert new paragraphs in the article body
Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly)

TODO:

make it possible to escape draft mode
display errors from the server
button to go back to the "normal" editor
Avoid publishing placeholders

- Make it possible to insert new paragraphs in the article body - Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly) TODO: - [x] make it possible to escape draft mode - [x] display errors from the server - [x] button to go back to the "normal" editor - [x] Avoid publishing placeholders

🎉 1

trinity-1686a " komentēja "

Īpašnieks

If I may add to the todo list: https://github.com/Plume-org/Plume/pull/458#issuecomment-473323102

codecov[bot] " komentēja " (Migrēts no github.com)

Codecov Report

Merging #486 into master will decrease coverage by 2.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   26.83%   24.56%   -2.27%     
==========================================
  Files          65       65              
  Lines        9000     7116    -1884     
==========================================
- Hits         2415     1748     -667     
+ Misses       6585     5368    -1217

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/486?src=pr&el=h1) Report > Merging [#486](https://codecov.io/gh/Plume-org/Plume/pull/486?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c7ee779f51729326567a4c4bdeb416d8882f4b0a?src=pr&el=desc) will **decrease** coverage by `2.26%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #486 +/- ## ========================================== - Coverage 26.83% 24.56% -2.27% ========================================== Files 65 65 Lines 9000 7116 -1884 ========================================== - Hits 2415 1748 -667 + Misses 6585 5368 -1217 ```

elegaanz " komentēja " (Migrēts no github.com)

@fdb-hiroshima Yes, the first one is already fixed, I'll see for the other. :)

trinity-1686a recenzēja

plume-front/src/editor.rs

trinity-1686a " komentēja "

Īpašnieks

I think basic-editor should be permanent, and there would then be a button to re-enable the "advanced" editor

elegaanz (Migrēts no github.com) recenzēja

plume-front/src/editor.rs

elegaanz (Migrēts no github.com) " komentēja "

I don't really know how to name it…

trinity-1686a recenzēja

plume-front/src/editor.rs

trinity-1686a " komentēja "

Īpašnieks

rich text editor?

trinity-1686a recenzēja

trinity-1686a atstāja komentāru

Īpašnieks

It's a bit sad markdown does not work with the rich editor (cmark see some div so it assumes it's only html and does not attempt to parse markdown)

elegaanz " komentēja " (Migrēts no github.com)

@fdb-hiroshima This should definitely be fixed before merging this branch I think. I will see what I can do.

trinity-1686a " komentēja "

Īpašnieks

The only fix I see is, given the following :

<div>some text</div><div>![desc](path/to/picture.png)</div>

Where we are given a single Html("<div>some text</div><div>![desc](path/to/picture.png)</div>"), we could cut it out as ["some text", "![desc](path/to/picture.png)"], call cmark on each of these, and put back the divs

The only fix I see is, given the following : ```html <div>some text</div><div>![desc](path/to/picture.png)</div> ``` Where we are given a single `Html("<div>some text</div><div>![desc](path/to/picture.png)</div>")`, we could cut it out as `["some text", "![desc](path/to/picture.png)"]`, call cmark on each of these, and put back the `div`s

👍 1

elegaanz " komentēja " (Migrēts no github.com)

I was more thinking of pre-processing the HTML with the DOM APIs in WASM, because your solution may break footnotes, or links that use this syntax:

my [link]

[link]: https://example.org

I was more thinking of pre-processing the HTML with the DOM APIs in WASM, because your solution may break footnotes, or links that use this syntax: ``` my [link] [link]: https://example.org ```

👍 1

igalic (Migrēts no github.com) recenzēja

igalic (Migrēts no github.com) atstāja komentāru

please remove the callgrind output files from the PR

trinity-1686a apstiprināja izmaiņas

Recenzenti

trinity-1686a apstiprināja izmaiņas

Izmaiņu pieprasījums tika sapludināts ar revīziju 1f7ff62c19.

Varat aplūkot arī komandrindas instrukcijas.

Solis 1:

Projekta repozitorijā izveidojiet jaunu jaunu atzaru un pārbaudiet savas izmaiņas.

git checkout -b editor-improvements master

git pull origin editor-improvements

Solis 2:

Sapludināt izmaiņas un atjaunot tās Forgejo.

git checkout master

git merge --no-ff editor-improvements

git push origin master

Pierakstieties, lai pievienotos šai sarunai.

Nav recenzentu

Nav atskaites punktu

Nav atbildīgo

2 dalībnieki

Paziņojumi

Izpildes termiņš

Datums līdz nav korekts. Izmantojiet formātu 'gggg-mm-dd'.

Izpildes termiņš nav uzstādīts.

Atkarības

Nav atkarību.

Notiek ielāde…

Vēl nav satura.

Etiķetes Atskaites punkti

Editor improvements #486

Codecov Report

Recenzenti

Solis 1:

Solis 2: