Run 'cargo fmt' to format code #489

マージ済み
Atul9 が 1 個のコミットを format-using-cargo-fmt から master へマージ 5年前
Atul9 がコメント 5年前 (github.comから移行)
まだ内容がありません
codecov[bot] がコメント 5年前 (github.comから移行)

Codecov Report

Merging #489 into master will decrease coverage by 0.62%.
The diff coverage is 24.39%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage    27.3%   26.67%   -0.63%     
==========================================
  Files          64       64              
  Lines        7582     8713    +1131     
==========================================
+ Hits         2070     2324     +254     
- Misses       5512     6389     +877
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/489?src=pr&el=h1) Report > Merging [#489](https://codecov.io/gh/Plume-org/Plume/pull/489?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/732f514da7aa5090f5277d44fbd8feedc4c54e79?src=pr&el=desc) will **decrease** coverage by `0.62%`. > The diff coverage is `24.39%`. ```diff @@ Coverage Diff @@ ## master #489 +/- ## ========================================== - Coverage 27.3% 26.67% -0.63% ========================================== Files 64 64 Lines 7582 8713 +1131 ========================================== + Hits 2070 2324 +254 - Misses 5512 6389 +877 ```
elegaanz (github.comから移行) がレビュー 5年前
elegaanz (github.comから移行) がコメント

Hey, thank you! Would you want to try to add it to the CI too? (it's fine if you don't, we can totally do that in another PR)

Hey, thank you! Would you want to try to add it to the CI too? (it's fine if you don't, we can totally do that in another PR)
Atul9 がコメント 5年前 (github.comから移行)

Hi @BaptisteGelez I would like to add it. I am new to Plume project. Can you please point me to where in the .travis.yml file can cargo fmt be added?

Hi @BaptisteGelez I would like to add it. I am new to Plume project. Can you please point me to where in the .travis.yml file can `cargo fmt` be added?
elegaanz がコメント 5年前 (github.comから移行)

You can probably add a new item at the end of the jobs section, in the "test and coverage" stage (I'm not sure if this indication is clear enough, tell me if it is not 😅)

You can probably add a new item at the end of the `jobs` section, in the "test and coverage" stage (I'm not sure if this indication is clear enough, tell me if it is not :sweat_smile:)
igalic がコメント 5年前 (github.comから移行)

given that the usual way to run rustfmt is in "check" mode, we can probably run it as first job. and from what i gather, rustfmt doesn't care about features, and just formats all code? or? did it format the test code, too?

given that the usual way to run `rustfmt` is in "check" mode, we can probably run it as first job. and from what i gather, `rustfmt` doesn't care about features, and just formats all code? or? did it format the test code, too?
Atul9 がコメント 5年前 (github.comから移行)

If the code isn't formatted ('rustfmt' will exit with 1 if there is an error in formatting - https://github.com/rust-lang/rustfmt#running) then is it still ok to go to the build stage?
Suggestion: We can add a check stage which will run before the build stage.
@BaptisteGelez @igalic What do you think?

If the code isn't formatted ('rustfmt' will exit with 1 if there is an error in formatting - https://github.com/rust-lang/rustfmt#running) then is it still ok to go to the build stage? Suggestion: We can add a `check` stage which will run before the build stage. @BaptisteGelez @igalic What do you think?
Atul9 がコメント 5年前 (github.comから移行)

@BaptisteGelez @igalic I tried adding cargo fmt but the CI fails for weird reason.

I tried locally but I didn't get this error - https://travis-ci.org/Plume-org/Plume/jobs/508992511#L584 & nor did it fail for the build before adding cargo fmt to travis.yml.

I tried to fix that but the build fails - https://travis-ci.org/Plume-org/Plume/jobs/509005663#L589

The build for this PR had passed before adding cargo fmt to travis build stages - https://travis-ci.org/Plume-org/Plume/builds/508519598

I suggest we can add cargo fmt to CI in another PR.

@BaptisteGelez @igalic I tried adding cargo fmt but the CI fails for weird reason. I tried locally but I didn't get this error - https://travis-ci.org/Plume-org/Plume/jobs/508992511#L584 & nor did it fail for the build before adding `cargo fmt` to travis.yml. I tried to fix that but the build fails - https://travis-ci.org/Plume-org/Plume/jobs/509005663#L589 The build for this PR had passed before adding `cargo fmt` to travis build stages - https://travis-ci.org/Plume-org/Plume/builds/508519598 I suggest we can add `cargo fmt` to CI in another PR.
elegaanz がコメント 5年前 (github.comから移行)

OK, no problem. I'll merge this as soon as you'll have reverted the changes to .travis.yml. And thank you again for your work. 🙂

OK, no problem. I'll merge this as soon as you'll have reverted the changes to `.travis.yml`. And thank you again for your work. :slightly_smiling_face:
Atul9 がコメント 5年前 (github.comから移行)

@BaptisteGelez done. I have updated the PR.

@BaptisteGelez done. I have updated the PR.
elegaanz (github.comから移行) が変更を承認 5年前

レビューア

プルリクエストは b945d1f602 でマージされています。
コマンドラインの手順も確認できます。

ステップ 1:

あなたのプロジェクトリポジトリで新しいブランチをチェックアウトし、変更内容をテストします。
git checkout -b format-using-cargo-fmt master
git pull origin format-using-cargo-fmt

ステップ 2:

変更内容をマージして、Forgejoに反映します。
git checkout master
git merge --no-ff format-using-cargo-fmt
git push origin master
サインインしてこの会話に参加。
レビューアなし
マイルストーンなし
担当者なし
1 人の参加者
通知
期日
期日が正しくないか範囲を超えています。 'yyyy-mm-dd' の形式で入力してください。

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: Plume/Plume#489
読み込み中…
まだ内容がありません