#503 Fix issue with sqlite migrations for comment_seers

Merged
vbrandl merged 1 commits from fix/sqlite-migrations into master 1 year ago
vbrandl commented 1 year ago (Migrated from github.com)

This fixes the issue in the sqlite migrations for comment_seers.

The temporary workaround was to change the id column from id INTEGER PRIMARY KEY AUTOINCREMENT to id INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT.

This change renames the table, creates a new table with the correct attributes, copies the old table over in the new one and deletes the old one.

This fixes the issue in the sqlite migrations for `comment_seers`. The temporary workaround was to change the `id` column from `id INTEGER PRIMARY KEY AUTOINCREMENT` to `id INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT`. This change renames the table, creates a new table with the correct attributes, copies the old table over in the new one and deletes the old one.
elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

Thank you. 👍

codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #503 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #503   +/-   ##
=======================================
  Coverage   26.89%   26.89%           
=======================================
  Files          65       65           
  Lines        8966     8966           
=======================================
  Hits         2411     2411           
  Misses       6555     6555
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/503?src=pr&el=h1) Report > Merging [#503](https://codecov.io/gh/Plume-org/Plume/pull/503?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/21cb0ef43786adee42065cecf053b8e525fe2c3f?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #503 +/- ## ======================================= Coverage 26.89% 26.89% ======================================= Files 65 65 Lines 8966 8966 ======================================= Hits 2411 2411 Misses 6555 6555 ```

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as f0d6b9d1e8.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.