Plume
/
Plume
8
16
포크 22
코드 이슈 174 풀 리퀘스트 8 릴리즈 8 위키 활동

레이블 마일스톤

Add tests for plume webserver #513

병합
Plume_migration_agent circleci 에서 master 로 9 commits 를 머지했습니다 5 년 전
대화 1 커밋 9 파일 변경됨 17
trinity-1686a 코멘트됨, 5 년 전
소유자

Tests are done using Firefox (I might try to use Chrome too), Selenium and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice).
Also add a feature test for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy's index on demand instead of every 30 minutes to make possible to test search page)

Tests are done using Firefox (I might try to use Chrome too), [Selenium](https://www.seleniumhq.org/projects/webdriver/) and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice). Also add a feature `test` for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy's index on demand instead of every 30 minutes to make possible to test search page)
👍 1 ❤️ 1 🎉 1
codecov[bot] 코멘트됨, 5 년 전 (Migrated from github.com)

Codecov Report

Merging #513 into master will increase coverage by 4.84%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   24.64%   29.49%   +4.84%     
==========================================
  Files          65       66       +1     
  Lines        7120     7114       -6     
==========================================
+ Hits         1755     2098     +343     
+ Misses       5365     5016     -349
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=h1) Report > Merging [#513](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/723d2c4600d2b8c9aabc9a26562553a02616f65d?src=pr&el=desc) will **increase** coverage by `4.84%`. > The diff coverage is `80%`. ```diff @@ Coverage Diff @@ ## master #513 +/- ## ========================================== + Coverage 24.64% 29.49% +4.84% ========================================== Files 65 66 +1 Lines 7120 7114 -6 ========================================== + Hits 1755 2098 +343 + Misses 5365 5016 -349 ```
elegaanz (Migrated from github.com) 검토됨 5 년 전
.circleci/config.yml
elegaanz (Migrated from github.com) 코멘트됨, 5 년 전

Isn't there one of the two lines above that should be removed?

Isn't there one of the two lines above that should be removed?
.circleci/images/plume-buildenv/Dockerfile
elegaanz (Migrated from github.com) 코멘트됨, 5 년 전

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.
trinity-1686a 검토됨 5 년 전
.circleci/config.yml
trinity-1686a 코멘트됨, 5 년 전
포스터
소유자

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us
trinity-1686a 검토됨 5 년 전
.circleci/images/plume-buildenv/Dockerfile
trinity-1686a 코멘트됨, 5 년 전
포스터
소유자

I think I'll change this to a copy statement, it will make more sense

I think I'll change this to a copy statement, it will make more sense
elegaanz (Migrated from github.com) 검토됨 5 년 전
elegaanz (Migrated from github.com) left a comment

Looks good, excepted from run_browser_test.sh that I don't understand. 😄

Looks good, excepted from `run_browser_test.sh` that I don't understand. :smile:
script/run_browser_test.sh
@ -0,0 +5,4 @@
mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
elegaanz (Migrated from github.com) 코멘트됨, 5 년 전

I'm not sure to understand what you are doing here… 🤔

I'm not sure to understand what you are doing here… :thinking:
trinity-1686a 검토됨 5 년 전
script/run_browser_test.sh
@ -0,0 +5,4 @@
mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
trinity-1686a 코멘트됨, 5 년 전
포스터
소유자

I'm creating a "shortcut" to plm run with kcov because I run it multiple time in the following lines, and it's rather long. So when I call $plm <something> after, it just mean "run plm <something> with coverage report"

I'm creating a "shortcut" to plm run with kcov because I run it multiple time in the following lines, and it's rather long. So when I call `$plm <something>` after, it just mean "run `plm <something>` with coverage report"
elegaanz (Migrated from github.com) 검토됨 5 년 전
script/run_browser_test.sh
@ -0,0 +5,4 @@
mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
elegaanz (Migrated from github.com) 코멘트됨, 5 년 전

Oh OK, I get it, it is to get coverage for plm too. Great!

Oh OK, I get it, it is to get coverage for plm too. Great!
elegaanz (Migrated from github.com) 이 변경사항을 승인하였습니다. 5 년 전
elegaanz (Migrated from github.com) left a comment

👍

:+1:
igalic (Migrated from github.com) 이 변경사항을 승인하였습니다. 5 년 전
igalic (Migrated from github.com) left a comment

👍

👍

리뷰어

elegaanz
igalic
The pull request has been merged as eabe73ddc0.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b circleci master
git pull origin circleci

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff circleci
git push origin master
로그인하여 이 대화에 참여
리뷰어
Request review
No reviewers
elegaanz
igalic
레이블
Apply labels
레이블 초기화   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
레이블 없음
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
마일스톤
Set milestone
마일스톤 초기화
No items
마일스톤 없음
담당자
Assign users
담당자 초기화
담당자 없음
참여자 2명
알림
마감일
기한이 올바르지 않거나 범위를 벗어났습니다. 'yyyy-mm-dd'형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: Plume/Plume#513
쓰기 미리보기
불러오는 중...
취소
저장
아직 콘텐츠가 없습니다.
'circleci' 브랜치 삭제

Deleting a branch is permanent. It CANNOT be undone. Continue?

아니오
예