Add tests for plume webserver #513

Merge aplicado
Plume_migration_agent aplicou merge dos 9 commits de circleci em master 5 anos atrás
Proprietário

Tests are done using Firefox (I might try to use Chrome too), Selenium and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice).
Also add a feature test for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy's index on demand instead of every 30 minutes to make possible to test search page)

Tests are done using Firefox (I might try to use Chrome too), [Selenium](https://www.seleniumhq.org/projects/webdriver/) and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice). Also add a feature `test` for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy's index on demand instead of every 30 minutes to make possible to test search page)
codecov[bot] comentou 5 anos atrás (Migrado de github.com)

Codecov Report

Merging #513 into master will increase coverage by 4.84%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   24.64%   29.49%   +4.84%     
==========================================
  Files          65       66       +1     
  Lines        7120     7114       -6     
==========================================
+ Hits         1755     2098     +343     
+ Misses       5365     5016     -349
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=h1) Report > Merging [#513](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/723d2c4600d2b8c9aabc9a26562553a02616f65d?src=pr&el=desc) will **increase** coverage by `4.84%`. > The diff coverage is `80%`. ```diff @@ Coverage Diff @@ ## master #513 +/- ## ========================================== + Coverage 24.64% 29.49% +4.84% ========================================== Files 65 66 +1 Lines 7120 7114 -6 ========================================== + Hits 1755 2098 +343 + Misses 5365 5016 -349 ```
elegaanz (Migrado de github.com) revisou 5 anos atrás
elegaanz (Migrado de github.com) comentou 5 anos atrás

Isn't there one of the two lines above that should be removed?

Isn't there one of the two lines above that should be removed?
elegaanz (Migrado de github.com) comentou 5 anos atrás

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.
trinity-1686a revisou 5 anos atrás
Autor
Proprietário

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us
trinity-1686a revisou 5 anos atrás
Autor
Proprietário

I think I'll change this to a copy statement, it will make more sense

I think I'll change this to a copy statement, it will make more sense
elegaanz (Migrado de github.com) revisou 5 anos atrás
elegaanz (Migrado de github.com) deixou um comentário

Looks good, excepted from run_browser_test.sh that I don't understand. 😄

Looks good, excepted from `run_browser_test.sh` that I don't understand. :smile:
@ -0,0 +5,4 @@
mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
elegaanz (Migrado de github.com) comentou 5 anos atrás

I'm not sure to understand what you are doing here… 🤔

I'm not sure to understand what you are doing here… :thinking:
trinity-1686a revisou 5 anos atrás
@ -0,0 +5,4 @@
mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
Autor
Proprietário

I'm creating a "shortcut" to plm run with kcov because I run it multiple time in the following lines, and it's rather long. So when I call $plm <something> after, it just mean "run plm <something> with coverage report"

I'm creating a "shortcut" to plm run with kcov because I run it multiple time in the following lines, and it's rather long. So when I call `$plm <something>` after, it just mean "run `plm <something>` with coverage report"
elegaanz (Migrado de github.com) revisou 5 anos atrás
@ -0,0 +5,4 @@
mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
elegaanz (Migrado de github.com) comentou 5 anos atrás

Oh OK, I get it, it is to get coverage for plm too. Great!

Oh OK, I get it, it is to get coverage for plm too. Great!
elegaanz (Migrado de github.com) aprovou estas alterações 5 anos atrás
elegaanz (Migrado de github.com) deixou um comentário

👍

:+1:
igalic (Migrado de github.com) aprovou estas alterações 5 anos atrás
igalic (Migrado de github.com) deixou um comentário

👍

👍
O pull request teve merge aplicado como eabe73ddc0.
Você também pode ver as instruções para a linha de comandos.

Passo 1:

No repositório do seu projeto, crie um novo branch e teste as alterações.
git checkout -b circleci master
git pull origin circleci

Passo 2:

Faça merge das alterações e atualize no Forgejo.
git checkout master
git merge --no-ff circleci
git push origin master
Acesse para participar desta conversação.
Sem marco
Sem responsável
2 participante(s)
Notificações
Data limite
A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: Plume/Plume#513
Carregando…
Ainda não há conteúdo.