Add tests for plume webserver #513

已合併
Plume_migration_agent 將 9 次提交從 circleci 合併至 master 5 年前
擁有者

Tests are done using Firefox (I might try to use Chrome too), Selenium and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice).
Also add a feature test for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy's index on demand instead of every 30 minutes to make possible to test search page)

Tests are done using Firefox (I might try to use Chrome too), [Selenium](https://www.seleniumhq.org/projects/webdriver/) and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice). Also add a feature `test` for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy's index on demand instead of every 30 minutes to make possible to test search page)
codecov[bot] 已留言 5 年前 (已從 github.com 遷移)

Codecov Report

Merging #513 into master will increase coverage by 4.84%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   24.64%   29.49%   +4.84%     
==========================================
  Files          65       66       +1     
  Lines        7120     7114       -6     
==========================================
+ Hits         1755     2098     +343     
+ Misses       5365     5016     -349
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=h1) Report > Merging [#513](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/723d2c4600d2b8c9aabc9a26562553a02616f65d?src=pr&el=desc) will **increase** coverage by `4.84%`. > The diff coverage is `80%`. ```diff @@ Coverage Diff @@ ## master #513 +/- ## ========================================== + Coverage 24.64% 29.49% +4.84% ========================================== Files 65 66 +1 Lines 7120 7114 -6 ========================================== + Hits 1755 2098 +343 + Misses 5365 5016 -349 ```
elegaanz (已從 github.com 遷移) 已審核 5 年前
elegaanz (已從 github.com 遷移) 已留言 5 年前

Isn't there one of the two lines above that should be removed?

Isn't there one of the two lines above that should be removed?
elegaanz (已從 github.com 遷移) 已留言 5 年前

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.
trinity-1686a 已審核 5 年前
發布者
擁有者

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us
trinity-1686a 已審核 5 年前
發布者
擁有者

I think I'll change this to a copy statement, it will make more sense

I think I'll change this to a copy statement, it will make more sense
elegaanz (已從 github.com 遷移) 已審核 5 年前
elegaanz (已從 github.com 遷移) 留下了回應

Looks good, excepted from run_browser_test.sh that I don't understand. 😄

Looks good, excepted from `run_browser_test.sh` that I don't understand. :smile:
@ -0,0 +5,4 @@
mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
elegaanz (已從 github.com 遷移) 已留言 5 年前

I'm not sure to understand what you are doing here… 🤔

I'm not sure to understand what you are doing here… :thinking:
trinity-1686a 已審核 5 年前
@ -0,0 +5,4 @@
mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
發布者
擁有者

I'm creating a "shortcut" to plm run with kcov because I run it multiple time in the following lines, and it's rather long. So when I call $plm <something> after, it just mean "run plm <something> with coverage report"

I'm creating a "shortcut" to plm run with kcov because I run it multiple time in the following lines, and it's rather long. So when I call `$plm <something>` after, it just mean "run `plm <something>` with coverage report"
elegaanz (已從 github.com 遷移) 已審核 5 年前
@ -0,0 +5,4 @@
mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
elegaanz (已從 github.com 遷移) 已留言 5 年前

Oh OK, I get it, it is to get coverage for plm too. Great!

Oh OK, I get it, it is to get coverage for plm too. Great!
elegaanz (已從 github.com 遷移) 核可了這些變更 5 年前
elegaanz (已從 github.com 遷移) 留下了回應

👍

:+1:
igalic (已從 github.com 遷移) 核可了這些變更 5 年前
igalic (已從 github.com 遷移) 留下了回應

👍

👍
此合併請求已被合併為 eabe73ddc0
您也可以查看命令列指南

第一步:

在您的儲存庫中切換到新分支並測試變更。
git checkout -b circleci master
git pull origin circleci

第二步:

合併變更並更新到 Forgejo。
git checkout master
git merge --no-ff circleci
git push origin master
登入 才能加入這對話。
沒有審核者
未選擇里程碑
沒有負責人
2 參與者
通知
截止日期
截止日期無效或超出範圍,請使用「yyyy-mm-dd」的格式。

未設定截止日期。

先決條件

未設定先決條件。

參考: Plume/Plume#513
載入中…
尚未有任何內容