try to build release plume&plm on ci #528

Yhdistetty
Plume_migration_agent yhdistetty 4 committia lähteestä artifact kohteeseen master 5 vuotta sitten
Omistaja

ref Plume-org/docs#27
I should archive the artifacts before uploading

ref Plume-org/docs#27 I should archive the artifacts before uploading
igalic (Migrated from github.com) reviewed 5 vuotta sitten
igalic (Migrated from github.com) jätti kommentin

👍

👍
codecov[bot] kommentoi 5 vuotta sitten (Migrated from github.com)

Codecov Report

Merging #528 into master will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   40.92%   42.48%   +1.56%     
==========================================
  Files          68       68              
  Lines        9823     9314     -509     
==========================================
- Hits         4020     3957      -63     
+ Misses       5803     5357     -446
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=h1) Report > Merging [#528](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/0d708e163930779d149a8cb94766d8f4decbf080?src=pr&el=desc) will **increase** coverage by `1.56%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #528 +/- ## ========================================== + Coverage 40.92% 42.48% +1.56% ========================================== Files 68 68 Lines 9823 9314 -509 ========================================== - Hits 4020 3957 -63 + Misses 5803 5357 -446 ```
elegaanz (Migrated from github.com) reviewed 5 vuotta sitten
elegaanz (Migrated from github.com) jätti kommentin

Would it be possible to bundle the diesel CLI too, please?

Would it be possible to bundle the diesel CLI too, please?
elegaanz kommentoi 5 vuotta sitten (Migrated from github.com)

And also the migration files?

And also the migration files?
Tekijä
Omistaja

Shoulf I include both migrations, only the one of interest as migrations/$db_name or only the one of interest as migrations/ (maybe not the latest as it will not be compatible with our documentation?)

Shoulf I include both migrations, only the one of interest as `migrations/$db_name` or only the one of interest as `migrations/` (maybe not the latest as it will not be compatible with our documentation?)
igalic kommentoi 5 vuotta sitten (Migrated from github.com)

I'm not sure i've asked this before, but, how hard would it be to support both databases? at the same time?

I'm not sure i've asked this before, but, how hard would it be to support both databases? at the same time?
Tekijä
Omistaja

I see 2 ways of doing so :

  • using Box<Connection> everywhere
  • creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type
    But I don't know how any of those would play with r2d2 (the connection manager)
I see 2 ways of doing so : - using `Box<Connection>` everywhere - creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type But I don't know how any of those would play with r2d2 (the connection manager)
elegaanz kommentoi 5 vuotta sitten (Migrated from github.com)

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed)

And for the migrations, the best is to have only the relevant one in migrations/$db to make the archive smaller and keep compatibility with our current docs.

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed) And for the migrations, the best is to have only the relevant one in `migrations/$db` to make the archive smaller and keep compatibility with our current docs.
elegaanz (Migrated from github.com) reviewed 5 vuotta sitten
elegaanz (Migrated from github.com) jätti kommentin

Thank you!

Thank you!
elegaanz (Migrated from github.com) hyväksyi nämä muutokset 5 vuotta sitten
elegaanz (Migrated from github.com) jätti kommentin

(I wanted to approve this PR)

(I wanted to approve this PR)

Reviewers

The pull request has been merged as 3d82265b85.
You can also view command line instructions.

Vaihe 1:

From your project repository, check out a new branch and test the changes.
git checkout -b artifact master
git pull origin artifact

Vaihe 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff artifact
git push origin master
Sign in to join this conversation.
No reviewers
Ei merkkipaalua
Ei käsittelijää
2 osallistujaa
Ilmoitukset
Määräpäivä
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

Määräpäivää ei asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Reference: Plume/Plume#528
Ladataan…
Sisältöä ei vielä ole.