try to build release plume&plm on ci #528

Scalone

Plume_migration_agent scala 4 commity/ów z artifact do master

trinity-1686a skomentował(-a)

Właściciel

ref Plume-org/docs#27
I should archive the artifacts before uploading

ref Plume-org/docs#27 I should archive the artifacts before uploading

igalic (Zmigrowane z github.com) zrecenzowano

igalic (Zmigrowane z github.com) zostawił komentarz

👍

codecov[bot] skomentował(-a) (Zmigrowane z github.com)

Codecov Report

Merging #528 into master will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   40.92%   42.48%   +1.56%     
==========================================
  Files          68       68              
  Lines        9823     9314     -509     
==========================================
- Hits         4020     3957      -63     
+ Misses       5803     5357     -446

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=h1) Report > Merging [#528](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/0d708e163930779d149a8cb94766d8f4decbf080?src=pr&el=desc) will **increase** coverage by `1.56%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #528 +/- ## ========================================== + Coverage 40.92% 42.48% +1.56% ========================================== Files 68 68 Lines 9823 9314 -509 ========================================== - Hits 4020 3957 -63 + Misses 5803 5357 -446 ```

elegaanz (Zmigrowane z github.com) zrecenzowano

elegaanz (Zmigrowane z github.com) zostawił komentarz

Would it be possible to bundle the diesel CLI too, please?

elegaanz skomentował(-a) (Zmigrowane z github.com)

And also the migration files?

trinity-1686a skomentował(-a)

Autor

Właściciel

Shoulf I include both migrations, only the one of interest as migrations/$db_name or only the one of interest as migrations/ (maybe not the latest as it will not be compatible with our documentation?)

Shoulf I include both migrations, only the one of interest as `migrations/$db_name` or only the one of interest as `migrations/` (maybe not the latest as it will not be compatible with our documentation?)

igalic skomentował(-a) (Zmigrowane z github.com)

I'm not sure i've asked this before, but, how hard would it be to support both databases? at the same time?

trinity-1686a skomentował(-a)

Autor

Właściciel

I see 2 ways of doing so :

using Box<Connection> everywhere
creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type
But I don't know how any of those would play with r2d2 (the connection manager)

I see 2 ways of doing so : - using `Box<Connection>` everywhere - creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type But I don't know how any of those would play with r2d2 (the connection manager)

elegaanz skomentował(-a) (Zmigrowane z github.com)

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed)

And for the migrations, the best is to have only the relevant one in migrations/$db to make the archive smaller and keep compatibility with our current docs.

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed) And for the migrations, the best is to have only the relevant one in `migrations/$db` to make the archive smaller and keep compatibility with our current docs.

elegaanz (Zmigrowane z github.com) zrecenzowano

elegaanz (Zmigrowane z github.com) zostawił komentarz

Thank you!

elegaanz (Zmigrowane z github.com) zatwierdza te zmiany

elegaanz (Zmigrowane z github.com) zostawił komentarz

(I wanted to approve this PR)

Recenzenci

Pull Request został scalony jako 3d82265b85.

Możesz także zobaczyć instrukcje wiersza poleceń.

Krok 1:

Z repozytorium twojego projektu, sprawdź nową gałąź i przetestuj zmiany.

git checkout -b artifact master

git pull origin artifact

Krok 2:

Połącz zmiany i zaktualizuj na Forgejo.

git checkout master

git merge --no-ff artifact

git push origin master

Zaloguj się, aby dołączyć do tej rozmowy.

Brak recenzentów

Brak kamienia milowego

Brak przypisanych

Uczestnicy 2

Powiadomienia

Termin realizacji

Data realizacji jest niewłaściwa lub spoza zakresu. Użyj formatu 'yyyy-mm-dd'.

Brak ustawionego terminu realizacji.

Zależności

No dependencies set.

Ładowanie…

Nie ma jeszcze treści.

Etykiety Kamienie milowe

try to build release plume&plm on ci #528

Codecov Report

Recenzenci

Krok 1:

Krok 2: