8
16
Derivar 22

try to build release plume&plm on ci #528

Integrado
Plume_migration_agent integrou 4 cometimento(s) do ramo artifact no ramo master há 5 anos
Proprietário(a)

ref Plume-org/docs#27
I should archive the artifacts before uploading

ref Plume-org/docs#27 I should archive the artifacts before uploading
igalic (Migrado de github.com) reviu há 5 anos
igalic (Migrado de github.com) deixou um comentário

👍

👍
codecov[bot] comentou há 5 anos (Migrado de github.com)

Codecov Report

Merging #528 into master will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   40.92%   42.48%   +1.56%     
==========================================
  Files          68       68              
  Lines        9823     9314     -509     
==========================================
- Hits         4020     3957      -63     
+ Misses       5803     5357     -446
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=h1) Report > Merging [#528](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/0d708e163930779d149a8cb94766d8f4decbf080?src=pr&el=desc) will **increase** coverage by `1.56%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #528 +/- ## ========================================== + Coverage 40.92% 42.48% +1.56% ========================================== Files 68 68 Lines 9823 9314 -509 ========================================== - Hits 4020 3957 -63 + Misses 5803 5357 -446 ```
elegaanz (Migrado de github.com) reviu há 5 anos
elegaanz (Migrado de github.com) deixou um comentário

Would it be possible to bundle the diesel CLI too, please?

Would it be possible to bundle the diesel CLI too, please?
elegaanz comentou há 5 anos (Migrado de github.com)

And also the migration files?

And also the migration files?
Remetente
Proprietário(a)

Shoulf I include both migrations, only the one of interest as migrations/$db_name or only the one of interest as migrations/ (maybe not the latest as it will not be compatible with our documentation?)

Shoulf I include both migrations, only the one of interest as `migrations/$db_name` or only the one of interest as `migrations/` (maybe not the latest as it will not be compatible with our documentation?)
igalic comentou há 5 anos (Migrado de github.com)

I'm not sure i've asked this before, but, how hard would it be to support both databases? at the same time?

I'm not sure i've asked this before, but, how hard would it be to support both databases? at the same time?
Remetente
Proprietário(a)

I see 2 ways of doing so :

  • using Box<Connection> everywhere
  • creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type
    But I don't know how any of those would play with r2d2 (the connection manager)
I see 2 ways of doing so : - using `Box<Connection>` everywhere - creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type But I don't know how any of those would play with r2d2 (the connection manager)
elegaanz comentou há 5 anos (Migrado de github.com)

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed)

And for the migrations, the best is to have only the relevant one in migrations/$db to make the archive smaller and keep compatibility with our current docs.

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed) And for the migrations, the best is to have only the relevant one in `migrations/$db` to make the archive smaller and keep compatibility with our current docs.
elegaanz (Migrado de github.com) reviu há 5 anos
elegaanz (Migrado de github.com) deixou um comentário

Thank you!

Thank you!
elegaanz (Migrado de github.com) aprovou estas modificações há 5 anos
elegaanz (Migrado de github.com) deixou um comentário

(I wanted to approve this PR)

(I wanted to approve this PR)

Revisores

A integração foi executada no cometimento 3d82265b85.

Passo 1:

No seu repositório, crie um novo ramo e teste as modificações.
git checkout -b artifact master
git pull origin artifact

Passo 2:

Integre as modificações e envie para o Forgejo.
git checkout master
git merge --no-ff artifact
git push origin master
Inicie a sessão para participar neste diálogo.
Sem revisores
Sem etapa
Sem encarregados
2 Participantes
Notificações
Data de vencimento
A data de vencimento é inválida ou está fora do intervalo permitido. Por favor, use o formato 'aaaa-mm-dd'.

Sem data de vencimento definida.

Dependências

Não estão definidas dependências.

Referência: Plume/Plume#528
Carregando…
Ainda não há conteúdo.