try to build release plume&plm on ci #528

Злито
Plume_migration_agent злито 4 комітів з artifact до master 5 роки тому
trinity-1686a прокоментував(ла) 5 роки тому
Власник

ref Plume-org/docs#27
I should archive the artifacts before uploading

ref Plume-org/docs#27 I should archive the artifacts before uploading
igalic (Перенесено з github.com) рецензовано 5 роки тому
igalic (Перенесено з github.com) додав коментар

👍

👍
codecov[bot] прокоментував(ла) 5 роки тому (Перенесено з github.com)

Codecov Report

Merging #528 into master will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   40.92%   42.48%   +1.56%     
==========================================
  Files          68       68              
  Lines        9823     9314     -509     
==========================================
- Hits         4020     3957      -63     
+ Misses       5803     5357     -446
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=h1) Report > Merging [#528](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/0d708e163930779d149a8cb94766d8f4decbf080?src=pr&el=desc) will **increase** coverage by `1.56%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #528 +/- ## ========================================== + Coverage 40.92% 42.48% +1.56% ========================================== Files 68 68 Lines 9823 9314 -509 ========================================== - Hits 4020 3957 -63 + Misses 5803 5357 -446 ```
elegaanz (Перенесено з github.com) рецензовано 5 роки тому
elegaanz (Перенесено з github.com) додав коментар

Would it be possible to bundle the diesel CLI too, please?

Would it be possible to bundle the diesel CLI too, please?
elegaanz прокоментував(ла) 5 роки тому (Перенесено з github.com)

And also the migration files?

And also the migration files?
trinity-1686a прокоментував(ла) 5 роки тому
Автор
Власник

Shoulf I include both migrations, only the one of interest as migrations/$db_name or only the one of interest as migrations/ (maybe not the latest as it will not be compatible with our documentation?)

Shoulf I include both migrations, only the one of interest as `migrations/$db_name` or only the one of interest as `migrations/` (maybe not the latest as it will not be compatible with our documentation?)
igalic прокоментував(ла) 5 роки тому (Перенесено з github.com)

I'm not sure i've asked this before, but, how hard would it be to support both databases? at the same time?

I'm not sure i've asked this before, but, how hard would it be to support both databases? at the same time?
trinity-1686a прокоментував(ла) 5 роки тому
Автор
Власник

I see 2 ways of doing so :

  • using Box<Connection> everywhere
  • creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type
    But I don't know how any of those would play with r2d2 (the connection manager)
I see 2 ways of doing so : - using `Box<Connection>` everywhere - creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type But I don't know how any of those would play with r2d2 (the connection manager)
elegaanz прокоментував(ла) 5 роки тому (Перенесено з github.com)

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed)

And for the migrations, the best is to have only the relevant one in migrations/$db to make the archive smaller and keep compatibility with our current docs.

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed) And for the migrations, the best is to have only the relevant one in `migrations/$db` to make the archive smaller and keep compatibility with our current docs.
elegaanz (Перенесено з github.com) рецензовано 5 роки тому
elegaanz (Перенесено з github.com) додав коментар

Thank you!

Thank you!
elegaanz (Перенесено з github.com) зміни затверджено 5 роки тому
elegaanz (Перенесено з github.com) додав коментар

(I wanted to approve this PR)

(I wanted to approve this PR)

Рецензенти

Запит на злиття був влитиий як 3d82265b85.
Також можна переглянути інструкції для командного рядка.

Крок 1:

У репозиторії вашого проєкту перевірте нову гілку і протестуйте зміни.
git checkout -b artifact master
git pull origin artifact

Крок 2:

Об'єднати зміни і оновити на Forgejo.
git checkout master
git merge --no-ff artifact
git push origin master
Підпишіться щоб приєднатися до обговорення.
Немає рецензентів
Етап відсутній
Немає виконавця
2 учасників
Сповіщення
Дата завершення
Термін дії не дійсний або знаходиться за межами допустимого діапазону. Будь ласка використовуйте формат 'yyyy-mm-dd'.

Термін виконання не встановлений.

Залежності

No dependencies set.

Reference: Plume/Plume#528
Завантаження…
Тут ще немає жодного змісту.