try to build release plume&plm on ci #528

已合并

Plume_migration_agent 于将 4 次代码提交从 artifact 合并至 master

trinity-1686a 评论于

所有者

ref Plume-org/docs#27
I should archive the artifacts before uploading

ref Plume-org/docs#27 I should archive the artifacts before uploading

igalic (从 github.com 迁移) 评审于

igalic (从 github.com 迁移) 留下了一条评论

👍

codecov[bot] 评论于 (从 github.com 迁移)

Codecov Report

Merging #528 into master will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   40.92%   42.48%   +1.56%     
==========================================
  Files          68       68              
  Lines        9823     9314     -509     
==========================================
- Hits         4020     3957      -63     
+ Misses       5803     5357     -446

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=h1) Report > Merging [#528](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/0d708e163930779d149a8cb94766d8f4decbf080?src=pr&el=desc) will **increase** coverage by `1.56%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #528 +/- ## ========================================== + Coverage 40.92% 42.48% +1.56% ========================================== Files 68 68 Lines 9823 9314 -509 ========================================== - Hits 4020 3957 -63 + Misses 5803 5357 -446 ```

elegaanz (从 github.com 迁移) 评审于

elegaanz (从 github.com 迁移) 留下了一条评论

Would it be possible to bundle the diesel CLI too, please?

elegaanz 评论于 (从 github.com 迁移)

And also the migration files?

trinity-1686a 评论于

发布者

所有者

Shoulf I include both migrations, only the one of interest as migrations/$db_name or only the one of interest as migrations/ (maybe not the latest as it will not be compatible with our documentation?)

Shoulf I include both migrations, only the one of interest as `migrations/$db_name` or only the one of interest as `migrations/` (maybe not the latest as it will not be compatible with our documentation?)

igalic 评论于 (从 github.com 迁移)

I'm not sure i've asked this before, but, how hard would it be to support both databases? at the same time?

trinity-1686a 评论于

发布者

所有者

I see 2 ways of doing so :

using Box<Connection> everywhere
creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type
But I don't know how any of those would play with r2d2 (the connection manager)

I see 2 ways of doing so : - using `Box<Connection>` everywhere - creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type But I don't know how any of those would play with r2d2 (the connection manager)

elegaanz 评论于 (从 github.com 迁移)

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed)

And for the migrations, the best is to have only the relevant one in migrations/$db to make the archive smaller and keep compatibility with our current docs.

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed) And for the migrations, the best is to have only the relevant one in `migrations/$db` to make the archive smaller and keep compatibility with our current docs.

elegaanz (从 github.com 迁移) 评审于

elegaanz (从 github.com 迁移) 留下了一条评论

Thank you!

elegaanz (从 github.com 迁移) 于批准此合并请求

elegaanz (从 github.com 迁移) 留下了一条评论

(I wanted to approve this PR)

评审人

该合并请求已作为 3d82265b85 被合并。

你也可以查看命令行指令

第一步:

从你的仓库中签出一个新的分支并测试变更。

git checkout -b artifact master

git pull origin artifact

第二步：

合并变更并更新到 Forgejo 上

git checkout master

git merge --no-ff artifact

git push origin master

登录并参与到对话中。

无审核者

未选择里程碑

未指派成员

2 名参与者

通知

到期时间

到期日期无效或超出范围。请使用 'yyyy-mm-dd' 格式。

未设置到期时间。

依赖工单

没有设置依赖项。

正在加载...

这个人很懒，什么都没留下。

标签 里程碑

try to build release plume&plm on ci #528

Codecov Report

评审人

第一步:

第二步：

标签里程碑