Remove Canapi #540

已合併
elegaanz 5 年之前 將 4 次代碼提交從 bye-canapi 合併至 master
elegaanz " 評論 5 年之前" (Migrated from github.com)

It added more complexity than it helped.

I will eventually rewrite it as a proc-macro that generates types for an API from an OpenAPI spec, so maybe it will be re-introduced at some point (but it will be totally different).

Also I added an endpoint to delete posts, the function was here before, but not exposed.

It added more complexity than it helped. I will eventually rewrite it as a proc-macro that generates types for an API from an OpenAPI spec, so maybe it will be re-introduced at some point (but it will be totally different). Also I added an endpoint to delete posts, the function was here before, but not exposed.
codecov[bot] " 評論 5 年之前" (Migrated from github.com)

Codecov Report

Merging #540 into master will increase coverage by 0.3%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #540     +/-   ##
=========================================
+ Coverage   43.97%   44.28%   +0.3%     
=========================================
  Files          68       68             
  Lines        7890     7835     -55     
=========================================
  Hits         3470     3470             
+ Misses       4420     4365     -55
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/540?src=pr&el=h1) Report > Merging [#540](https://codecov.io/gh/Plume-org/Plume/pull/540?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a20d2df50aaf39ab7e40a76c074449fac44be617?src=pr&el=desc) will **increase** coverage by `0.3%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #540 +/- ## ========================================= + Coverage 43.97% 44.28% +0.3% ========================================= Files 68 68 Lines 7890 7835 -55 ========================================= Hits 3470 3470 + Misses 4420 4365 -55 ```
trinity-1686a reviewed 5 年之前
trinity-1686a left a comment
所有者

small comment but not a real problem as it was already that way before

small comment but not a real problem as it was already that way before
所有者

I think it should be chosen automatically only if the user has only one blog, so to be clearly deterministic (currently it's choosing the first found, which was already the old behavior)

I think it should be chosen automatically only if the user has only one blog, so to be clearly deterministic (currently it's choosing the first found, which was already the old behavior)
trinity-1686a reviewed 5 年之前
trinity-1686a left a comment
所有者

👍

:+1:
trinity-1686a approved these changes 5 年之前
trinity-1686a left a comment
所有者

👍

:+1:

Reviewers

trinity-1686a approved these changes 5 年之前
The pull request has been merged as ec57f1e687.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b bye-canapi master
git pull origin bye-canapi

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff bye-canapi
git push origin master
登入 才能加入這對話。
No reviewers
未選擇里程碑
No Assignees
2 參與者
訊息
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#540
Loading…
尚未有任何內容