Plume
/
Plume
8
16
Fork 22
Code Issues 174 Pull Requests 8 Releases 8 Wiki Activity

Labels Milestones

Make comments in styleshhets a bit clearer #545

Merged
marek-lach merged 2 commits from Plume-color-scheme into master 5 years ago
Conversation 1 Commits 2 Files Changed 2
marek-lach commented 5 years ago (Migrated from github.com)
There is no content yet.
codecov[bot] commented 5 years ago (Migrated from github.com)

Codecov Report

Merging #545 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #545   +/-   ##
=======================================
  Coverage   43.97%   43.97%           
=======================================
  Files          68       68           
  Lines        7890     7890           
=======================================
  Hits         3470     3470           
  Misses       4420     4420
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/545?src=pr&el=h1) Report > Merging [#545](https://codecov.io/gh/Plume-org/Plume/pull/545?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a20d2df50aaf39ab7e40a76c074449fac44be617?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #545 +/- ## ======================================= Coverage 43.97% 43.97% ======================================= Files 68 68 Lines 7890 7890 ======================================= Hits 3470 3470 Misses 4420 4420 ```
igalic (Migrated from github.com) approved these changes 5 years ago
igalic (Migrated from github.com) left a comment

👍

👍
static/css/_variables.scss
@ -1,4 +1,4 @@
// Colors
// Color Scheme
$background: #F4F4F4;
igalic (Migrated from github.com) commented 5 years ago

how did this change, in its own, fail the build?

how did this change, in its own, fail the build?
trinity-1686a reviewed 5 years ago
static/css/_variables.scss
@ -1,4 +1,4 @@
// Colors
// Color Scheme
$background: #F4F4F4;
trinity-1686a commented 5 years ago
Owner

kcov seems to use something that is not always available in circle-ci containers, and make the job fail with a "set personality failed" or similar. When I see one, I usually restart the workflow to make things pass as they should, in this case I wasn't quick enough and you noticed before me

kcov seems to use something that is not always available in circle-ci containers, and make the job fail with a "set personality failed" or similar. When I see one, I usually restart the workflow to make things pass as they should, in this case I wasn't quick enough and you noticed before me

Reviewers

igalic
The pull request has been merged as ff92ac0763.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b Plume-color-scheme master
git pull origin Plume-color-scheme

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff Plume-color-scheme
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
igalic
Labels
Apply labels
Clear labels   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#545
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'Plume-color-scheme'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes