Plume
/
Plume
8
16
フォーク 22
コード イシュー 174 プルリクエスト 8 リリース 8 Wiki アクティビティ

ラベル マイルストーン

Add some feedback when performing some actions #552

マージ済み
elegaanz が 7 個のコミットを action-feedback から master へマージ 5年前
会話 6 コミット 7 変更されたファイル 40
elegaanz がコメント 5年前 (github.comから移行)

Here is an example of what it looks like (this is just a test, in reality you can only have one of these messages at the same time):

Screenshot_2019-04-27 Plume unu ⋅ Plume

I don't know if there is a simpler way to do it. Also, I added msg: Option<FlashMessage> to almost all routes to be sure that if a message was present it would be rendered, but maybe it is not necessary and only make the code harder to read? And maybe msg should go in PlumeRocket as it is used almost everywhere?

Fixes #468

Here is an example of what it looks like (this is just a test, in reality you can only have one of these messages at the same time): ![Screenshot_2019-04-27 Plume unu ⋅ Plume](https://user-images.githubusercontent.com/16254623/56852089-77178700-690e-11e9-88fc-acb089b58fef.png) I don't know if there is a simpler way to do it. Also, I added `msg: Option<FlashMessage>` to almost all routes to be sure that if a message was present it would be rendered, but maybe it is not necessary and only make the code harder to read? And maybe `msg` should go in `PlumeRocket` as it is used almost everywhere? Fixes #468
👍 1
codecov[bot] がコメント 5年前 (github.comから移行)

Codecov Report

Merging #552 into master will increase coverage by 0.02%.
The diff coverage is 5.12%.

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   44.08%   44.11%   +0.02%     
==========================================
  Files          68       68              
  Lines        7937     7984      +47     
==========================================
+ Hits         3499     3522      +23     
- Misses       4438     4462      +24
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/552?src=pr&el=h1) Report > Merging [#552](https://codecov.io/gh/Plume-org/Plume/pull/552?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/787eb7f3992e43e7a149288f3378c90dd4fe4bf8?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `5.12%`. ```diff @@ Coverage Diff @@ ## master #552 +/- ## ========================================== + Coverage 44.08% 44.11% +0.02% ========================================== Files 68 68 Lines 7937 7984 +47 ========================================== + Hits 3499 3522 +23 - Misses 4438 4462 +24 ```
trinity-1686a がコメント 5年前
オーナー

And maybe msg should go in PlumeRocket as it is used almost everywhere?

Considering how it must be everywhere, I think it can go in PlumeRocket, as well as in template BaseContext. Also BaseContext could implement From<PlumeRocket> so it is easier to build and reduce duplication

> And maybe `msg` should go in `PlumeRocket` as it is used almost everywhere? Considering how it must be everywhere, I think it can go in `PlumeRocket`, as well as in template `BaseContext`. Also `BaseContext` could implement `From<PlumeRocket>` so it is easier to build and reduce duplication
👍 1 🚀 1
igalic (github.comから移行) がレビュー 5年前
igalic (github.comから移行) がコメント

maybe we should hold on committing the translations in such prs?

do then regularly elsewhere

maybe we should hold on committing the translations in such prs? do then regularly elsewhere
po/plume/hr.po
igalic (github.comから移行) がコメント 5年前

this is supposed to be

Ti nisi autor ovog(a?) bloga

but i just realised that fuzzy means it was auto translated…

this is supposed to be > Ti nisi autor ovog(a?) bloga but i just realised that fuzzy means it was auto translated…
elegaanz がコメント 5年前 (github.comから移行)

@igalic I don't really know… it is true it pollutes a little bit the diff, but at the same time it makes sense to have them with the change in the interface.

@igalic I don't really know… it is true it pollutes a little bit the diff, but at the same time it makes sense to have them with the change in the interface.
elegaanz (github.comから移行) がレビュー 5年前
po/plume/hr.po
elegaanz (github.comから移行) がコメント 5年前

Yes, it was auto-translated. Once it will be on Crowdin, you will be able to fix it. 😉

Yes, it was auto-translated. Once it will be on Crowdin, you will be able to fix it. :wink:
trinity-1686a がコメント 5年前
オーナー

I'd be to not pollute pr with this, and have something that autocommit the changes once a week, or after each merge

I'd be to not pollute pr with this, and have something that autocommit the changes once a week, or after each merge
👍 1
trinity-1686a がレビュー 5年前
trinity-1686a がコメント
オーナー

👀

:eyes:
src/template_utils.rs
@ -17,0 +27,4 @@
&Connection,
&Catalog,
Option<User>,
Option<(String, String)>,
trinity-1686a がコメント 5年前
オーナー

why not implementing From<PlumeRocket> for Context? It will auto implement Into<Context> for PlumeRocket, and you should be able to use into() with no need to import this trait everywhere

why not implementing `From<PlumeRocket>` for Context? It will auto implement `Into<Context>` for PlumeRocket, and you should be able to use `into()` with no need to import this trait everywhere
elegaanz (github.comから移行) がレビュー 5年前
src/template_utils.rs
@ -17,0 +27,4 @@
&Connection,
&Catalog,
Option<User>,
Option<(String, String)>,
elegaanz (github.comから移行) がコメント 5年前

Because Rust is complaining about the fact that all the parameters of the trait comes from another crate, and that it could cause conflicts, while I don't think it can? 🤷‍♀️ But yeah, I tried it, and it doesn't work.

Because Rust is complaining about the fact that all the parameters of the trait comes from another crate, and that it could cause conflicts, while I don't think it can? :woman_shrugging: But yeah, I tried it, and it doesn't work.
trinity-1686a がレビュー 5年前
src/template_utils.rs
@ -17,0 +27,4 @@
&Connection,
&Catalog,
Option<User>,
Option<(String, String)>,
trinity-1686a がコメント 5年前
オーナー

ho, it's because BaseContext is not a true struct but a typedef to a tuple of basic types (in theory it could cause conflict, because the exact same trait can be implemented in plume-model, thus creating a conflict). This mean we can either convert BaseContext to be a true type, or implement Into in plume-models. I've tried the first one, but it requires some small but ugly changes so I'm not sure it would be better (you can take a look at the patch here)

ho, it's because BaseContext is not a true struct but a typedef to a tuple of basic types (in theory it could cause conflict, because the exact same trait can be implemented in plume-model, thus creating a conflict). This mean we can either convert BaseContext to be a true type, or implement Into in plume-models. I've tried the first one, but it requires some small but ugly changes so I'm not sure it would be better (you can take a look at the patch [here](https://framadrop.org/r/aXcBuKkLEW#rzbPsNSdq+XCFboTnRLdY8Qt3RNqqUYGgrnA8bfUoQQ=))
trinity-1686a が変更を承認 5年前
trinity-1686a がコメント
オーナー

👍

:+1:
elegaanz がコメント 5年前 (github.comから移行)

Do you want me to apply your patch before merging?

Do you want me to apply your patch before merging?
trinity-1686a がコメント 5年前
オーナー

It was just to show what I came up with, but having &(&rockets).into() everywhere is definitely worse than importing a trait

It was just to show what I came up with, but having `&(&rockets).into()` everywhere is definitely worse than importing a trait
👍 1

レビューア

trinity-1686a が変更を承認 5年前
プルリクエストは 8f1ab3485e でマージされています。
コマンドラインの手順も確認できます。

ステップ 1:

あなたのプロジェクトリポジトリで新しいブランチをチェックアウトし、変更内容をテストします。
git checkout -b action-feedback master
git pull origin action-feedback

ステップ 2:

変更内容をマージして、Forgejoに反映します。
git checkout master
git merge --no-ff action-feedback
git push origin master
サインインしてこの会話に参加。
レビューア
レビュー依頼
レビューアなし
trinity-1686a
ラベル
ラベル付け
ラベルをクリア   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
ラベルなし
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
マイルストーン
マイルストーンの設定
マイルストーンをクリア
項目なし
マイルストーンなし
担当者
担当者の割り当て
担当者をクリア
担当者なし
2 人の参加者
通知
期日
期日が正しくないか範囲を超えています。 'yyyy-mm-dd' の形式で入力してください。

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: Plume/Plume#552
書き込み プレビュー
読み込み中…
キャンセル
保存
まだ内容がありません
ブランチ 'action-feedback' の削除

ブランチの削除は恒久的で、元に戻すことはできません。 続行しますか？

いいえ
はい