import migrations and don't require diesel_cli for admins #555

this is an attempt at integrating migrations to plm, with the goal to remove need for diesel_cli, and to allow arbitrary rust in migrations (can come handy for many reasons, like need to upgrade tantivy index version due to upstream changes, without need to take special steps for sysadmins)

backbone for the feature
integration to plm as new sub-command
update ci
make plume fail to launch if it detect migrations must be run

this is an attempt at integrating migrations to plm, with the goal to remove need for diesel_cli, and to allow arbitrary rust in migrations (can come handy for many reasons, like need to upgrade tantivy index version due to upstream changes, without need to take special steps for sysadmins) - [x] backbone for the feature - [x] integration to plm as new sub-command - [x] update ci - [x] make plume fail to launch if it detect migrations must be run

Codecov Report

Merging #555 into master will increase coverage by 0.3%.
The diff coverage is 89.91%.

@@            Coverage Diff            @@
##           master     #555     +/-   ##
=========================================
+ Coverage   44.08%   44.39%   +0.3%     
=========================================
  Files          68       70      +2     
  Lines        7937     8044    +107     
=========================================
+ Hits         3499     3571     +72     
- Misses       4438     4473     +35

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/555?src=pr&el=h1) Report > Merging [#555](https://codecov.io/gh/Plume-org/Plume/pull/555?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/787eb7f3992e43e7a149288f3378c90dd4fe4bf8?src=pr&el=desc) will **increase** coverage by `0.3%`. > The diff coverage is `89.91%`. ```diff @@ Coverage Diff @@ ## master #555 +/- ## ========================================= + Coverage 44.08% 44.39% +0.3% ========================================= Files 68 70 +2 Lines 7937 8044 +107 ========================================= + Hits 3499 3571 +72 - Misses 4438 4473 +35 ```

👀

At some point the documentation should also be updated to reflect that change

I don't think it would be possible, but creating the PostgreSQL database if it doesn't exist would be perfect.

But it already works fine, so you can merge as it is.

👍

I don't think it would be possible, but creating the PostgreSQL database if it doesn't exist would be perfect. But it already works fine, so you can merge as it is. :+1:

@BaptisteGelez I think it's possible, I'll try to do it (diesel_cli does that from what I saw in it's code)

Edit: apparently it detect a connection error, assume it means the database don't exist, then connect to the same address but without specifying a database, run a query, and then try to reconnect. Considering the first step, this should probably be done in plm, not in plume-models

@BaptisteGelez I think it's possible, I'll try to do it (diesel_cli does that from what I saw in it's code) Edit: apparently it detect a connection error, assume it means the database don't exist, then connect to the same address but without specifying a database, run a query, and then try to reconnect. Considering the first step, this should probably be done in plm, not in plume-models

I don't think it would be possible, but creating the PostgreSQL database if it doesn't exist would be perfect.

usually, create db is a more privileged operation than creating anything in that db…
and i sure hope people aren't giving our software that kind of permissions 😅

> I don't think it would be possible, but creating the PostgreSQL database if it doesn't exist would be perfect. usually, create db is a more privileged operation than creating anything in that db… and i sure hope people aren't giving our software that kind of permissions 😅

So, shall I try, or do I assume people have a "secure" configuration that don't allow us to do privileged things?

Let's say people have a secure configuration. 😄

Let's say people have a secure configuration. :smile:

 @ -0,0 +48,4 @@
                 .unwrap()
                 .chars()
                 .filter(char::is_ascii_digit)
                 .take(14)

 @ -0,0 +48,4 @@
                 .unwrap()
                 .chars()
                 .filter(char::is_ascii_digit)
                 .take(14)

 @ -0,0 +49,4 @@
 pub struct ImportedMigrations(&'static [ComplexMigration]);
 impl ImportedMigrations {
     pub fn run_pending_migrations(&self, conn: &Connection, path: &Path) -> Result<()> {

 @ -0,0 +49,4 @@
 pub struct ImportedMigrations(&'static [ComplexMigration]);
 impl ImportedMigrations {
     pub fn run_pending_migrations(&self, conn: &Connection, path: &Path) -> Result<()> {

标签 里程碑

import migrations and don't require diesel_cli for admins #555

Codecov Report

评审人

第一步:

第二步：

标签 里程碑

import migrations and don't require diesel_cli for admins #555

Codecov Report

评审人

第一步:

第二步：

标签里程碑