8
16
Fork 22

reduce reqwest timeout to 5s #557

Zusammengeführt
Plume_migration_agent hat 1 Commits von reduce-timeout nach master vor 5 Jahren zusammengeführt
trinity-1686a hat vor 5 Jahren kommentiert
Besitzer

Current timeout is 30s, this add a second kind of timeout : if connection to remote can't be established in 5s, the remote is considered down, so that a thread don't stall for too long for no reason (and also make some unit test much faster to run)

Current timeout is 30s, this add a second kind of timeout : if connection to remote can't be established in 5s, the remote is considered down, so that a thread don't stall for too long for no reason (and also make some unit test much faster to run)
elegaanz (Migriert von github.com) hat die Änderungen vor 5 Jahren genehmigt
elegaanz (Migriert von github.com) hat einen Kommentar hinterlassen

It makes me think: couldn't we have a unique client (in a lazy_static! or something like that). I think reqwest keep connections for a certain time if the client is not dropped, and it probably caches DNS too.

Otherwise, it looks good to me, so if the CI is happy you can merge.

It makes me think: couldn't we have a unique client (in a `lazy_static!` or something like that). I think reqwest keep connections for a certain time if the client is not dropped, and it probably caches DNS too. Otherwise, it looks good to me, so if the CI is happy you can merge.
codecov[bot] hat vor 5 Jahren kommentiert (Migriert von github.com)

Codecov Report

Merging #557 into master will increase coverage by 2.71%.
The diff coverage is 62.96%.

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   40.03%   42.75%   +2.71%     
==========================================
  Files          69       70       +1     
  Lines        8035     8846     +811     
==========================================
+ Hits         3217     3782     +565     
- Misses       4818     5064     +246
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/557?src=pr&el=h1) Report > Merging [#557](https://codecov.io/gh/Plume-org/Plume/pull/557?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/8f1ab3485e3f70072fa3bf276dab31c1c6bc50bd?src=pr&el=desc) will **increase** coverage by `2.71%`. > The diff coverage is `62.96%`. ```diff @@ Coverage Diff @@ ## master #557 +/- ## ========================================== + Coverage 40.03% 42.75% +2.71% ========================================== Files 69 70 +1 Lines 8035 8846 +811 ========================================== + Hits 3217 3782 +565 - Misses 4818 5064 +246 ```
trinity-1686a hat vor 5 Jahren kommentiert
Ersteller
Besitzer

maybe not a unique client (if we have multiple request to do at the same time they will be queued), but we could probably make some kind of pool of clients. I'll keep the idea somewhere for when I have spare time to spend

maybe not a unique client (if we have multiple request to do at the same time they will be queued), but we could probably make some kind of pool of clients. I'll keep the idea somewhere for when I have spare time to spend

Reviewer

Der Pull Request wurde als 33a0c7dcd3 gemergt.

Schritt 1:

Wechsle auf einen neuen Branch in deinem lokalen Repository und teste die Änderungen.
git checkout -b reduce-timeout master
git pull origin reduce-timeout

Schritt 2:

Führe die Änderungen zusammen und aktualisiere den Stand online auf Forgejo.
git checkout master
git merge --no-ff reduce-timeout
git push origin master
Anmelden, um an der Diskussion teilzunehmen.
Keine Reviewer
Kein Meilenstein
Niemand zuständig
2 Beteiligte
Nachrichten
Fällig am
Das Fälligkeitsdatum ist ungültig oder außerhalb des zulässigen Bereichs. Bitte verwende das Format „jjjj-mm-tt“.

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Keine Abhängigkeiten gesetzt.

Referenz: Plume/Plume#557
Laden…
Hier gibt es bis jetzt noch keinen Inhalt.