reduce reqwest timeout to 5s
#557
Zusammengeführt
Plume_migration_agent
hat 1 Commits von reduce-timeout
nach master
vor 5 Jahren zusammengeführt
Laden…
In neuem Issue referenzieren
Hier gibt es bis jetzt noch keinen Inhalt.
Branch „reduce-timeout“ löschen
Das Löschen eines Branches ist permanent. Es KANN NICHT rückgängig gemacht werden. Fortfahren?
Current timeout is 30s, this add a second kind of timeout : if connection to remote can't be established in 5s, the remote is considered down, so that a thread don't stall for too long for no reason (and also make some unit test much faster to run)
It makes me think: couldn't we have a unique client (in a
lazy_static!
or something like that). I think reqwest keep connections for a certain time if the client is not dropped, and it probably caches DNS too.Otherwise, it looks good to me, so if the CI is happy you can merge.
Codecov Report
maybe not a unique client (if we have multiple request to do at the same time they will be queued), but we could probably make some kind of pool of clients. I'll keep the idea somewhere for when I have spare time to spend
Reviewer
33a0c7dcd3
gemergt.Schritt 1:
Wechsle auf einen neuen Branch in deinem lokalen Repository und teste die Änderungen.Schritt 2:
Führe die Änderungen zusammen und aktualisiere den Stand online auf Forgejo.