reduce reqwest timeout to 5s #557

Merge aplicado

Plume_migration_agent mesclou 1 commit de reduce-timeout em master

2019-04-30 21:30:13 +00:00

trinity-1686a comentou

2019-04-30 18:27:38 +00:00

Proprietário(a)

Current timeout is 30s, this add a second kind of timeout : if connection to remote can't be established in 5s, the remote is considered down, so that a thread don't stall for too long for no reason (and also make some unit test much faster to run)

elegaanz (Migrado de github.com) aprovou estas alterações 2019-04-30 21:14:23 +00:00

elegaanz (Migrado de github.com) deixou um comentário

It makes me think: couldn't we have a unique client (in a lazy_static! or something like that). I think reqwest keep connections for a certain time if the client is not dropped, and it probably caches DNS too.

Otherwise, it looks good to me, so if the CI is happy you can merge.

It makes me think: couldn't we have a unique client (in a `lazy_static!` or something like that). I think reqwest keep connections for a certain time if the client is not dropped, and it probably caches DNS too. Otherwise, it looks good to me, so if the CI is happy you can merge.

codecov[bot] comentou

2019-04-30 21:19:09 +00:00

(Migrado de github.com)

Codecov Report

Merging #557 into master will increase coverage by 2.71%.
The diff coverage is 62.96%.

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   40.03%   42.75%   +2.71%     
==========================================
  Files          69       70       +1     
  Lines        8035     8846     +811     
==========================================
+ Hits         3217     3782     +565     
- Misses       4818     5064     +246

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/557?src=pr&el=h1) Report > Merging [#557](https://codecov.io/gh/Plume-org/Plume/pull/557?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/8f1ab3485e3f70072fa3bf276dab31c1c6bc50bd?src=pr&el=desc) will **increase** coverage by `2.71%`. > The diff coverage is `62.96%`. ```diff @@ Coverage Diff @@ ## master #557 +/- ## ========================================== + Coverage 40.03% 42.75% +2.71% ========================================== Files 69 70 +1 Lines 8035 8846 +811 ========================================== + Hits 3217 3782 +565 - Misses 4818 5064 +246 ```

trinity-1686a comentou

2019-04-30 21:28:49 +00:00

Autor

Proprietário(a)

maybe not a unique client (if we have multiple request to do at the same time they will be queued), but we could probably make some kind of pool of clients. I'll keep the idea somewhere for when I have spare time to spend

👍 1