reduce reqwest timeout to 5s #557

Birleştirildi
Plume_migration_agent 5 yıl önce reduce-timeout içindeki 1 işlemeyi master ile birleştirdi
Sahibi

Current timeout is 30s, this add a second kind of timeout : if connection to remote can't be established in 5s, the remote is considered down, so that a thread don't stall for too long for no reason (and also make some unit test much faster to run)

Current timeout is 30s, this add a second kind of timeout : if connection to remote can't be established in 5s, the remote is considered down, so that a thread don't stall for too long for no reason (and also make some unit test much faster to run)
elegaanz (github.com konumundan göç edildi) 5 yıl önce bu değişiklikleri onayladı
elegaanz (github.com konumundan göç edildi) bir yorum yaptı

It makes me think: couldn't we have a unique client (in a lazy_static! or something like that). I think reqwest keep connections for a certain time if the client is not dropped, and it probably caches DNS too.

Otherwise, it looks good to me, so if the CI is happy you can merge.

It makes me think: couldn't we have a unique client (in a `lazy_static!` or something like that). I think reqwest keep connections for a certain time if the client is not dropped, and it probably caches DNS too. Otherwise, it looks good to me, so if the CI is happy you can merge.
codecov[bot] 5 yıl önce yorum yaptı (github.com konumundan göç edildi)

Codecov Report

Merging #557 into master will increase coverage by 2.71%.
The diff coverage is 62.96%.

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   40.03%   42.75%   +2.71%     
==========================================
  Files          69       70       +1     
  Lines        8035     8846     +811     
==========================================
+ Hits         3217     3782     +565     
- Misses       4818     5064     +246
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/557?src=pr&el=h1) Report > Merging [#557](https://codecov.io/gh/Plume-org/Plume/pull/557?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/8f1ab3485e3f70072fa3bf276dab31c1c6bc50bd?src=pr&el=desc) will **increase** coverage by `2.71%`. > The diff coverage is `62.96%`. ```diff @@ Coverage Diff @@ ## master #557 +/- ## ========================================== + Coverage 40.03% 42.75% +2.71% ========================================== Files 69 70 +1 Lines 8035 8846 +811 ========================================== + Hits 3217 3782 +565 - Misses 4818 5064 +246 ```
Poster
Sahibi

maybe not a unique client (if we have multiple request to do at the same time they will be queued), but we could probably make some kind of pool of clients. I'll keep the idea somewhere for when I have spare time to spend

maybe not a unique client (if we have multiple request to do at the same time they will be queued), but we could probably make some kind of pool of clients. I'll keep the idea somewhere for when I have spare time to spend

Gözden Geçirenler

Değişiklik isteği 33a0c7dcd3 olarak birleştirildi.
komut satırı talimatlarını da görüntüleyebilirsiniz.

1. Adım:

Proje deponuzdan yeni bir dala göz atın ve değişiklikleri test edin.
git checkout -b reduce-timeout master
git pull origin reduce-timeout

2. Adım:

Forgejo'daki değişiklikleri ve güncellemeleri birleştirin.
git checkout master
git merge --no-ff reduce-timeout
git push origin master
Bu konuşmaya katılmak için oturum aç.
Değerlendirici yok
Kilometre Taşı Yok
Atanan Kişi Yok
2 Katılımcı
Bildirimler
Bitiş Tarihi
Bitiş tarihi geçersiz veya aralık dışında. Lütfen 'yyyy-aa-gg' biçimini kullanın.

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Referans: Plume/Plume#557
Yükleniyor…
Henüz bir içerik yok.