Plume/Plume
9
18
Fork 24
Code Issues 178 Pull requests 8 Releases 8 Wiki Activity

bump rust edition to 2018 #563

Closed
trinity-1686a wants to merge 5 commits from edition-2018 into master
pull from: edition-2018
merge into: Plume:master
Conversation 2 Commits 5 Files changed 114 +429 -539
trinity-1686a commented 2019-05-04 15:12:59 +00:00
Owner
Copy link

fix #423

fix #423
elegaanz (Migrated from github.com) reviewed 2019-05-04 15:26:05 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

Nice!

Nice!
codecov[bot] commented 2019-05-04 20:30:53 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #563 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
- Coverage   35.05%   35.04%   -0.01%     
==========================================
  Files          67       67              
  Lines        7834     7833       -1     
  Branches     1877     1879       +2     
==========================================
- Hits         2746     2745       -1     
- Misses       4331     4332       +1     
+ Partials      757      756       -1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/563?src=pr&el=h1) Report > Merging [#563](https://codecov.io/gh/Plume-org/Plume/pull/563?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/918bda14ececc7f72b5741896c2c7ca8fba114f9?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `33.33%`. ```diff @@ Coverage Diff @@ ## master #563 +/- ## ========================================== - Coverage 35.05% 35.04% -0.01% ========================================== Files 67 67 Lines 7834 7833 -1 Branches 1877 1879 +2 ========================================== - Hits 2746 2745 -1 - Misses 4331 4332 +1 + Partials 757 756 -1 ```
elegaanz (Migrated from github.com) approved these changes 2019-05-11 15:24:28 +00:00
trinity-1686a commented 2019-06-15 20:40:26 +00:00
Author
Owner
Copy link

this diverged to much form master to have any hope of clean merge, when I'll get time I'll do it again from scratch

this diverged to much form master to have any hope of clean merge, when I'll get time I'll do it again from scratch
👍 2 😕 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
elegaanz
Labels
Clear labels   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#563
No description provided.
Delete branch "edition-2018"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?