#568 use openssl instead of sha256sum for build.rs

Merged
Plume_migration_agent merged 2 commits from openssl into master 1 year ago

fix #566

fix #566
igalic (Migrated from github.com) reviewed 1 year ago
igalic (Migrated from github.com) left a comment

👀

Plume_migration_agent commented 1 year ago

i’d prefer we leave stat(1) out of this, as the --printf option is not platform independent, and no equivalent, platform independent option exists

the only other would be to use -c

i'd prefer we leave `stat(1)` out of this, as the `--printf` option is not platform independent, and no equivalent, platform independent option exists the only other would be to use `-c`
trinity-1686a reviewed 1 year ago
trinity-1686a commented 1 year ago

The goal of this function is to have a unique id, and best effort is made to not invalidate cache if not necessary. We can also not make that best effort (recompiling Plume => new cache id) and just generate a random hex string. That would be platform independent.
What shall I do?

The goal of this function is to have a unique id, and best effort is made to not invalidate cache if not necessary. We can also not make that best effort (recompiling Plume => new cache id) and just generate a random hex string. That would be platform independent. What shall I do?
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #568 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #568   +/-   ##
=======================================
  Coverage   35.06%   35.06%           
=======================================
  Files          67       67           
  Lines        7851     7851           
  Branches     1886     1886           
=======================================
  Hits         2753     2753           
  Misses       4336     4336           
  Partials      762      762
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/568?src=pr&el=h1) Report > Merging [#568](https://codecov.io/gh/Plume-org/Plume/pull/568?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33619abdfbe1845f56d283265bae2e3e68ad0485?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #568 +/- ## ======================================= Coverage 35.06% 35.06% ======================================= Files 67 67 Lines 7851 7851 Branches 1886 1886 ======================================= Hits 2753 2753 Misses 4336 4336 Partials 762 762 ```
igalic (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

i think i’d just go with stat -c for now

there’s not a big chance we’ll be building on windows… easily… i think, so let’s just go with this.

i think i'd just go with `stat -c` for now there's not a big chance we'll be building on windows… easily… i think, so let's just go with this.
igalic (Migrated from github.com) approved these changes 1 year ago
igalic (Migrated from github.com) left a comment

tested, works!

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 5b50f90d2b.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.