use openssl instead of sha256sum for build.rs #568

Sapludināts

Plume_migration_agent sapludināja 2 revīzijas no openssl uz master

trinity-1686a " komentēja "

Īpašnieks

fix #566

igalic (Migrēts no github.com) recenzēja

igalic (Migrēts no github.com) atstāja komentāru

👀

build.rs

igalic (Migrēts no github.com) " komentēja "

i'd prefer we leave stat(1) out of this, as the --printf option is not platform independent, and no equivalent, platform independent option exists

the only other would be to use -c

i'd prefer we leave `stat(1)` out of this, as the `--printf` option is not platform independent, and no equivalent, platform independent option exists the only other would be to use `-c`

trinity-1686a recenzēja

build.rs

trinity-1686a " komentēja "

Autors

Īpašnieks

The goal of this function is to have a unique id, and best effort is made to not invalidate cache if not necessary. We can also not make that best effort (recompiling Plume => new cache id) and just generate a random hex string. That would be platform independent.
What shall I do?

codecov[bot] " komentēja " (Migrēts no github.com)

Codecov Report

Merging #568 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #568   +/-   ##
=======================================
  Coverage   35.06%   35.06%           
=======================================
  Files          67       67           
  Lines        7851     7851           
  Branches     1886     1886           
=======================================
  Hits         2753     2753           
  Misses       4336     4336           
  Partials      762      762

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/568?src=pr&el=h1) Report > Merging [#568](https://codecov.io/gh/Plume-org/Plume/pull/568?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33619abdfbe1845f56d283265bae2e3e68ad0485?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #568 +/- ## ======================================= Coverage 35.06% 35.06% ======================================= Files 67 67 Lines 7851 7851 Branches 1886 1886 ======================================= Hits 2753 2753 Misses 4336 4336 Partials 762 762 ```

igalic (Migrēts no github.com) recenzēja

build.rs

igalic (Migrēts no github.com) " komentēja "

i think i'd just go with stat -c for now

there's not a big chance we'll be building on windows… easily… i think, so let's just go with this.

i think i'd just go with `stat -c` for now there's not a big chance we'll be building on windows… easily… i think, so let's just go with this.

igalic (Migrēts no github.com) apstiprināja izmaiņas

igalic (Migrēts no github.com) atstāja komentāru

tested, works!

Recenzenti

Izmaiņu pieprasījums tika sapludināts ar revīziju 5b50f90d2b.

Varat aplūkot arī komandrindas instrukcijas.

Solis 1:

Projekta repozitorijā izveidojiet jaunu jaunu atzaru un pārbaudiet savas izmaiņas.

git checkout -b openssl master

git pull origin openssl

Solis 2:

Sapludināt izmaiņas un atjaunot tās Forgejo.

git checkout master

git merge --no-ff openssl

git push origin master

Pierakstieties, lai pievienotos šai sarunai.

Nav recenzentu

Nav atskaites punktu

Nav atbildīgo

2 dalībnieki

Paziņojumi

Izpildes termiņš

Datums līdz nav korekts. Izmantojiet formātu 'gggg-mm-dd'.

Izpildes termiņš nav uzstādīts.

Atkarības

Nav atkarību.

Notiek ielāde…

Vēl nav satura.

Etiķetes Atskaites punkti

use openssl instead of sha256sum for build.rs #568

Codecov Report

Recenzenti

Solis 1:

Solis 2: