use openssl instead of sha256sum for build.rs #568

已合并
Plume_migration_agent 5 年前 将 2 次代码提交从 openssl 合并至 master
所有者

fix #566

fix #566
igalic (从 github.com 迁移) 评审于 5 年前
igalic (从 github.com 迁移) 留下了一条评论

👀

👀
igalic (从 github.com 迁移) 评论于 5 年前

i'd prefer we leave stat(1) out of this, as the --printf option is not platform independent, and no equivalent, platform independent option exists

the only other would be to use -c

i'd prefer we leave `stat(1)` out of this, as the `--printf` option is not platform independent, and no equivalent, platform independent option exists the only other would be to use `-c`
trinity-1686a 评审于 5 年前
发布者
所有者

The goal of this function is to have a unique id, and best effort is made to not invalidate cache if not necessary. We can also not make that best effort (recompiling Plume => new cache id) and just generate a random hex string. That would be platform independent.
What shall I do?

The goal of this function is to have a unique id, and best effort is made to not invalidate cache if not necessary. We can also not make that best effort (recompiling Plume => new cache id) and just generate a random hex string. That would be platform independent. What shall I do?
codecov[bot] 评论于 5 年前 (从 github.com 迁移)

Codecov Report

Merging #568 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #568   +/-   ##
=======================================
  Coverage   35.06%   35.06%           
=======================================
  Files          67       67           
  Lines        7851     7851           
  Branches     1886     1886           
=======================================
  Hits         2753     2753           
  Misses       4336     4336           
  Partials      762      762
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/568?src=pr&el=h1) Report > Merging [#568](https://codecov.io/gh/Plume-org/Plume/pull/568?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33619abdfbe1845f56d283265bae2e3e68ad0485?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #568 +/- ## ======================================= Coverage 35.06% 35.06% ======================================= Files 67 67 Lines 7851 7851 Branches 1886 1886 ======================================= Hits 2753 2753 Misses 4336 4336 Partials 762 762 ```
igalic (从 github.com 迁移) 评审于 5 年前
igalic (从 github.com 迁移) 评论于 5 年前

i think i'd just go with stat -c for now

there's not a big chance we'll be building on windows… easily… i think, so let's just go with this.

i think i'd just go with `stat -c` for now there's not a big chance we'll be building on windows… easily… i think, so let's just go with this.
igalic (从 github.com 迁移)5 年前 批准此合并请求
igalic (从 github.com 迁移) 留下了一条评论

tested, works!

tested, works!

评审人

该合并请求已作为 5b50f90d2b 被合并。
你也可以查看 命令行指令

第一步:

从你的仓库中签出一个新的分支并测试变更。
git checkout -b openssl master
git pull origin openssl

第二步:

合并变更并更新到 Forgejo 上
git checkout master
git merge --no-ff openssl
git push origin master
登录 并参与到对话中。
无审核者
未选择里程碑
未指派成员
2 名参与者
通知
到期时间
到期日期无效或超出范围。请使用 'yyyy-mm-dd' 格式。

未设置到期时间。

依赖工单

没有设置依赖项。

参考:Plume/Plume#568
正在加载...
这个人很懒,什么都没留下。