Plume
/
Plume
8
16
Forka 22
Codice Problemi 174 Pull Requests 8 Rilasci 8 Wiki Attività

Etichette Traguardi

upload artifact of wasm binary #571

Unito
Plume_migration_agent ha unito 1 commit da wasm-artifact a master 5 anni fa
Conversazione 1 Commit 1 File modificati 2
trinity-1686a 5 anni fa ha commentato
Proprietario

fix #570

fix #570
igalic (Migrato da github.com) revisionato 5 anni fa
igalic (Migrato da github.com) lascia un commento

👀

👀
.circleci/config.yml
@ -218,1 +218,4 @@
destination: plume.tar.gz
- store_artifacts:
path: wasm.tar.gz
destination: wasm.tar.gz
igalic (Migrato da github.com) 5 anni fa ha commentato

and as such, I'd just call it static.tar.gz

(should this have a version number)

and as such, I'd just call it static.tar.gz (should this have a version number)
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
igalic (Migrato da github.com) 5 anni fa ha commentato

this one should be with migrations/$FEATURES, and without static/

this one should be with `migrations/$FEATURES`, and without `static/`
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
igalic (Migrato da github.com) 5 anni fa ha commentato

This one, should contain all of static/ — it's entirely architecture independent!

This one, should contain all of `static/` — it's entirely architecture independent!
trinity-1686a revisionato 5 anni fa
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
trinity-1686a 5 anni fa ha commentato
Autore
Proprietario

migrations don't require to be shipped as they are integrated into plm, and I think it should be with static/ so that for x86_64 users, there is only a single archive to download, un-tgz, and run

migrations don't require to be shipped as they are integrated into `plm`, and I think it should be with `static/` so that for x86_64 users, there is only a single archive to download, un-tgz, and run
codecov[bot] 5 anni fa ha commentato (Migrato da github.com)

Codecov Report

Merging #571 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   35.06%   35.06%           
=======================================
  Files          67       67           
  Lines        7851     7851           
  Branches     1886     1886           
=======================================
  Hits         2753     2753           
  Misses       4336     4336           
  Partials      762      762
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/571?src=pr&el=h1) Report > Merging [#571](https://codecov.io/gh/Plume-org/Plume/pull/571?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33619abdfbe1845f56d283265bae2e3e68ad0485?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #571 +/- ## ======================================= Coverage 35.06% 35.06% ======================================= Files 67 67 Lines 7851 7851 Branches 1886 1886 ======================================= Hits 2753 2753 Misses 4336 4336 Partials 762 762 ```
trinity-1686a revisionato 5 anni fa
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
trinity-1686a 5 anni fa ha commentato
Autore
Proprietario

I expected it to be an alternative step to all cargo web things in here, in which case it doesn't require the whole static/ dir as it is git cloned. What were your expectations?

I expected it to be an alternative step to all `cargo web` things in [here](https://docs.joinplu.me/installation/with/source-code), in which case it doesn't require the whole `static/` dir as it is `git clone`d. What were your expectations?
igalic (Migrato da github.com) revisionato 5 anni fa
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
igalic (Migrato da github.com) 5 anni fa ha commentato

you are right.

you are right.
igalic (Migrato da github.com) hanno approvato queste modifiche 5 anni fa
igalic (Migrato da github.com) lascia un commento

i thought about this, and come to the conclusion, that you're right
👍

i thought about this, and come to the conclusion, that you're right 👍

Revisori

igalic
La pull request è stata unita come 90f6ef0380.
Puoi anche visualizzare le istruzioni da riga di comando.

Passo 1:

Dal repository del tuo progetto, fai il check out di un nuovo branch e verifica le modifiche.
git checkout -b wasm-artifact master
git pull origin wasm-artifact

Passo 2:

Fai il merge delle modifiche e aggiorna su Forgejo.
git checkout master
git merge --no-ff wasm-artifact
git push origin master
Effettua l'accesso per partecipare alla conversazione.
Revisori
Richiedi revisione
Nessun revisore
igalic
Etichette
Applica etichette
Pulisci le etichette   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Nessuna etichetta
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Traguardo
Imposta traguardo
Milestone pulita
Nessun elemento
Nessuna milestone
Assegnatari
Assegna utenti
Cancella assegnatari
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza
La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: Plume/Plume#571
Scrivi Anteprima
Caricamento…
Annulla
Salva
Non ci sono ancora contenuti.
Elimina branch 'wasm-artifact'

L'eliminazione di un branch è definitiva. È un'operazione che NON PUÒ essere annullata. Continuare?

No
Sì