Plume
/
Plume
8
16
派生 22
代码 工单 174 合并请求 8 版本发布 8 百科 动态

标签 里程碑

upload artifact of wasm binary #571

已合并
Plume_migration_agent 于 5 年前 将 1 次代码提交从 wasm-artifact 合并至 master
对话内容 1 代码提交 1 文件变动 2
trinity-1686a 评论于 5 年前
所有者

fix #570

fix #570
igalic (从 github.com 迁移) 评审于 5 年前
igalic (从 github.com 迁移) 留下了一条评论

👀

👀
.circleci/config.yml
@ -218,1 +218,4 @@
destination: plume.tar.gz
- store_artifacts:
path: wasm.tar.gz
destination: wasm.tar.gz
igalic (从 github.com 迁移) 评论于 5 年前

and as such, I'd just call it static.tar.gz

(should this have a version number)

and as such, I'd just call it static.tar.gz (should this have a version number)
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
igalic (从 github.com 迁移) 评论于 5 年前

this one should be with migrations/$FEATURES, and without static/

this one should be with `migrations/$FEATURES`, and without `static/`
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
igalic (从 github.com 迁移) 评论于 5 年前

This one, should contain all of static/ — it's entirely architecture independent!

This one, should contain all of `static/` — it's entirely architecture independent!
trinity-1686a 评审于 5 年前
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
trinity-1686a 评论于 5 年前
发布者
所有者

migrations don't require to be shipped as they are integrated into plm, and I think it should be with static/ so that for x86_64 users, there is only a single archive to download, un-tgz, and run

migrations don't require to be shipped as they are integrated into `plm`, and I think it should be with `static/` so that for x86_64 users, there is only a single archive to download, un-tgz, and run
codecov[bot] 评论于 5 年前 (从 github.com 迁移)

Codecov Report

Merging #571 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   35.06%   35.06%           
=======================================
  Files          67       67           
  Lines        7851     7851           
  Branches     1886     1886           
=======================================
  Hits         2753     2753           
  Misses       4336     4336           
  Partials      762      762
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/571?src=pr&el=h1) Report > Merging [#571](https://codecov.io/gh/Plume-org/Plume/pull/571?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33619abdfbe1845f56d283265bae2e3e68ad0485?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #571 +/- ## ======================================= Coverage 35.06% 35.06% ======================================= Files 67 67 Lines 7851 7851 Branches 1886 1886 ======================================= Hits 2753 2753 Misses 4336 4336 Partials 762 762 ```
trinity-1686a 评审于 5 年前
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
trinity-1686a 评论于 5 年前
发布者
所有者

I expected it to be an alternative step to all cargo web things in here, in which case it doesn't require the whole static/ dir as it is git cloned. What were your expectations?

I expected it to be an alternative step to all `cargo web` things in [here](https://docs.joinplu.me/installation/with/source-code), in which case it doesn't require the whole `static/` dir as it is `git clone`d. What were your expectations?
igalic (从 github.com 迁移) 评审于 5 年前
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
igalic (从 github.com 迁移) 评论于 5 年前

you are right.

you are right.
igalic (从 github.com 迁移) 于 5 年前 批准此合并请求
igalic (从 github.com 迁移) 留下了一条评论

i thought about this, and come to the conclusion, that you're right
👍

i thought about this, and come to the conclusion, that you're right 👍

评审人

igalic
该合并请求已作为 90f6ef0380 被合并。
你也可以查看 命令行指令

第一步:

从你的仓库中签出一个新的分支并测试变更。
git checkout -b wasm-artifact master
git pull origin wasm-artifact

第二步：

合并变更并更新到 Forgejo 上
git checkout master
git merge --no-ff wasm-artifact
git push origin master
登录 并参与到对话中。
评审人
请求审核
无审核者
igalic
标签
添加标签
清除选中标签   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
未选择标签
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
里程碑
设置里程碑
取消选中里程碑
无可选项
未选择里程碑
指派成员
指派用户
取消指派成员
未指派成员
2 名参与者
通知
到期时间
到期日期无效或超出范围。请使用 'yyyy-mm-dd' 格式。

未设置到期时间。

依赖工单

没有设置依赖项。

参考：Plume/Plume#571
撰写 预览
正在加载...
取消
保存
这个人很懒，什么都没留下。
删除分支 'wasm-artifact'

删除分支是永久的。此操作 无法 撤销，继续？

取消操作
确认操作