Fix some federation issue #573

Merged

Plume_migration_agent merged 6 commits from fix/minor-federation-issue into master

trinity-1686a commented

Owner

The issue in #567 will be a bit tougher than initially expected. Pterotype seems to use Organization instead of plain User for federation, so there is the question how do we manage that? How do we treat that? As users I expect, but it will require some changes to do so, or as something else?

elegaanz commented (Migrated from github.com)

A post must have an associated blog, but it technically can have no author. So I would say Organizations should be treated as blogs.

You can probably create a type that implements AsActor and the different AsObject, but that actually delegates the work to Blog? I don't know.

A post must have an associated blog, but it technically can have no author. So I would say Organizations should be treated as blogs. You can probably create a type that implements `AsActor` and the different `AsObject`, but that actually delegates the work to `Blog`? I don't know.

👍 1

trinity-1686a commented

Poster

Owner

atm a post can't really have no authors : in multiple places assumption is made that there is at least one author, and we can use posts.get_authors()?[0] safely. There will be things to change if we introduce the possibility of a post without authors. Also as one can't follow a blog yet, this would mean a basic feature is lacking. The more I think about it, the more problematic it get

atm a post can't really have no authors : in multiple places assumption is made that there is at least one author, and we can use `posts.get_authors()?[0]` safely. There will be things to change if we introduce the possibility of a post without authors. Also as one can't follow a blog yet, this would mean a basic feature is lacking. The more I think about it, the more problematic it get

codecov[bot] commented (Migrated from github.com)

Codecov Report

Merging #573 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   35.35%   35.35%   -0.01%     
==========================================
  Files          68       68              
  Lines        7914     7915       +1     
  Branches     1893     1894       +1     
==========================================
  Hits         2798     2798              
- Misses       4340     4341       +1     
  Partials      776      776

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/573?src=pr&el=h1) Report > Merging [#573](https://codecov.io/gh/Plume-org/Plume/pull/573?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c031804464a22c550ff621483811a202ecbb238c?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #573 +/- ## ========================================== - Coverage 35.35% 35.35% -0.01% ========================================== Files 68 68 Lines 7914 7915 +1 Branches 1893 1894 +1 ========================================== Hits 2798 2798 - Misses 4340 4341 +1 Partials 776 776 ```

elegaanz commented (Migrated from github.com)

OK, so then, what about inserting both a blog and an user with the same username when encountering an Organization? It is a bit hackish, but it should work.

Also, we should maybe add a "default" personnal blog for users at some, as I think it is what most people expect (but it may make the whole code a lot more complex too)?

OK, so then, what about inserting both a blog and an user with the same username when encountering an `Organization`? It is a bit hackish, but it should work. Also, we should maybe add a "default" personnal blog for users at some, as I think it is what most people expect (but it may make the whole code a lot more complex too)?

👍 1

marek-lach commented (Migrated from github.com)

This may be useful to cunsult for reference:

https://github.com/w3c/activitypub/issues/260

There may (or may not) be some similarity to this Pleroma issue:

https://git.pleroma.social/pleroma/pleroma/issues/364

This may be useful to _cunsult for reference_: https://github.com/w3c/activitypub/issues/260 There may (or may not) be _some similarity_ to this Pleroma issue: https://git.pleroma.social/pleroma/pleroma/issues/364

marek-lach commented (Migrated from github.com)

@fdb-hiroshima @BaptisteGelez According to the creator of Pterotype, Organization is the entire blog, not a specific user in the current design of the plugin.

I think this may help to shed some light on the issue at hand:
Screenshot 2019-05-16 at 17 12 46

He plans to redesign the federation approach in the future though, and test it against Plume himself then.

@fdb-hiroshima @BaptisteGelez According to the creator of _Pterotype_, `Organization` is the entire blog, not a specific user in the current design of the plugin. I think this may help to shed some light on the issue at hand: <img width="304" alt="Screenshot 2019-05-16 at 17 12 46" src="https://user-images.githubusercontent.com/45913977/57866013-e3472580-77fe-11e9-8166-e96f8632d9c1.png"> He plans to redesign the federation approach in the future though, and test it against Plume himself then.

👍 2

trinity-1686a commented

Poster

Owner

this has been stall for too long. What has been fixed has been fixed, the rest will be at some point in the future

👍 3

elegaanz (Migrated from github.com) reviewed

elegaanz (Migrated from github.com) left a comment

What you have done looks good 👍 If you could just cancel the changes to the translation files (or fix the conflicts with master, but the former is probably easier), we could merge this PR.

What you have done looks good :+1: If you could just cancel the changes to the translation files (or fix the conflicts with master, but the former is probably easier), we could merge this PR.

elegaanz (Migrated from github.com) reviewed

elegaanz commented (Migrated from github.com)

Wait I just realized: do we fetch blogs with the group: prefix in Webfinger now?

Wait I just realized: do we fetch blogs with the `group:` prefix in Webfinger now?

trinity-1686a commented

Poster

Owner

no, we don't 😬

😆 1

elegaanz (Migrated from github.com) approved these changes

elegaanz (Migrated from github.com) left a comment

This time it looks good, thanks!

Reviewers

The pull request has been merged as 4f7c20fc26.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b fix/minor-federation-issue master

git pull origin fix/minor-federation-issue

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff fix/minor-federation-issue

git push origin master

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Fix some federation issue #573

Codecov Report

Reviewers

Step 1:

Step 2: