Fix some federation issue
#573
Merge aplicado
Plume_migration_agent
aplicou merge dos 6 commits de fix/minor-federation-issue
em master
5 anos atrás
Revisores
Solicitar revisão
Sem revisor
Etiquetas
Limpar etiquetas
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Aplicar etiquetas
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
Sem etiqueta
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Marco
Definir marco
Limpar marco
Nenhum item
Sem marco
Responsáveis
Atribuir usuários
Limpar responsáveis
Sem responsável
2 participante(s)
Notificações
Data limite
A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.
Data limite não informada.
Dependências
Nenhuma dependência definida.
Referência: Plume/Plume#573
Referência em uma nova issue
Ainda não há conteúdo.
Excluir Branch 'fix/minor-federation-issue'
A exclusão de um branch é permanente. Isto NÃO PODERÁ ser desfeito. Continuar?
Não
Sim
The issue in #567 will be a bit tougher than initially expected. Pterotype seems to use Organization instead of plain User for federation, so there is the question how do we manage that? How do we treat that? As users I expect, but it will require some changes to do so, or as something else?
A post must have an associated blog, but it technically can have no author. So I would say Organizations should be treated as blogs.
You can probably create a type that implements
AsActor
and the differentAsObject
, but that actually delegates the work toBlog
? I don't know.atm a post can't really have no authors : in multiple places assumption is made that there is at least one author, and we can use
posts.get_authors()?[0]
safely. There will be things to change if we introduce the possibility of a post without authors. Also as one can't follow a blog yet, this would mean a basic feature is lacking. The more I think about it, the more problematic it getCodecov Report
OK, so then, what about inserting both a blog and an user with the same username when encountering an
Organization
? It is a bit hackish, but it should work.Also, we should maybe add a "default" personnal blog for users at some, as I think it is what most people expect (but it may make the whole code a lot more complex too)?
This may be useful to cunsult for reference:
https://github.com/w3c/activitypub/issues/260
There may (or may not) be some similarity to this Pleroma issue:
https://git.pleroma.social/pleroma/pleroma/issues/364
@fdb-hiroshima @BaptisteGelez According to the creator of Pterotype,
Organization
is the entire blog, not a specific user in the current design of the plugin.I think this may help to shed some light on the issue at hand:
He plans to redesign the federation approach in the future though, and test it against Plume himself then.
this has been stall for too long. What has been fixed has been fixed, the rest will be at some point in the future
What you have done looks good 👍 If you could just cancel the changes to the translation files (or fix the conflicts with master, but the former is probably easier), we could merge this PR.
Wait I just realized: do we fetch blogs with the
group:
prefix in Webfinger now?no, we don't 😬
This time it looks good, thanks!
Revisores
4f7c20fc26
.Passo 1:
No repositório do seu projeto, crie um novo branch e teste as alterações.Passo 2:
Faça merge das alterações e atualize no Forgejo.