WIP - initial RTL support #575 #577

已合併

ahangarha 將 9 次提交從 add-rtl-support 合併至 master

ahangarha 已留言 (已從 github.com 遷移)

In regard to #575, few fixes have been done so far. Yet, there are many others to be made, including:

BIDI to be applied to form fields (which are rendered dynamically)
fix css styles and remove text-align, modify margin/madding left/right
BIDI to be applied to every elements inside article for post content

In regard to #575, few fixes have been done so far. Yet, there are many others to be made, including: - [x] BIDI to be applied to form fields (which are rendered dynamically) - [ ] fix css styles and remove text-align, modify margin/madding left/right - [ ] BIDI to be applied to every elements inside article for post content

🎉 4

trinity-1686a 已留言

擁有者

if you want to tinker that, forms are rendered using what's in src/template_utils.rs on line 241-249 and 335-336

if you want to tinker that, forms are rendered using what's in `src/template_utils.rs` on line 241-249 and 335-336

👍 1

codecov[bot] 已留言 (已從 github.com 遷移)

Codecov Report

Merging #577 into master will decrease coverage by 0.76%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   35.28%   34.51%   -0.77%     
==========================================
  Files          68       67       -1     
  Lines        7899     7872      -27     
  Branches     1891     1890       -1     
==========================================
- Hits         2787     2717      -70     
- Misses       4334     4394      +60     
+ Partials      778      761      -17

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/577?src=pr&el=h1) Report > Merging [#577](https://codecov.io/gh/Plume-org/Plume/pull/577?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c031804464a22c550ff621483811a202ecbb238c?src=pr&el=desc) will **decrease** coverage by `0.76%`. > The diff coverage is `50%`. ```diff @@ Coverage Diff @@ ## master #577 +/- ## ========================================== - Coverage 35.28% 34.51% -0.77% ========================================== Files 68 67 -1 Lines 7899 7872 -27 Branches 1891 1890 -1 ========================================== - Hits 2787 2717 -70 - Misses 4334 4394 +60 + Partials 778 761 -17 ```

ahangarha 已留言 (已從 github.com 遷移)

if you want to tinker that, forms are rendered using what's in src/template_utils.rs on line 241-249 and 335-336

this was really helpful. I made changes and pushed it up. CI ended in failure. was it because of my changes?

> if you want to tinker that, forms are rendered using what's in `src/template_utils.rs` on line 241-249 and 335-336 this was really helpful. I made changes and pushed it up. CI ended in failure. was it because of my changes?

elegaanz 已留言 (已從 github.com 遷移)

No it was not your fault, CI fails for no good reasons sometimes. I restarted the failed job, let's hope it will work this time.

👍 1

trinity-1686a 已留言

擁有者

BIDI to be applied to form fields (which are rendered dynamically)

fix css styles and remove text-align, modify margin/madding left/right

BIDI to be applied to every elements inside article for post content

I've merged master back to this branch, would you like to work on fixing css before we merge this, or can we merge it, and this would be for a further pr?

> * [x] BIDI to be applied to form fields (which are rendered dynamically) > * [ ] fix css styles and remove text-align, modify margin/madding left/right > * [ ] BIDI to be applied to every elements inside article for post content I've merged master back to this branch, would you like to work on fixing css before we merge this, or can we merge it, and this would be for a further pr?

👍 1

ahangarha 已留言 (已從 github.com 遷移)

It you don't mind, merge it. I will send another PR for the following improvements.

👍 1

trinity-1686a 核可了這些變更

trinity-1686a 留下了回應

擁有者

👍

:+1:

審核者

trinity-1686a 核可了這些變更

此合併請求已被合併為 54c6d21fc5。

您也可以查看命令列指南。

第一步：

在您的儲存庫中切換到新分支並測試變更。

git checkout -b add-rtl-support master

git pull origin add-rtl-support

第二步：

合併變更並更新到 Forgejo。

git checkout master

git merge --no-ff add-rtl-support

git push origin master

登入才能加入這對話。

沒有審核者

未選擇里程碑

沒有負責人

2 參與者

通知

截止日期

截止日期無效或超出範圍，請使用「yyyy-mm-dd」的格式。

未設定截止日期。

先決條件

未設定先決條件。

載入中…

尚未有任何內容

標籤 里程碑

WIP - initial RTL support #575 #577

Codecov Report

審核者

第一步：

第二步：

標籤里程碑