refactor code to use Shrinkwraprs and diesel-derive-newtype #598

Обединени
igalic обедини 6 ревизии от refactor/shrinkwraps във master преди 5 години
igalic коментира преди 5 години (Migrated from github.com)

Reduce a lot of our own boilerplate with these two crates.
This fixes #597.

Reduce a lot of our own boilerplate with these two crates. This fixes #597.
codecov[bot] коментира преди 5 години (Migrated from github.com)

Codecov Report

Merging #598 into master will increase coverage by 0.09%.
The diff coverage is 16.66%.

@@            Coverage Diff            @@
##           master    #598      +/-   ##
=========================================
+ Coverage    34.5%   34.6%   +0.09%     
=========================================
  Files          67      67              
  Lines        7876    7840      -36     
  Branches     1890    1883       -7     
=========================================
- Hits         2718    2713       -5     
+ Misses       4398    4367      -31     
  Partials      760     760
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/598?src=pr&el=h1) Report > Merging [#598](https://codecov.io/gh/Plume-org/Plume/pull/598?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/59023e96023405847b3a91658e0adffecceb993d?src=pr&el=desc) will **increase** coverage by `0.09%`. > The diff coverage is `16.66%`. ```diff @@ Coverage Diff @@ ## master #598 +/- ## ========================================= + Coverage 34.5% 34.6% +0.09% ========================================= Files 67 67 Lines 7876 7840 -36 Branches 1890 1883 -7 ========================================= - Hits 2718 2713 -5 + Misses 4398 4367 -31 Partials 760 760 ```
elegaanz (Migrated from github.com) reviewed преди 5 години
@ -140,26 +140,12 @@ impl FromId<PlumeRocket> for Reshare {
let res = Reshare::insert(
&c.conn,
NewReshare {
elegaanz (Migrated from github.com) коментира преди 5 години

I think you can even replace this block with just &act.announce_props.object_link::<Id>()?, it was only here to be able to convert the Id to a String (and same for other similar blocks).

I think you can even replace this block with just `&act.announce_props.object_link::<Id>()?`, it was only here to be able to convert the Id to a String (and same for other similar blocks).
trinity-1686a approved these changes преди 5 години

Reviewers

trinity-1686a approved these changes преди 5 години
Тази заявка за сливане е била обединена като 8c59c822b6.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b refactor/shrinkwraps master
git pull origin refactor/shrinkwraps

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff refactor/shrinkwraps
git push origin master
Впишете се за да се присъедините към разговора.
No reviewers
Няма етап
Няма изпълнители
2 участника
Известия
Due Date
Крайният срок е невалиден или извън обхват. Моля използвайте форматът 'гггг-мм-дд'.

No due date set.

Зависимости

No dependencies set.

Reference: Plume/Plume#598
Зареждане…
Все още няма съдържание.