Plume
/
Plume
8
16
Fork 22
Código Issues 174 Pull requests 8 Versões 8 Wiki Atividade

Etiquetas Marcos

refactor code to use Shrinkwraprs and diesel-derive-newtype #598

Merge aplicado
igalic aplicou merge dos 6 commits de refactor/shrinkwraps em master 5 anos atrás
Conversação 1 Commits 6 Arquivos alterados 38
igalic comentou 5 anos atrás (Migrado de github.com)

Reduce a lot of our own boilerplate with these two crates.
This fixes #597.

Reduce a lot of our own boilerplate with these two crates. This fixes #597.
👍 1 ❤️ 1
codecov[bot] comentou 5 anos atrás (Migrado de github.com)

Codecov Report

Merging #598 into master will increase coverage by 0.09%.
The diff coverage is 16.66%.

@@            Coverage Diff            @@
##           master    #598      +/-   ##
=========================================
+ Coverage    34.5%   34.6%   +0.09%     
=========================================
  Files          67      67              
  Lines        7876    7840      -36     
  Branches     1890    1883       -7     
=========================================
- Hits         2718    2713       -5     
+ Misses       4398    4367      -31     
  Partials      760     760
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/598?src=pr&el=h1) Report > Merging [#598](https://codecov.io/gh/Plume-org/Plume/pull/598?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/59023e96023405847b3a91658e0adffecceb993d?src=pr&el=desc) will **increase** coverage by `0.09%`. > The diff coverage is `16.66%`. ```diff @@ Coverage Diff @@ ## master #598 +/- ## ========================================= + Coverage 34.5% 34.6% +0.09% ========================================= Files 67 67 Lines 7876 7840 -36 Branches 1890 1883 -7 ========================================= - Hits 2718 2713 -5 + Misses 4398 4367 -31 Partials 760 760 ```
elegaanz (Migrado de github.com) revisou 5 anos atrás
plume-models/src/reshares.rs
@ -140,26 +140,12 @@ impl FromId<PlumeRocket> for Reshare {
let res = Reshare::insert(
&c.conn,
NewReshare {
elegaanz (Migrado de github.com) comentou 5 anos atrás

I think you can even replace this block with just &act.announce_props.object_link::<Id>()?, it was only here to be able to convert the Id to a String (and same for other similar blocks).

I think you can even replace this block with just `&act.announce_props.object_link::<Id>()?`, it was only here to be able to convert the Id to a String (and same for other similar blocks).
trinity-1686a aprovou estas alterações 5 anos atrás

Revisores

trinity-1686a aprovou estas alterações 5 anos atrás
O pull request teve merge aplicado como 8c59c822b6.
Você também pode ver as instruções para a linha de comandos.

Passo 1:

No repositório do seu projeto, crie um novo branch e teste as alterações.
git checkout -b refactor/shrinkwraps master
git pull origin refactor/shrinkwraps

Passo 2:

Faça merge das alterações e atualize no Forgejo.
git checkout master
git merge --no-ff refactor/shrinkwraps
git push origin master
Acesse para participar desta conversação.
Revisores
Solicitar revisão
Sem revisor
trinity-1686a
Etiquetas
Aplicar etiquetas
Limpar etiquetas   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Sem etiqueta
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Marco
Definir marco
Limpar marco
Nenhum item
Sem marco
Responsáveis
Atribuir usuários
Limpar responsáveis
Sem responsável
2 participante(s)
Notificações
Data limite
A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: Plume/Plume#598
Escrever Pré-visualização
Carregando…
Cancelar
Salvar
Ainda não há conteúdo.
Excluir Branch 'refactor/shrinkwraps'

A exclusão de um branch é permanente. Isto NÃO PODERÁ ser desfeito. Continuar?

Não
Sim