Confirm deletion of blog #602

Zusammengeführt

rfwatson hat 1 Commit von feature/confirm_delete_blog nach master 2019-05-29 12:51:53 +00:00 zusammengeführt

rfwatson hat

2019-05-28 20:00:35 +00:00

kommentiert (Migriert von github.com)

Closes #601.

Ideally I'd like a less generic confirmation message - Are you sure you want to permanently delete this blog?. But assuming this won't be possible without new translations, I feel that it's probably not worth it. Thoughts welcome.

Closes #601. ~Ideally I'd like a less generic confirmation message - _Are you sure you want to permanently delete this blog?_. But assuming this won't be possible without new translations, I feel that it's probably not worth it. Thoughts welcome.~

👍 1 ❤️ 1

rfwatson hat

2019-05-28 20:46:03 +00:00

kommentiert (Migriert von github.com)

Not sure why the CI is failing

elegaanz (Migriert von github.com) hat 2019-05-28 21:13:44 +00:00 gereviewt

elegaanz (Migriert von github.com) hat einen Kommentar hinterlassen

Hello and thanks for your PR! Don't hesitate to change the message if you feel to do so, having one more string to translate is not a problem at all.

And the reason the CI fails is that it takes a lot of memory to compile Plume, and sometimes Circle CI containers just don't give us enough… so Rust is killed by the OOM-killer (so nothing to do with your code, it may work next time).

Otherwise, it works just fine. Thank you again!

Hello and thanks for your PR! Don't hesitate to change the message if you feel to do so, having one more string to translate is not a problem at all. And the reason the CI fails is that it takes a lot of memory to compile Plume, and sometimes Circle CI containers just don't give us enough… so Rust is killed by the OOM-killer (so nothing to do with your code, it may work next time). Otherwise, it works just fine. Thank you again!

rfwatson hat

2019-05-28 22:49:05 +00:00

kommentiert (Migriert von github.com)

Thanks!

Looking at the previous commits, would you recommend going on Crowdin directly to generate new translations?

I’ll play with this further tomorrow.

Thanks! Looking at the previous commits, would you recommend going on Crowdin directly to generate new translations? I’ll play with this further tomorrow.

elegaanz hat

2019-05-29 11:28:07 +00:00

kommentiert (Migriert von github.com)

You don't need to go on Crowdin to add translations: any string written in the i18n! macro is uploaded there automatically, and can then be translated (once your PR is merged, of course).

You don't need to go on Crowdin to add translations: any string written in the `i18n!` macro is uploaded there automatically, and can then be translated (once your PR is merged, of course).

codecov[bot] hat

2019-05-29 12:36:41 +00:00

kommentiert (Migriert von github.com)

Codecov Report

Merging #602 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #602      +/-   ##
=========================================
+ Coverage   34.54%   34.6%   +0.06%     
=========================================
  Files          67      67              
  Lines        7825    7840      +15     
  Branches     1881    1883       +2     
=========================================
+ Hits         2703    2713      +10     
- Misses       4361    4367       +6     
+ Partials      761     760       -1

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/602?src=pr&el=h1) Report > Merging [#602](https://codecov.io/gh/Plume-org/Plume/pull/602?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/037674ae13849fb1f6357fd8a8b03ce8c7eda853?src=pr&el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #602 +/- ## ========================================= + Coverage 34.54% 34.6% +0.06% ========================================= Files 67 67 Lines 7825 7840 +15 Branches 1881 1883 +2 ========================================= + Hits 2703 2713 +10 - Misses 4361 4367 +6 + Partials 761 760 -1 ```

rfwatson hat

2019-05-29 12:38:23 +00:00

kommentiert (Migriert von github.com)

You don't need to go on Crowdin to add translations: any string written in the i18n! macro is uploaded there automatically

Oh nice 😃

In that case I've updated this PR, and opened another to clarify the docs.

> You don't need to go on Crowdin to add translations: any string written in the i18n! macro is uploaded there automatically Oh nice :smiley: In that case I've updated this PR, and opened another to clarify the docs.

👍 1 ❤️ 1

elegaanz hat

2019-05-29 12:48:45 +00:00

kommentiert (Migriert von github.com)

Thank you again!

elegaanz (Migriert von github.com) hat die Änderungen 2019-05-29 12:49:22 +00:00 genehmigt

Anmelden, um an der Diskussion teilzunehmen.

Keine Reviewer

elegaanz