Confirm deletion of blog
#602
Zusammengeführt
rfwatson
hat 1 Commits von feature/confirm_delete_blog
nach master
vor 5 Jahren zusammengeführt
Laden…
In neuem Issue referenzieren
Hier gibt es bis jetzt noch keinen Inhalt.
Branch „feature/confirm_delete_blog“ löschen
Das Löschen eines Branches ist permanent. Es KANN NICHT rückgängig gemacht werden. Fortfahren?
Closes #601.
~Ideally I'd like a less generic confirmation message - Are you sure you want to permanently delete this blog?. But assuming this won't be possible without new translations, I feel that it's probably not worth it. Thoughts welcome.~
Not sure why the CI is failing
Hello and thanks for your PR! Don't hesitate to change the message if you feel to do so, having one more string to translate is not a problem at all.
And the reason the CI fails is that it takes a lot of memory to compile Plume, and sometimes Circle CI containers just don't give us enough… so Rust is killed by the OOM-killer (so nothing to do with your code, it may work next time).
Otherwise, it works just fine. Thank you again!
Thanks!
Looking at the previous commits, would you recommend going on Crowdin directly to generate new translations?
I’ll play with this further tomorrow.
You don't need to go on Crowdin to add translations: any string written in the
i18n!
macro is uploaded there automatically, and can then be translated (once your PR is merged, of course).Codecov Report
Oh nice 😃
In that case I've updated this PR, and opened another to clarify the docs.
Thank you again!
Reviewer
bffce041d7
gemergt.Schritt 1:
Wechsle auf einen neuen Branch in deinem lokalen Repository und teste die Änderungen.Schritt 2:
Führe die Änderungen zusammen und aktualisiere den Stand online auf Forgejo.