Confirm deletion of blog
#602
Fusionnée
rfwatson
a fusionné 1 révision(s) à partir de feature/confirm_delete_blog
vers master
il y a 5 ans
Chargement…
Référencer dans un nouveau ticket
Il n'existe pas encore de contenu.
Supprimer la branche 'feature/confirm_delete_blog'
Supprimer une branche est permanent. Cela NE PEUVENT être annulées. Continuer ?
Closes #601.
~Ideally I'd like a less generic confirmation message - Are you sure you want to permanently delete this blog?. But assuming this won't be possible without new translations, I feel that it's probably not worth it. Thoughts welcome.~
Not sure why the CI is failing
Hello and thanks for your PR! Don't hesitate to change the message if you feel to do so, having one more string to translate is not a problem at all.
And the reason the CI fails is that it takes a lot of memory to compile Plume, and sometimes Circle CI containers just don't give us enough… so Rust is killed by the OOM-killer (so nothing to do with your code, it may work next time).
Otherwise, it works just fine. Thank you again!
Thanks!
Looking at the previous commits, would you recommend going on Crowdin directly to generate new translations?
I’ll play with this further tomorrow.
You don't need to go on Crowdin to add translations: any string written in the
i18n!
macro is uploaded there automatically, and can then be translated (once your PR is merged, of course).Codecov Report
Oh nice 😃
In that case I've updated this PR, and opened another to clarify the docs.
Thank you again!
Relecteurs
bffce041d7
.Étape 1:
Depuis le dépôt de votre projet, sélectionnez une nouvelle branche et testez les modifications.Étape 2:
Fusionner les modifications et mettre à jour sur Forgejo.