Confirm deletion of blog
#602
マージ済み
rfwatson
が 1 個のコミットを feature/confirm_delete_blog
から master
へマージ 5年前
レビューア
レビュー依頼
レビューアなし
ラベル
ラベルをクリア
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
ラベル付け
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
ラベルなし
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
マイルストーン
マイルストーンの設定
マイルストーンをクリア
項目なし
マイルストーンなし
担当者
担当者の割り当て
担当者をクリア
担当者なし
1 人の参加者
通知
期日
期日が正しくないか範囲を超えています。 'yyyy-mm-dd' の形式で入力してください。
期日は未設定です。
依存関係
依存関係が設定されていません。
リファレンス: Plume/Plume#602
新しいイシューから参照
まだ内容がありません
ブランチ 'feature/confirm_delete_blog' の削除
ブランチの削除は恒久的で、元に戻すことはできません。 続行しますか?
いいえ
はい
Closes #601.
~Ideally I'd like a less generic confirmation message - Are you sure you want to permanently delete this blog?. But assuming this won't be possible without new translations, I feel that it's probably not worth it. Thoughts welcome.~
Not sure why the CI is failing
Hello and thanks for your PR! Don't hesitate to change the message if you feel to do so, having one more string to translate is not a problem at all.
And the reason the CI fails is that it takes a lot of memory to compile Plume, and sometimes Circle CI containers just don't give us enough… so Rust is killed by the OOM-killer (so nothing to do with your code, it may work next time).
Otherwise, it works just fine. Thank you again!
Thanks!
Looking at the previous commits, would you recommend going on Crowdin directly to generate new translations?
I’ll play with this further tomorrow.
You don't need to go on Crowdin to add translations: any string written in the
i18n!
macro is uploaded there automatically, and can then be translated (once your PR is merged, of course).Codecov Report
Oh nice 😃
In that case I've updated this PR, and opened another to clarify the docs.
Thank you again!
レビューア
bffce041d7
でマージされています。ステップ 1:
あなたのプロジェクトリポジトリで新しいブランチをチェックアウトし、変更内容をテストします。ステップ 2:
変更内容をマージして、Forgejoに反映します。