Confirm deletion of blog #602
Sem revisor
Etiquetas
Nenhum rótulo
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Sem marco
Sem projeto
Sem responsáveis
1 participante
Notificações
Data limite
Não há data limite definida.
Dependências
Não há dependências definidas.
Referência: Plume/Plume#602
Carregando…
Adicionar tabela
Referência em uma nova issue
Nenhuma descrição fornecida.
Excluir branch "feature/confirm_delete_blog"
Apagar um branch é permanente. Ainda que o branch apagado possa continuar a existir por um breve período antes de ser realmente apagado, isso NÃO PODE ser desfeito na maioria dos casos. Continuar?
Closes #601.
Ideally I'd like a less generic confirmation message - Are you sure you want to permanently delete this blog?. But assuming this won't be possible without new translations, I feel that it's probably not worth it. Thoughts welcome.Not sure why the CI is failing
Hello and thanks for your PR! Don't hesitate to change the message if you feel to do so, having one more string to translate is not a problem at all.
And the reason the CI fails is that it takes a lot of memory to compile Plume, and sometimes Circle CI containers just don't give us enough… so Rust is killed by the OOM-killer (so nothing to do with your code, it may work next time).
Otherwise, it works just fine. Thank you again!
Thanks!
Looking at the previous commits, would you recommend going on Crowdin directly to generate new translations?
I’ll play with this further tomorrow.
You don't need to go on Crowdin to add translations: any string written in the
i18n!
macro is uploaded there automatically, and can then be translated (once your PR is merged, of course).Codecov Report
Oh nice 😃
In that case I've updated this PR, and opened another to clarify the docs.
Thank you again!