add enum containing all successful route returns #614

Fusionnée

igalic a fusionné 10 révision(s) à partir de refactor/route-result vers master

igalic a commenté (Migré de github.com)

This enum derives Responder, so it can be used as route result.
We also implement From, so it can be converted

This pr addresses #613

This enum derives `Responder`, so it can be used as route result. We also implement `From`, so it can be converted This pr addresses #613

codecov[bot] a commenté (Migré de github.com)

Codecov Report

Merging #614 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   35.31%   35.31%           
=======================================
  Files          68       68           
  Lines        7907     7907           
  Branches     1893     1893           
=======================================
  Hits         2792     2792           
  Misses       4345     4345           
  Partials      770      770

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/614?src=pr&el=h1) Report > Merging [#614](https://codecov.io/gh/Plume-org/Plume/pull/614?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/4b205fa995a6935a2512a9725d84635e889db48e?src=pr&el=desc) will **not change** coverage. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #614 +/- ## ======================================= Coverage 35.31% 35.31% ======================================= Files 68 68 Lines 7907 7907 Branches 1893 1893 ======================================= Hits 2792 2792 Misses 4345 4345 Partials 770 770 ```

igalic a commenté (Migré de github.com)

I've marked this pull request now ready for review.
even though there's at least one function left that could be improved (in readability, or at least refractored to use this enum)
but i don't think we can make further strides without improving our ErrorPage

I've marked this pull request now ready for review. even though there's at least one function left that could be improved (in readability, or at least refractored to use this enum) but i don't think we can make further strides without improving our ErrorPage

rfwatson (Migré de github.com) révisé

src/routes/blogs.rs

rfwatson (Migré de github.com) a commenté

So if I read this correctly, the Rust compiler infers the type from the return type of the function, allowing into() to function as expected?

Even though I should probably expect that from Rust, that's still pretty neat.

So if I read this correctly, the Rust compiler infers the type from the return type of the function, allowing `into()` to function as expected? Even though I should probably expect that from Rust, that's still pretty neat.

trinity-1686a révisé

trinity-1686a laisser un commentaire

Propriétaire

👍

:+1:

src/routes/session.rs

trinity-1686a a commenté

Propriétaire

Isn't it a bit strange that when redirecting to invalid uri, it gives an error? It would probably make more sens that the chain on line 100 does the parsing to, and default to parse("/").unwrap(). Also it should probably be a Origin to block redirection to other domain
(this is also true for previous code, it's pretty old, I'm pretty sure we did not do code review last September)

Isn't it a bit strange that when redirecting to invalid uri, it gives an error? It would probably make more sens that the chain on line 100 does the parsing to, and default to `parse("/").unwrap()`. Also it should probably be a [Origin](https://api.rocket.rs/v0.4/rocket/http/uri/struct.Origin.html) to block redirection to other domain (this is also true for previous code, it's pretty old, I'm pretty sure we did not do code review last September)

igalic (Migré de github.com) révisé

src/routes/session.rs

igalic (Migré de github.com) a commenté

do you have a suggestion for improvement?

trinity-1686a révisé

src/routes/session.rs

trinity-1686a a commenté

Propriétaire

I do but I don't know how to explain it with words, so I'll probably do it myself during the week end

trinity-1686a ces changements ont été approuvés

igalic (Migré de github.com) révisé

src/routes/session.rs

igalic (Migré de github.com) a commenté

well, I'll be happy to review it then, and help with words where necessary

i used to be quite good with words, now i'm procrastinating on writing words, by working on a blogging platform.

well, I'll be happy to review it then, and help with words where necessary i used to be quite good with words, now i'm procrastinating on writing words, by working on a blogging platform.

Relecteurs

trinity-1686a ces changements ont été approuvés

La demande d'ajout a été fusionnée en 3d27e283ad.

Vous pouvez également voir les instructions en ligne de commande.

Étape 1:

Depuis le dépôt de votre projet, sélectionnez une nouvelle branche et testez les modifications.

git checkout -b refactor/route-result master

git pull origin refactor/route-result

Étape 2:

Fusionner les modifications et mettre à jour sur Forgejo.

git checkout master

git merge --no-ff refactor/route-result

git push origin master

Connectez-vous pour rejoindre cette conversation.

Aucune évaluation

Aucun jalon

Pas d'assignataires

2 participants

Notifications

Échéance

La date d’échéance est invalide ou hors plage. Veuillez utiliser le format 'aaaa-mm-dd'.

Aucune échéance n'a été définie.

Dépendances

No dependencies set.

Chargement…

Il n'existe pas encore de contenu.

Étiquettes Jalons

add enum containing all successful route returns #614

Codecov Report

Relecteurs

Étape 1:

Étape 2: