Use futures and tokio to send activities #620

Fusionado

elegaanz fusionados 4 commits de async-federation en master

elegaanz comentado (Migrado desde github.com)

Fixes #252

Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).

Fixes #252 Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).

igalic (Migrado desde github.com) revisado

igalic (Migrado desde github.com) dejó un comentario

👀

plume-common/src/activity_pub/mod.rs

igalic (Migrado desde github.com) comentado

is this comment still relevant?

igalic (Migrado desde github.com) comentado

if this fails, we panic with "new rt".??

igalic (Migrado desde github.com) comentado

i think we should talk about our logging strategy sometime 😅

elegaanz (Migrado desde github.com) revisado

plume-common/src/activity_pub/mod.rs

elegaanz (Migrado desde github.com) comentado

Not really, but it is for the background jobs in general, for the moment we just spawn them in a separate thread and that's it. I will remove it and create a more general issue.

elegaanz (Migrado desde github.com) revisado

plume-common/src/activity_pub/mod.rs

elegaanz (Migrado desde github.com) comentado

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it 😅

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it :sweat_smile:

elegaanz (Migrado desde github.com) revisado

plume-common/src/activity_pub/mod.rs

elegaanz (Migrado desde github.com) comentado

Indeed, we should probably use log and env_logger or something like that. Should I create an issue?

Indeed, we should probably use `log` and `env_logger` or something like that. Should I create an issue?

codecov[bot] comentado (Migrado desde github.com)

Codecov Report

Merging #620 into master will increase coverage by 0.08%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   35.28%   35.37%   +0.08%     
==========================================
  Files          68       68              
  Lines        7907     7904       -3     
  Branches     1893     1887       -6     
==========================================
+ Hits         2790     2796       +6     
+ Misses       4345     4338       -7     
+ Partials      772      770       -2

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=h1) Report > Merging [#620](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/6dbc043a7e4d1757851599859683804bf36a3409?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `26.66%`. ```diff @@ Coverage Diff @@ ## master #620 +/- ## ========================================== + Coverage 35.28% 35.37% +0.08% ========================================== Files 68 68 Lines 7907 7904 -3 Branches 1893 1887 -6 ========================================== + Hits 2790 2796 +6 + Misses 4345 4338 -7 + Partials 772 770 -2 ```

trinity-1686a revisado

trinity-1686a dejó un comentario

Propietario

👀

plume-common/src/activity_pub/mod.rs

trinity-1686a comentado

Propietario

I think this print should be done in the map just under, otherwise output could get mixed quickly, making both logs useless

plume-common/src/activity_pub/mod.rs

trinity-1686a comentado

Propietario

(what is that comma for?)

elegaanz (Migrado desde github.com) revisado

plume-common/src/activity_pub/mod.rs

elegaanz (Migrado desde github.com) comentado

(no idea, I will remove it)

elegaanz (Migrado desde github.com) revisado

plume-common/src/activity_pub/mod.rs

elegaanz (Migrado desde github.com) comentado

Actually, it is added by cargo-fmt, because this whole expression is the argument of a function.

trinity-1686a revisado

plume-common/src/activity_pub/mod.rs

trinity-1686a comentado

Propietario

okay...

trinity-1686a aprobado estos cambios

Revisores

trinity-1686a aprobado estos cambios

El Pull Request se ha fusionado como 7ea4acc289.

También puede ver instrucciones de línea de comandos.

Paso 1:

Desde el repositorio de su proyecto, revisa una nueva rama y prueba los cambios.

git checkout -b async-federation master

git pull origin async-federation

Paso 2:

Combine los cambios y actualice en Forgejo.

git checkout master

git merge --no-ff async-federation

git push origin master

Inicie sesión para unirse a esta conversación.

No hay revisores

Sin Milestone

No asignados

2 participantes

Notificaciones

Fecha de vencimiento

La fecha de vencimiento es inválida o está fuera de rango. Por favor utilice el formato 'aaaa-mm-dd'.

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Cargando…

Aún no existe contenido.

Etiquetas Hitos

Use futures and tokio to send activities #620

Codecov Report

Revisores

Paso 1:

Paso 2: