Use futures and tokio to send activities #620

Unito

elegaanz ha unito 4 commit da async-federation a master

elegaanz ha commentato (Migrato da github.com)

Fixes #252

Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).

Fixes #252 Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).

igalic (Migrato da github.com) revisionato

igalic (Migrato da github.com) lascia un commento

👀

plume-common/src/activity_pub/mod.rs

igalic (Migrato da github.com) ha commentato

is this comment still relevant?

igalic (Migrato da github.com) ha commentato

if this fails, we panic with "new rt".??

igalic (Migrato da github.com) ha commentato

i think we should talk about our logging strategy sometime 😅

elegaanz (Migrato da github.com) revisionato

plume-common/src/activity_pub/mod.rs

elegaanz (Migrato da github.com) ha commentato

Not really, but it is for the background jobs in general, for the moment we just spawn them in a separate thread and that's it. I will remove it and create a more general issue.

elegaanz (Migrato da github.com) revisionato

plume-common/src/activity_pub/mod.rs

elegaanz (Migrato da github.com) ha commentato

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it 😅

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it :sweat_smile:

elegaanz (Migrato da github.com) revisionato

plume-common/src/activity_pub/mod.rs

elegaanz (Migrato da github.com) ha commentato

Indeed, we should probably use log and env_logger or something like that. Should I create an issue?

Indeed, we should probably use `log` and `env_logger` or something like that. Should I create an issue?

codecov[bot] ha commentato (Migrato da github.com)

Codecov Report

Merging #620 into master will increase coverage by 0.08%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   35.28%   35.37%   +0.08%     
==========================================
  Files          68       68              
  Lines        7907     7904       -3     
  Branches     1893     1887       -6     
==========================================
+ Hits         2790     2796       +6     
+ Misses       4345     4338       -7     
+ Partials      772      770       -2

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=h1) Report > Merging [#620](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/6dbc043a7e4d1757851599859683804bf36a3409?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `26.66%`. ```diff @@ Coverage Diff @@ ## master #620 +/- ## ========================================== + Coverage 35.28% 35.37% +0.08% ========================================== Files 68 68 Lines 7907 7904 -3 Branches 1893 1887 -6 ========================================== + Hits 2790 2796 +6 + Misses 4345 4338 -7 + Partials 772 770 -2 ```

trinity-1686a revisionato

trinity-1686a lascia un commento

Proprietario

👀

plume-common/src/activity_pub/mod.rs

trinity-1686a ha commentato

Proprietario

I think this print should be done in the map just under, otherwise output could get mixed quickly, making both logs useless

plume-common/src/activity_pub/mod.rs

trinity-1686a ha commentato

Proprietario

(what is that comma for?)

elegaanz (Migrato da github.com) revisionato

plume-common/src/activity_pub/mod.rs

elegaanz (Migrato da github.com) ha commentato

(no idea, I will remove it)

elegaanz (Migrato da github.com) revisionato

plume-common/src/activity_pub/mod.rs

elegaanz (Migrato da github.com) ha commentato

Actually, it is added by cargo-fmt, because this whole expression is the argument of a function.

trinity-1686a revisionato

plume-common/src/activity_pub/mod.rs

trinity-1686a ha commentato

Proprietario

okay...

trinity-1686a hanno approvato queste modifiche

Revisori

trinity-1686a hanno approvato queste modifiche

La pull request è stata unita come 7ea4acc289.

Puoi anche visualizzare le istruzioni da riga di comando.

Passo 1:

Dal repository del tuo progetto, fai il check out di un nuovo branch e verifica le modifiche.

git checkout -b async-federation master

git pull origin async-federation

Passo 2:

Fai il merge delle modifiche e aggiorna su Forgejo.

git checkout master

git merge --no-ff async-federation

git push origin master

Effettua l'accesso per partecipare alla conversazione.

Nessun revisore

Nessuna milestone

Nessuna assegnatario

2 Partecipanti

Notifiche

Data di scadenza

La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Caricamento…

Non ci sono ancora contenuti.

Etichette Traguardi

Use futures and tokio to send activities #620

Codecov Report

Revisori

Passo 1:

Passo 2: