Use futures and tokio to send activities #620

Merge aplicado
elegaanz aplicou merge dos 4 commits de async-federation em master 5 anos atrás
elegaanz comentou 5 anos atrás (Migrado de github.com)

Fixes #252

Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).

Fixes #252 Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).
igalic (Migrado de github.com) revisou 5 anos atrás
igalic (Migrado de github.com) deixou um comentário

👀

👀
igalic (Migrado de github.com) comentou 5 anos atrás

is this comment still relevant?

is this comment still relevant?
igalic (Migrado de github.com) comentou 5 anos atrás

if this fails, we panic with "new rt".??

if this fails, we panic with "new rt".??
igalic (Migrado de github.com) comentou 5 anos atrás

i think we should talk about our logging strategy sometime 😅

i think we should talk about our logging strategy sometime 😅
elegaanz (Migrado de github.com) revisou 5 anos atrás
elegaanz (Migrado de github.com) comentou 5 anos atrás

Not really, but it is for the background jobs in general, for the moment we just spawn them in a separate thread and that's it. I will remove it and create a more general issue.

Not really, but it is for the background jobs in general, for the moment we just spawn them in a separate thread and that's it. I will remove it and create a more general issue.
elegaanz (Migrado de github.com) revisou 5 anos atrás
elegaanz (Migrado de github.com) comentou 5 anos atrás

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it 😅

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it :sweat_smile:
elegaanz (Migrado de github.com) revisou 5 anos atrás
elegaanz (Migrado de github.com) comentou 5 anos atrás

Indeed, we should probably use log and env_logger or something like that. Should I create an issue?

Indeed, we should probably use `log` and `env_logger` or something like that. Should I create an issue?
codecov[bot] comentou 5 anos atrás (Migrado de github.com)

Codecov Report

Merging #620 into master will increase coverage by 0.08%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   35.28%   35.37%   +0.08%     
==========================================
  Files          68       68              
  Lines        7907     7904       -3     
  Branches     1893     1887       -6     
==========================================
+ Hits         2790     2796       +6     
+ Misses       4345     4338       -7     
+ Partials      772      770       -2
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=h1) Report > Merging [#620](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/6dbc043a7e4d1757851599859683804bf36a3409?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `26.66%`. ```diff @@ Coverage Diff @@ ## master #620 +/- ## ========================================== + Coverage 35.28% 35.37% +0.08% ========================================== Files 68 68 Lines 7907 7904 -3 Branches 1893 1887 -6 ========================================== + Hits 2790 2796 +6 + Misses 4345 4338 -7 + Partials 772 770 -2 ```
trinity-1686a revisou 5 anos atrás
trinity-1686a deixou um comentário
Proprietário

👀

👀
Proprietário

I think this print should be done in the map just under, otherwise output could get mixed quickly, making both logs useless

I think this print should be done in the map just under, otherwise output could get mixed quickly, making both logs useless
Proprietário

(what is that comma for?)

(what is that comma for?)
elegaanz (Migrado de github.com) revisou 5 anos atrás
elegaanz (Migrado de github.com) comentou 5 anos atrás

(no idea, I will remove it)

(no idea, I will remove it)
elegaanz (Migrado de github.com) revisou 5 anos atrás
elegaanz (Migrado de github.com) comentou 5 anos atrás

Actually, it is added by cargo-fmt, because this whole expression is the argument of a function.

Actually, it is added by cargo-fmt, because this whole expression is the argument of a function.
trinity-1686a revisou 5 anos atrás
Proprietário

okay...

okay...
trinity-1686a aprovou estas alterações 5 anos atrás

Revisores

trinity-1686a aprovou estas alterações 5 anos atrás
O pull request teve merge aplicado como 7ea4acc289.
Você também pode ver as instruções para a linha de comandos.

Passo 1:

No repositório do seu projeto, crie um novo branch e teste as alterações.
git checkout -b async-federation master
git pull origin async-federation

Passo 2:

Faça merge das alterações e atualize no Forgejo.
git checkout master
git merge --no-ff async-federation
git push origin master
Acesse para participar desta conversação.
Sem revisor
Sem marco
Sem responsável
2 participante(s)
Notificações
Data limite
A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: Plume/Plume#620
Carregando…
Ainda não há conteúdo.